Commit graph

2675 commits

Author SHA1 Message Date
Robin Appelman
bc54c5e357 fix: allow moving from of non-resharable to other share if the user has delete permissions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-01-06 13:24:52 +00:00
Robin Appelman
bc06221dd8 feat: add fileid to exception message when reading a dav file fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-01-02 14:31:17 +00:00
Josh
8f2291d60c fix(dav): catch NotFound exception in UploadHome::childExists()
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-12-15 19:16:27 +00:00
SebastianKrupinski
662a65f60e fix: do not truncate birth year to 1970
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-12-12 15:41:59 +00:00
SebastianKrupinski
157d64e97b fix: calendar subscription memory exhaustion
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-12-11 12:32:39 -05:00
Benjamin Gaussorgues
0ff293b4ef
Merge pull request #56965 from nextcloud/backport/56925/stable32
Some checks are pending
CodeQL Advanced / Analyze (actions) (push) Waiting to run
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Integration sqlite / changes (push) Waiting to run
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, --tags ~@large files_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, capabilities_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, collaboration_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, comments_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, dav_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, federation_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, file_conversions) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, files_reminders) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, filesdrop_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, ldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, openldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, openldap_numerical_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, remoteapi_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, routing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, setup_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, sharees_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, sharing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, theming_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, videoverification_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite-summary (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis (push) Waiting to run
Psalm static code analysis / static-code-analysis-security (push) Waiting to run
Psalm static code analysis / static-code-analysis-ocp (push) Waiting to run
Psalm static code analysis / static-code-analysis-ncu (push) Waiting to run
2025-12-11 09:51:17 +01:00
Joas Schilling
1d98ab5cd6
fix(comments): Check comment object
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-12-11 07:57:56 +01:00
Christoph Wurst
38df058f6c
fix(dav): handle HTML in CalDAV invitations
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2025-12-10 16:46:00 +01:00
Salvatore Martire
5994423e2a style: apply cs-fixer to publicwebdav.php
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-12-03 15:38:27 +00:00
Salvatore Martire
6d1344779a fix: check instance of storage using helper function
instanceof cannot be used to check the instance of a storage, doing so
breaks the check in certain cases. In this case, enabling the
`files_accesscontrol` app breaks the check.

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-12-03 15:38:27 +00:00
Salvatore Martire
79e48941e0 fix: isPublicShare =true when share is public
The isPublicShare was set to false in one instance where it should have
been true. Flipping the value to true, would break the functionality for
PROPFIND /public.php/webdav/ which returns properties of files in a
share identified by the username being the share token.

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-12-03 15:38:27 +00:00
Salvatore Martire
7ede3044bf refactor: extract tree initialization logic
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-12-03 15:38:27 +00:00
Kate
70584c60d9
Merge pull request #56787 from nextcloud/backport/56527/stable32
Some checks failed
CodeQL Advanced / Analyze (actions) (push) Waiting to run
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Integration sqlite / changes (push) Waiting to run
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, --tags ~@large files_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, capabilities_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, collaboration_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, comments_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, dav_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, federation_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, file_conversions) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, files_reminders) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, filesdrop_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, ldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, openldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, openldap_numerical_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, remoteapi_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, routing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, setup_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, sharees_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, sharing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, theming_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (stable32, 8.1, stable32, videoverification_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite-summary (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis (push) Has been cancelled
Psalm static code analysis / static-code-analysis-security (push) Has been cancelled
Psalm static code analysis / static-code-analysis-ocp (push) Has been cancelled
Psalm static code analysis / static-code-analysis-ncu (push) Has been cancelled
2025-12-02 09:52:57 +01:00
Git'Fellow
4d363eea40
Merge pull request #55804 from nextcloud/backport/55800/stable32
[stable32] Fix chunked upload for file drop shares
2025-12-02 09:49:48 +01:00
provokateurin
11b09f8d47 fix(QuotaPlugin): Always check the quota before moving
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-12-02 07:32:25 +00:00
SebastianKrupinski
04014c5d51 fix: imip set language per user
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-11-25 14:56:07 +00:00
rakekniven
596f8dba56 fix(i18n): Corrected plural for multi plural languages
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2025-11-21 08:58:56 -05:00
provokateurin
b737336e4d
fix(FilesDropPlugin): Ensure all request for file request have a nickname
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-11-18 15:19:46 +01:00
provokateurin
b5ad0aad3a
fix(FilesDropPlugin): Allow MKCOL for file drop to upload folders
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-11-18 15:19:46 +01:00
provokateurin
281949faa4
fix(FilesDropPlugin): Also modify Destination header for PUT requests to satisfy the QuotaPlugin
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-11-18 15:19:46 +01:00
provokateurin
9b438cc407
Revert "fix: temporarily disable public shares chunking capability"
This reverts commit 365a040dc3.

Signed-off-by: provokateurin <kate@provokateurin.de>
2025-11-18 15:19:46 +01:00
provokateurin
bcae49614e
fix(FilesDropPlugin): Fix request method and nickname header checks
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-11-18 15:19:19 +01:00
provokateurin
309c1651be
fix(FilesDropPlugin): Fix name conflict resolution for chunked uploads
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-11-18 15:19:19 +01:00
provokateurin
f4f0a1a94b
fix(FilesDropPlugin): Disable plugin for chunked uploads
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-11-18 15:19:19 +01:00
Salvatore Martire
7ba0cb4e2c fix(pagination): render multistatus to XML before caching
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-11-04 09:53:18 +00:00
Andy Scherzinger
3d9dac1ede
Merge pull request #55860 from nextcloud/backport/55628/stable32
[stable32] fix(dav): dav:remove-invalid-shares removing federated calendar shares
2025-10-28 22:41:52 +01:00
Andy Scherzinger
6d47668fda
Merge pull request #55961 from nextcloud/backport/55955/stable32
[stable32] fix(dav): allow multiple link shares token in session
2025-10-28 22:09:12 +01:00
SebastianKrupinski
8fbe82a29f fix: use old event information if new is missing
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-10-28 12:38:51 +00:00
skjnldsv
4a7f5000ef fix(dav): allow multiple link shares token in session
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-10-23 14:11:06 +00:00
John Molakvoæ
81dbf3143b fix: temporarily disable public shares chunking capability
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-10-21 08:14:00 +00:00
Richard Steinmetz
cbec7c6ec6 fix(dav): dav:remove-invalid-shares removing federated calendar shares
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-10-20 11:20:22 +00:00
Côme Chilliet
eeb1dc86a4
fix(dav): Allow array of array of scalars, and fix error message
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-10-20 10:35:17 +02:00
Côme Chilliet
22728601ba
fix(dav): Allow arrays (of scalars) in property values
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-10-20 10:35:11 +02:00
Côme Chilliet
22f122edc7
fix(dav): Restrict properties allowed object classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-10-20 10:34:18 +02:00
Louis Chemineau
dd1ad9abeb fix(contacts): Do not expose SAB in /contactsmenu
When hitting the `/contactsmenu/contacts` endpoint with the `dav.system_addressbook_exposed` config switch set to `"no"`, the system address book content is still listed in the response.

This ensure that we do not expose unexpectedly the system address book.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-10-11 11:12:51 +00:00
Thomas Citharel
cba2723148 fix(caldav): avoid selecting every custom properties from table if we have no calendars to filter
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2025-10-10 17:25:04 +00:00
John Molakvoæ (skjnldsv)
5f09b17664 fix(systemtags): catch empty nodes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-10-08 19:06:39 +00:00
Richard Steinmetz
b47823e2bd fix(caldav): disable remote access when calendar federation is off
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-10-08 17:22:44 +00:00
Richard Steinmetz
24d2b9575a fix(caldav): encoding inconsistencies in event search provider
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-10-08 10:56:35 +00:00
Joas Schilling
eba0292af8 fix(live-photo): Allow files-live-photo meta data with edit permissions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-10-07 18:56:14 +00:00
Anna Larch
3472beba33 fix(ooo): don't catch general DB exceptions
Signed-off-by: Anna Larch <anna@nextcloud.com>
2025-10-07 11:37:18 +00:00
Hamza
a3fbc67648 fix: make sure default contact exists by default
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-09-17 10:01:19 +00:00
Louis Chemineau
431f6d7c87 fix: Dispatch favorite event with an actual path
The `$path` argument was added in https://github.com/nextcloud/server/pull/48612, but was never actually used by the callers. The path was therefore missing in the favorite/unfavorite events, which lead to a broken activity information.

I also added a fallback to handle `addToFavorites` and `removeFromFavorites`, which are part of a public API, and are calling `tagAs` and `untag` without `$path`.

Fix https://github.com/nextcloud/activity/issues/2134

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-09-15 14:38:53 +00:00
Ferdinand Thiessen
482690d80b feat(ZipFolderPlugin): always use the parent folder name as archive name
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-10 21:11:47 +00:00
Maxence Lange
7c38a4d117 feat(migration-attributes): missing attributes
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-09-04 09:02:00 +00:00
Carl Schwan
f60e7b93e7
Merge pull request #54507 from nextcloud/fix/54501/removeListener
fix: propfind query monitor breaking removeListener and removeAllList…
2025-09-03 18:51:03 +02:00
Christoph Wurst
21d28c887a
Merge pull request #54424 from nextcloud/fix/dav/user-addressbook-clean-up
fix(dav): clean up user's addressbook shares on deletion
2025-09-02 20:18:27 +02:00
Kate
74804b612c
Merge pull request #54801 from nextcloud/fix/moving-shares 2025-09-02 17:01:14 +02:00
Ferdinand Thiessen
9ba4150a18
fix(dav): ensure moving or copying a file is possible
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-02 16:23:47 +02:00
Andy Scherzinger
38327e4493
Merge pull request #54777 from nextcloud/perf/carddav/ungreedify-search
perf(carddav): ungreedify search result aggregation
2025-09-02 14:59:02 +02:00