upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-26 19:32:28 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 12
74168 commits 987 branches 1211 tags 8.7 GiB
Commit graph

1249 commits

Author SHA1 Message Date
provokateurin
2525d4b6ff
fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optional 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-05-06 10:12:24 +02:00
provokateurin
5540b2b298
fix(files_external): Convert VALUE_HIDDEN to FLAG_HIDDEN to allow combining VALUE_PASSWORD and FLAG_HIDDEN 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-05-06 10:12:23 +02:00
Richard Steinmetz
f0466187dc
fix: cast mount_id type in files_external:notify command 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2025-04-15 13:00:54 +02:00
provokateurin
eddfef147e fix(files_external): Move definition parameter to the correct place 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-02-27 14:23:13 +00:00
Oleksander Piskun
fbbfead13f fix(external_storage): Cast id to int 2024-12-03 13:02:39 +00:00
provokateurin
10f1d97689
fix(BackgroundJobs): Adjust intervals and time sensitivities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 08:42:06 +01:00
Josh Richards
0f27494a68 Clean-up some remaining readdir calls with undesirable false evaluation potential 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

[skip ci]
 2024-11-12 13:08:18 +00:00
skjnldsv
200040d9ac fix(files_external): cast storage id int 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-12 09:52:01 +00:00
Maxence Lange
1abe3c46f1 fix(files-external): set password as sensitive 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-10-31 11:15:40 +00:00
yemkareems
c481f20e95
fix: resolve conflict add PasswordConfirmationRequired to saveGlobalCredentials 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-30 17:15:11 +05:30
yemkareems
d8d72ca252
fix: conflicts resolved by adding PasswordConfirmationRequired to update method 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-29 18:02:47 +05:30
yemkareems
f5db67530a fix: add PasswordConfirmationRequired to the eternal storages mentioned in review 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-29 11:06:45 +00:00
yemkareems
b8f7415d86
fix: cs fix for namespace 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-17 13:17:26 +05:30
yemkareems
7d36883da5
fix: add PasswordConfirmationRequired to user storages create, update and delete 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-17 12:34:21 +05:30
Louis Chemineau
413d36c994 fix: Use hashed password in files_external settings 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-26 13:01:58 +00:00
Marcel Klehr
e98196b6c3 fix(files_external): Catch correct exception 
SMB#getFileInfo used to throw an icewind/smb exception, but nowadays throws \OCP\Files\ForbiddenException. This fixes downstream methods to catch the new exception.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-09-26 07:34:36 +00:00
Git'Fellow
dd42b6cdc8 fix(files_external): Check key exists before accessing it 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-09-14 16:54:43 +00:00
Daniel Calviño Sánchez
0644361147 fix: Fix unmodified placeholder replacing the actual value when updating 
When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-09-05 04:18:38 +02:00
Julius Härtl
53f92e68e6 fix: Pass the mountpoint target user to storages without owner 
Storages that do not have a dedicated owner (e.g. groupfolders, external
storages) currently always assume the current session user as the owner.
This leads to several issues when there is no user session but a node is
obtained through a user folder.

In order to have the correct user available we need to pass the user
that is used to setup a mountpoint along to the storage layer as we
generally assume that an owner is available for those.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-09-03 12:23:37 +02:00
Andy Scherzinger
f02bbf8eb6
Merge pull request #46678 from nextcloud/backport/44295/stable28 
[stable28] Allow injecting the user temporarily for direct editing
 2024-07-25 19:41:20 +02:00
Robin Appelman
e2ee8140b0 feat: add a specialized writeStream implementation for s3 external storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-25 11:01:12 +00:00
Julius Härtl
1c75c5f1e0 fix: Implement option to temporarily set the user session 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-07-22 12:44:21 +00:00
Andy Scherzinger
290ccdb684
Merge pull request #46090 from nextcloud/backport/46073/stable28 
[stable28] fix: allows admin to edit global credentials
 2024-07-11 17:06:24 +02:00
Daniel Calviño Sánchez
c360c208ee fix: Do not log an error when connecting to SFTP without a logged in user 
When connecting to a SFTP server from a SFTP storage the host key is
checked against the known host keys stored in a file in the data
directory of the logged in Nextcloud user. The path to the file is
(indirectly) got using "OC_App::getStorage", which logs an error if
called when there is no logged in user; this can happen, for example, if
the storage is used from a background job or a command.

Not being able to read or write the file just causes the host key check
to be skipped, but it has no other consequence. Moreover, even with
logged in users it is likely that the file can not be read either and
the check is also skipped, as the file needs to have been manually
created by an admin.

Due to all that now the path to the file is directly created using a
View rather than relying on "OC_App::getStorage" to prevent the unneeded
error from being logged.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-07-11 08:16:07 +02:00
Benjamin Gaussorgues
c7082d5fb8 fix: allows admin to edit global credentials 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-07-11 08:13:47 +02:00
Julius Härtl
d0e26cfd57 fix: Allow to disable multipart copy on external s3 storage 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-03-21 16:45:33 +01:00
Benjamin Gaussorgues
1afaac7031 fix(files_external): list root when using SMB case-insensitive option 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-02-12 10:16:31 +00:00
provokateurin
98d64ea05d refactor: Migrate IgnoreOpenAPI attributes to OpenAPI 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-01-19 09:12:34 +01:00
Joas Schilling
dec04eccb0 fix(files_external): Fix "Could not find resource main.js to load" 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-12-01 15:28:41 -06:00
Valdnet
962dea6a62 Correct a typo 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2023-11-29 10:36:43 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
jld3103
755de1e0b5 refactor: Rename OpenAPI type aliases to their namespaces 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-11-02 11:37:15 +01:00
Benjamin Gaussorgues
c52d5e418a
Merge pull request #41053 from nextcloud/bug/smb/in-place-case-rename 
fix(files_external): on case insensitive system, block case change
 2023-10-31 16:07:29 +01:00
Joas Schilling
4759e7a22d
fix(external): Get storage before update it 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-10-26 06:46:05 +02:00
Louis Chemineau
e66e8bad1a
Return correct status if touch failed 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-10-23 15:26:43 +02:00
Benjamin Gaussorgues
a45e12abc8
fix(files_external): on case insensitive system, block case change 
When a file/directory is renamed to the same name with only case change,
the rename fail. We block this kind of rename.
The user will have to rename to another name first.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-10-23 10:32:28 +02:00
John Molakvoæ
ae29608e46
fix(files_external): basic auth user storage trigger 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-10-10 12:07:48 +02:00
Louis
45cac16432
Merge pull request #39131 from fsamapoor/refactor_lib_files_external_commands 
Refactors files_external app commands
 2023-09-28 14:39:49 +02:00
Hamid Dehnavi
d64bbc8bd3 Convert isset ternary to null coalescing operator 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
 2023-09-28 12:18:41 +03:30
Faraz Samapoor
eab7818f0e Adds parameter type hints. 
Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-09-28 09:02:10 +03:30
Faraz Samapoor
32838d8f0a Refactors files_external app commands. 
To improve code readability.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-09-28 09:02:10 +03:30
jld3103
c2d45cb172
Add single status code descriptions for OpenAPI 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-09-27 08:05:21 +02:00
Robin Appelman
b11ca34bbd
Merge pull request #40499 from nextcloud/known-mtime-wrapper 
add wrapper for external storage to ensure we don't get an mtime that is lower than we know it is
 2023-09-21 18:33:15 +02:00
John Molakvoæ (skjnldsv)
a5a8655beb fix: avoid side-effect imports 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2023-09-21 12:40:42 +02:00
Robin Appelman
eab8dd3ca0 use multipart copy for s3 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-20 17:28:48 +02:00
Robin Appelman
ccf8843d9f apply known mtime wrapper for external storages 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-19 13:58:35 +02:00
Robin Appelman
cf7344082d
Merge pull request #40183 from nextcloud/sftp-fixes 
SFTP improvements
 2023-09-18 19:14:27 +02:00
Robin Appelman
d42d809170 sftp psalm fixes 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-18 16:12:03 +02:00
John Molakvoæ
2018c72eaa
Merge pull request #39895 from nextcloud/fix/noid/revoke-admin-overwrite 2023-09-05 14:52:09 +02:00
Robin Appelman
c264903cb9
psalm suppress 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:12 +02:00