Commit graph

31779 commits

Author SHA1 Message Date
John Molakvoæ
8cf7ab105e
Merge pull request #47918 from nextcloud/backport/47914/stable29
[stable29] fix(LDAP): check index before accessing it
2024-09-15 22:54:05 +02:00
John Molakvoæ
cde8cd074b
Merge pull request #47850 from nextcloud/backport/47807/stable29
[stable29] fix(files_sharing): password checkbox and labels in link share
2024-09-15 22:16:52 +02:00
John Molakvoæ
9bd55710fe
Merge pull request #47877 from nextcloud/backport/47848/stable29
[stable29] fix(files): Reset context menu position on close
2024-09-15 22:15:11 +02:00
John Molakvoæ
16abf05bfd
Merge pull request #47895 from nextcloud/backport/47339/stable29
[stable29] fix: Display 'Leave share' instead of 'Delete'
2024-09-15 22:14:34 +02:00
John Molakvoæ
ef298a8687
Merge pull request #47903 from nextcloud/backport/47881/stable29
[stable29] fix(settings): Add back create group icon
2024-09-15 22:14:06 +02:00
Nextcloud bot
6530553720
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-15 00:26:52 +00:00
Git'Fellow
61684129e1 fix(files_external): Check key exists before accessing it
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-14 16:56:05 +00:00
Nextcloud bot
392c0f568e
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-14 00:21:35 +00:00
John Molakvoæ (skjnldsv)
be1bc08061 fix(files_external): broken credentials dialog
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

[skip ci]
2024-09-13 15:20:43 +00:00
Josh Richards
dc65c37af4 fix: custom port handling in UI for SFTP
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-09-13 03:10:27 +02:00
Nextcloud bot
a73e38b498
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-13 00:21:01 +00:00
Arthur Schiwon
89cfc7c2a5 fix(LDAP): check index before accessing it
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-09-12 10:55:34 +00:00
Nextcloud bot
2b9fc3b19e
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-12 00:20:34 +00:00
Christopher Ng
69faba6da7 fix(settings): Add back create group icon
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-11 10:45:09 -07:00
skjnldsv
b9ef97260d fix(files_sharing): adjust permissions from custom edit and delete check methods
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-11 13:55:06 +02:00
Marcel Klehr
c80dd9dfec fix: Display 'Leave share' instead of 'Delete'
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-09-11 11:54:35 +00:00
Ferdinand Thiessen
eb897b112e
fix(files): Make openMenu watcher null safe
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-11 11:53:15 +02:00
Ferdinand Thiessen
2a5d6bb713 fix(files): Reset context menu position on close
* Resolves https://github.com/nextcloud/server/issues/46934

Ensure that after a right-click the context menu position is resetted,
so that pressing the "actions"-menu button it is displayed on the correct location.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-11 09:15:41 +02:00
Nextcloud bot
87605dd358
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-11 00:21:29 +00:00
Nextcloud bot
33ccc430cf
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-10 00:37:45 +00:00
Grigorii K. Shartsev
819c6aeab1 fix(files_sharing): add accessible labels in link share creation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-09 23:43:28 +02:00
Grigorii K. Shartsev
80c52467f1 fix(files_sharing): checkbox for password in link share is not shown
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-09 14:42:35 +00:00
Nextcloud bot
789ccf8798
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-09 00:23:40 +00:00
Nextcloud bot
8668546e5e
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-08 00:36:50 +00:00
Nextcloud bot
f6dae38968
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-07 00:37:14 +00:00
Nextcloud bot
7ec40bfe35
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-06 00:25:25 +00:00
Louis
8f28394a06
Merge pull request #47786 from nextcloud/backport/47770/stable29
[stable29] fix(dav): Always respond custom error page on exceptions
2024-09-05 22:44:37 +02:00
Andy Scherzinger
3bc5ea4fd9
Merge pull request #47780 from nextcloud/backport/47519/stable29
[stable29] feat(transfer-ownership): Correctly react to encrypted files
2024-09-05 20:42:33 +02:00
Louis Chemineau
987840592e fix(dav): Always respond custom error page on exceptions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-05 18:15:51 +00:00
Côme Chilliet
4a9d5851ab fix(transfer-ownership): Improve comments according to code review
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 16:01:31 +00:00
Côme Chilliet
adcb5da338 feat(transfer-ownership): Correctly react to encrypted files
For E2EE encrypted files, we abort the transfer.
For SSE encrypted files, we abort only if not using master key.
Also fixed the check for when the path to a single file is used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 16:01:31 +00:00
Côme Chilliet
48c807e667 fix(setupchecks): Test overwrite.cli url first, then generated one, and
trusted domains as last fallback.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 15:53:45 +00:00
Daniel Kesselberg
e004fb7042 fix: add option to remove the webroot for setup checks and don't check trusted_domains.
1) The checks for well-known urls should always run against the root domain and therefore the option to remove the webroot.

2) For trusted domains, the available protocol is unknown, and thus some guesswork would be needed to make that work. I've decided for now to not consider them anymore to reduce false-positives.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-05 15:53:45 +00:00
Arthur Schiwon
35085228dc
Merge pull request #47337 from nextcloud/backport/47332/stable29
[stable29] fix(caldav): allow renaming of birthday calendars
2024-09-05 11:32:58 +02:00
Daniel Calviño Sánchez
c514a73fd3
Merge pull request #47734 from nextcloud/backport/46859/stable29
[stable29] Fix status check and saving of external storages
2024-09-05 04:28:36 +02:00
Nextcloud bot
0249a2970d
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-05 00:24:06 +00:00
Daniel Calviño Sánchez
844505023e fix: Hide status tooltip in row to add a new mount point
The row to add a new mount point is cloned when a new mountpoint is

added, so it is expected that it includes a status span. However, it

should not be displayed in that row, only in the cloned row when its

status is updated.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
5ed377e003 fix: Fix unmodified placeholder replacing the actual value when updating
When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
66c689083b fix: Reset selected backend when adding a new storage
As a new storage is added by selecting a backend the selected backend
needs to be reset. Otherwise it is not possible to add another storage
with the same backend.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
8a97029857 fix: Add missing translation for UI string
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
cdc64d18c4 fix: Restore default status tooltip when no status message is provided
If the status is updated but no explicit message is provided (for
example, if the status check succeeded) the default tooltip (from the
template) is now set to prevent a mismatch between the status and the
tooltip (for example, if the configuration is fixed after a failed
status check).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
981a20e84f fix: Set status tooltip to error message on failed actions
When saving, updating and rechecking an storage fails (which is
different to the soft-fail when the action itself succeeds but the
status check does not) further details are provided in the error message
of the response, which is now set as the tooltip.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
caa7936530 fix: Set status tooltip to status message when saving an storage
When a storage is saved the status check can fail even if saving the
storage succeeds. In those cases further details are provided in the
status message of the storage, which is now set as the tooltip,
similarly to how it is done when rechecking the storage.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
8d3ff42f78 fix: Remove status check when configuration was changed
Setting a null status was supposed to remove the status check, but
nothing was changed in that case. Now the status check is properly
removed, and doing that by hiding the element rather than just turning
it invisible also prevents that clicking on the invisible status
triggers a check, as until the new configuration is saved the check will
still be performed with the old configuration, which could be misleading
for the user.

Additionally, an explicit width is set to the parent of the span element
to prevent its width from changing when the span is shown and hidden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
b71da3d389 fix: Recheck userglobal storages when loaded
Userglobal storages are now automatically recheck when loaded, similarly
to how it is done for global storages.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
80f038cc67 refactor: Store result in its own variable
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Anna Larch
8f838b2fe8 fix(caldav): allow renaming of birthday calendars
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-04 23:18:30 +02:00
skjnldsv
bcb536e04d fix(files): undefined displayname for outdated @nextcloud/files<3.6.0 apps
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-04 17:01:53 +00:00
skjnldsv
7a64f8ee19 fix(files): undefined sidebar
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-04 16:09:58 +00:00
Ferdinand Thiessen
e0a310bc51 fix(files): Typo in import of ShareType
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-04 14:26:19 +00:00