Commit graph

157 commits

Author SHA1 Message Date
Daniel Calviño Sánchez
66c689083b fix: Reset selected backend when adding a new storage
As a new storage is added by selecting a backend the selected backend
needs to be reset. Otherwise it is not possible to add another storage
with the same backend.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
8a97029857 fix: Add missing translation for UI string
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
cdc64d18c4 fix: Restore default status tooltip when no status message is provided
If the status is updated but no explicit message is provided (for
example, if the status check succeeded) the default tooltip (from the
template) is now set to prevent a mismatch between the status and the
tooltip (for example, if the configuration is fixed after a failed
status check).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
981a20e84f fix: Set status tooltip to error message on failed actions
When saving, updating and rechecking an storage fails (which is
different to the soft-fail when the action itself succeeds but the
status check does not) further details are provided in the error message
of the response, which is now set as the tooltip.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
caa7936530 fix: Set status tooltip to status message when saving an storage
When a storage is saved the status check can fail even if saving the
storage succeeds. In those cases further details are provided in the
status message of the storage, which is now set as the tooltip,
similarly to how it is done when rechecking the storage.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
8d3ff42f78 fix: Remove status check when configuration was changed
Setting a null status was supposed to remove the status check, but
nothing was changed in that case. Now the status check is properly
removed, and doing that by hiding the element rather than just turning
it invisible also prevents that clicking on the invisible status
triggers a check, as until the new configuration is saved the check will
still be performed with the old configuration, which could be misleading
for the user.

Additionally, an explicit width is set to the parent of the span element
to prevent its width from changing when the span is shown and hidden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
b71da3d389 fix: Recheck userglobal storages when loaded
Userglobal storages are now automatically recheck when loaded, similarly
to how it is done for global storages.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Daniel Calviño Sánchez
80f038cc67 refactor: Store result in its own variable
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Ferdinand Thiessen
278f9799d1
fix(files_external): Remove invalid jQuery Tooltip usage
This caused the UI to throw an error causing it to be unusable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-18 01:23:40 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +01:00
Vincent Handfield
da83464459 Fix: External storage - exception thrown for the handler whenSelectAuthMechanism
Signed-off-by: Vincent Handfield <vincent@accestech.com>
2023-04-17 15:49:25 +02:00
Vincent Petry
bfcb2690a4
Merge pull request #36087 from nextcloud/enh/noid/improve-applicable-ext-storage
Improve saving applicable users in ext storage
2023-01-16 15:08:19 +01:00
Vincent Petry
a0f70988f4
Extend ext storage params to contain default value
Extend the external storage configuration parameters definition to allow
to specify a default value

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-13 10:27:17 +01:00
Vincent Petry
4f35cd5ebf
Improve saving applicable users in ext storage
Added a checkbox to prevent saving "All users" by mistake and giving
access to everyone when not wanted.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-12 10:13:12 +01:00
Lukáš Tyrychtr
d760cde535 Fix accessibility of buttons in the external storage configuration
Note that there is no keyboard only way to close the dropdown

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-08-03 19:33:12 +00:00
Vincent Petry
bb2557c389
Replace files app ids to classes
Replaced ids to classes for the following:

- #filestable -> .files-filestable
- #fileList -> .files-fileList
- #controls -> .files-controls
- #emptycontent -> .emptyfilelist.emptycontent

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-26 10:19:19 +02:00
szaimen
dcbcb266cc update the wording of external storage deletion
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-04-07 17:25:14 +02:00
Louis Chemineau
4763a1263f Explicitly close div element
Fix: #30002
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-04 17:52:44 +00:00
Robin Appelman
7933de00f3 don't recheck config automatically when there are a large number of storages
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-17 16:29:35 +00:00
Robin Appelman
4601f11986 add all storage config rows in one go on load
this prevents repeated reflows

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-17 16:29:35 +00:00
Louis Chemineau
d92cbf5149 Typing corrections
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:12:55 +01:00
Vincent Petry
ea30297552
Add option to disallow creation of local storages
Introduce a new config option to prevent web UI admins to create
or edit external storages of type "local".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-12-15 09:15:31 +01:00
Vincent Petry
a7e8da9da8 Add spinner when loading ext storages
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-12-06 11:52:26 +00:00
MichaIng
3a36984f50 Migrate deprecated toolip methods
With Bootstrap v4, the tooltip methods "fixTitle" and "destroy" have been removed. Only core/src/Polyfill/tooltip.js keeps them methods valid by translating them.

Signed-off-by: MichaIng <micha@dietpi.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-09-26 22:18:20 +02:00
Valdnet
a923761acb
l10n: Spelling unification
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-20 11:33:31 +02:00
Arthur Schiwon
5322d30d51
save group ids not display names in configuration
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-30 14:52:37 +01:00
Daniel Kesselberg
d0f18f4d9a Add local version of escapeHTML
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-07 23:06:42 +02:00
Roeland Jago Douma
85406bcaa5
Remove encryption option for nextcloud external storage
Fixes #16017

Since it never worked we should not show it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-20 16:28:03 +02:00
John Molakvoæ (skjnldsv)
6fcd075730
Use DOMContentLoaded and fix sharebymail loading issue
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-07-20 12:42:08 +02:00
Morris Jobke
065ef14cb0
Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH usage in files_external
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-10 00:02:59 +02:00
Robin Appelman
857957b45e
allow setting tooltips for external storage config options
allows explaining non-obvious config options a bit more

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-03 15:44:53 +02:00
rakekniven
e1bc815813
l10n: Triple dot to ellipsis
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
2020-02-05 06:31:42 +01:00
Joas Schilling
9645e545b3 Fix JS namespace of files_external app
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-30 09:43:26 +01:00
Roeland Jago Douma
c43e0d6e28
Move files_external to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-19 08:41:01 +02:00
Julius Härtl
635575f271
files_external: Move delete option to 3-dots menu
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:41:08 +02:00
Julius Härtl
a66481932d
Add group icon
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-24 18:48:25 +02:00
Roeland Jago Douma
db96b0bb0b
Make it possible to make external storages read only
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 15:18:56 +02:00
rakekniven
2b0c523cc0
Update settings.js
Added question mark.
Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/120539223?issue=yes
2018-03-10 12:57:09 +01:00
Morris Jobke
77927442a6
Merge pull request #8496 from nextcloud/ext-strg-design-fixes
External storage design fixes and update
2018-02-27 15:59:06 +01:00
John Molakvoæ (skjnldsv)
5f217e2d83
fixup! Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 13:25:42 +01:00
John Molakvoæ (skjnldsv)
6ee9a2b35b
fixup! Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 13:05:39 +01:00
John Molakvoæ (skjnldsv)
6b45d7e549
Fixed actions and header missing th
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 11:35:11 +01:00
John Molakvoæ (skjnldsv)
887241b355
Show error if no external storage configured
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 18:14:19 +01:00
John Molakvoæ (skjnldsv)
dab83c4a49
Select in popover fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:37 +01:00
John Molakvoæ (skjnldsv)
323dd31056
Tooltip fix on status icon
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:37 +01:00
John Molakvoæ (skjnldsv)
1f3eef9460
fixup! Changed config saving feedback design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:34 +01:00
John Molakvoæ (skjnldsv)
0cc520f3a0
Changed config saving feedback design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:32 +01:00
John Molakvoæ (skjnldsv)
1e2a082cd2
Use popovermenu instead of dropdown and small fix to popovermenu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 12:15:32 +01:00
Robin Appelman
a92596db78
Fix confirmation dialog when deleting external storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-10-12 13:55:25 +02:00
Robin Appelman
2b7c489d75
ask for confirmation when deleting an external storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-09-27 17:59:56 +02:00