upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-03 20:41:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 25
68040 commits 651 branches 1179 tags 8.1 GiB
Commit graph

105 commits

Author SHA1 Message Date
Louis Chemineau
9f3d1b792c fix(files): Use isRetryable to catch retryable exceptions 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-06-12 08:11:18 +00:00
Louis Chemineau
69bb0bf3e8 feat(files)): Add retry logic to cover deadlock situations when moving many files 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-05-07 10:42:24 +02:00
Arthur Schiwon
96eca4a3ea fix(ci): update return type in php doc 
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-10-11 14:41:43 +02:00
Robin Appelman
29c36f85b0 fix type hints 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-10-11 14:41:43 +02:00
Robin Appelman
0fde240089 fix unencrypted folder size when no children with unencrypted size set are left 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-10-11 14:41:43 +02:00
Robin Appelman
1a70ba6421 fix unencrypted_size for folders when scanning the filesystem with encryption enabled 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-10-11 14:41:43 +02:00
Arthur Schiwon
f7d890cd66
Merge pull request #39726 from nextcloud/backport/39698/stable26 
[stable26] Catch more invalid cache source storage paths
 2023-09-05 18:59:48 +02:00
Andy Scherzinger
f3619d8558
Merge pull request #39872 from nextcloud/backport/38714/stable26 
[stable26] select the fileid first when looking for incomplete files
 2023-08-28 13:44:48 +02:00
Ferdinand Thiessen
15ea32c1e1 fix: Prevent PHP warnings when optional CacheEntry attributes are unset 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-08-17 10:03:53 +00:00
Robin Appelman
690d9bac5e select the fileid first when looking for incomplete files 
this seems to improve mariadbs index selection

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-14 19:15:41 +00:00
John Molakvoæ
fe85d7d05d fix: simplify sourceData check 
Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2023-08-05 22:04:35 +00:00
Josh Richards
c4505160a0 Catch more invalid cache source storage paths 
OC\Files\Cache\Cache::get can return string|false|null, not just string|false.

- nextcloud/server#26270 added handling of false, but null is needed too.
- Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason

Related: nextcloud/server#19009

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2023-08-05 22:04:35 +00:00
Côme Chilliet
d618b8061c
Get rid of more int casts in file size manipulations 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-15 17:26:18 +02:00
Robin Appelman
40748731f1 clear encrypted flag when moving away from encrypted storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-01 16:49:37 +00:00
Joas Schilling
4bdc5834fa
Make sure name and path are strings 
Otherwise Oracle returns NULL for empty strings and PHP 8.2
throws on null in string functions like trim() and md5()

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-02 12:05:22 +01:00
Joas Schilling
c27c9fac98
Try fixing Oracle 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-02 12:05:21 +01:00
Robin Appelman
de63f6363f fix updating size when folder is empty 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-16 13:54:26 +02:00
Robin Appelman
1374cbee3e store unencrypted size in the unencrypted_size column 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-16 13:54:26 +02:00
Robin Appelman
5e375d9092 Revert "store unencrypted size in the unencrypted_size column" 
This reverts commit 8238582e59.

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-16 12:07:14 +02:00
Côme Chilliet
cb271b759e
Fix dynamic property creations in test files 
This fixes warnings in PHP 8.2

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-08-01 15:07:53 +02:00
luz paz
368f83095d Fix typos in lib/private subdirectory 
Found via `codespell -q 3 -S l10n -L jus ./lib/private`

Signed-off-by: luz paz <luzpaz@github.com>
 2022-07-27 08:52:17 -04:00
Jonas
7d07e06bfe Check whether entry is of type ICacheEntry in Cache->remove() 
In some scenarios (file not in cache, but partial data of it in the
object), Cache->get() might return an array, which leads to errors like
"Call to a member function getId() on array".

So check whether the returned entry is of type ICacheEntry before doing
operations on it in Cache->remove().

Fixes: #33023

Signed-off-by: Jonas <jonas@freesources.org>
 2022-06-29 10:47:07 +00:00
Robin Appelman
8238582e59
store unencrypted size in the unencrypted_size column 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-06-02 16:07:00 +02:00
Côme Chilliet
ea23523c70
Adapt more code to migration to LoggerInterface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 16:21:25 +01:00
acsfer
074a9a5e88
Switch logical operators 
Unless there is a good reason to keep actual ones 👀
 2021-12-03 16:05:19 +01:00
John Molakvoæ
63d3931e80
Merge pull request #29281 from vijfhoek/master 2021-11-01 11:29:37 +01:00
Carl Schwan
bfa60aaf27
Fix permissions when copying from ObjectStorage 
Make sure that when a user copy a file from a directory they don't have
all permissions to a directory where they have more permissions, the
permissions are correctly set to the one from the parent taget folder.

This was caused by the ObjectStoreStorage::copyFromStorage using
the jailed storage and cache entry instead of the unjailed one like other
storages (the local one).
Steps to reproduce

+ Use object storage
+ Create a groupfolder with one group having full permission and another one
  who can just read files.
+ With an user who is in the second group, copy a file from the groupfolder to
  the home folder of this user.
+ The file in the home folder of the user will be read only and can't be deleted
  even though it is in their home folder and they are the owner. In oc_filecache,
  the permissions stored for this file are 1 (READ)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-10-28 13:29:50 +02:00
Sijmen Schoon
34600c78bb
Move query outside the loop and reduce chunk size to 1000 
This involved changing CacheQueryBuilder\whereParentIn to take a
parameter name, renaming the function accordingly.

Signed-off-by: Sijmen Schoon <me@sijmenschoon.nl>
 2021-10-17 20:57:28 +02:00
Sijmen Schoon
c959bf2b42
Limit parameter count per query in Cache.removeChildren 
Signed-off-by: Sijmen Schoon <me@sijmenschoon.nl>
 2021-10-17 19:10:58 +02:00
Carl Schwan
28970563a2
Remove some mentions of ownCloud from our api documentation 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-07-29 15:56:30 +02:00
Robin Appelman
362cb2a11f
inject SearchBuilder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-06-14 16:23:08 +02:00
Robin Appelman
5d1d53c42e
perform file search in a single query 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-06-14 16:11:29 +02:00
Robin Appelman
9774fb1573
use searchoperation for storage filter instead of db expression 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-06-14 16:11:25 +02:00
Robin Appelman
e198dc1b20
rework search api to allow searching on multiple caches at once 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-06-14 16:11:22 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
John Molakvoæ (skjnldsv)
2074d87d0c
Catch invalid cache source storage path 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-03-24 10:36:51 +01:00
Robin Appelman
50e374c12f
only require user to be set in a query that handles tags 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-18 17:16:28 +01:00
Robin Appelman
f1e2fb426e
Merge pull request #26013 from nextcloud/object-store-copy-cache-id 
Return the fileid from `copyFromCache` and use it instead of doing an extra query
 2021-03-16 16:11:17 +00:00
Robin Appelman
d7748e2b4d
verify that cache entry is valid 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-12 17:23:02 +01:00
Robin Appelman
d2bcb57a54
add ICopyFromCache trait to expose existing implementation 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-12 17:22:36 +01:00
Robin Appelman
a44aab11f7
do cachejail search filtering in sql 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-01-26 15:30:46 +01:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-08 11:45:19 +01:00
Christoph Wurst
9ce3ea3368
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-30 14:07:05 +01:00
Roeland Jago Douma
4973f9b952
Merge pull request #24715 from nextcloud/bug/noid/limit-get-incomplete-to-1 
Limit getIncomplete query to one row
 2020-12-21 09:15:10 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Daniel Kesselberg
e0e76bb784
Limit getIncomplete query to one row 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-12-15 21:42:26 +01:00
Robin Appelman
aef1cdba03
code style and dispatchTyped 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-12-02 16:15:02 +01:00
Robin Appelman
88f35d52d2
rename cache event to follow new naming standards 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-26 15:39:46 +01:00
Robin Appelman
23fb497ff5
extend cache events 
- adds cache remove event
- expose storage id in event
- emit events during cache move

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-26 15:22:03 +01:00
Joas Schilling
cffad62771
Empty string is returned as null, but empty string in file cache is the root and exists 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:35:43 +01:00