Commit graph

11614 commits

Author SHA1 Message Date
Joas Schilling
7ae9eac6ac fix(ratelimit): Only use memory cache backend for redis
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-06 18:55:16 +02:00
Daniel Kesselberg
c4286730fa
enh: skip processing for empty response
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-05 12:22:58 +02:00
Joas Schilling
58c20cf54e
fix(apps): Fix loading info.xml file
Ref: https://bugs.php.net/bug.php?id=62577

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-20 10:56:23 +02:00
Joas Schilling
da708a589d
fix(dav): Abort requests with 429 instead of waiting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-10 07:03:04 +02:00
Daniel Kesselberg
6ca2973b17
chore: use local variable for remote address
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-10 06:58:55 +02:00
Robin Appelman
7f4de89b5e
use source cache when listing folder during recursive copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-19 12:29:18 +02:00
Joas Schilling
56596678e0
fix(middleware): Also abort the request when reaching max delay in afterController
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:29:57 +02:00
Joas Schilling
cdc27e25d2 feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-03 13:10:39 +00:00
Côme Chilliet
1578120133
Fix LENGTH function name across databases
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-14 10:53:44 +01:00
Côme Chilliet
e40dd0c276
Use OCTET_LENGTH which is more common than LENGTHB
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-14 10:50:41 +01:00
Côme Chilliet
8e73f29480 Add octetLength and charLength to function builder, and tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-13 16:14:15 +00:00
blizzz
0a5c2e5319
Merge pull request #35391 from nextcloud/backport/35074/stable22
[stable22] Make sure that path is normalized and then checked and not the other way around
2022-12-08 11:50:56 +01:00
Côme Chilliet
66d295e654
Make sure that path is normalized and then checked,
and not the other way around

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-24 09:45:57 +01:00
blizzz
6e3b26fd2a
Merge pull request #33923 from nextcloud/backport/33813/stable22
[stable22] Compare lowercase email when updating from ldap
2022-10-06 10:55:54 +02:00
blizzz
2be5fd5889
Merge pull request #33208 from nextcloud/backport/32997/stable22
[stable22] load dashboard widgets of enabled apps only
2022-09-08 21:55:28 +02:00
Louis Chemineau
9bca0b3794 I dug into it again, and the issue is much simpler than I previously though.
- LDAP has an email address with capital letters
- NC store this address in lower case
- When the user logs in, we compare the [stored email with the new lower case email](https://github.com/nextcloud/server/blob/master/lib/private/AllConfig.php#L259-L261) before storing it. Here, both email will be the same, so we won't store the new email address with upper case letters. Which is what we want.
- We then [compare emails as they are before triggering an event](https://github.com/nextcloud/server/blob/master/lib/private/User/User.php#L202-L204), they won't match, so the user will receive an email signaling an email change every time he logs in.

The fix is to compare the old email with the new lower case email before sending the event.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-09-06 15:28:40 +00:00
Carl Schwan
a1d042d756
Merge pull request #33159 from nextcloud/backport/32987/stable22
[stable22] Fix hook encryption with cron job
2022-09-02 11:08:33 +02:00
Arthur Schiwon
1b824542ef logger ignore args of sharepoint-related methods
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-08-25 11:52:45 +00:00
Julius Härtl
42acad15dd Do not update passwords if nothing changed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-18 14:21:01 +00:00
Côme Chilliet
3b42eb01c7
Remove call to undefined function, fix typing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-02 16:07:39 +02:00
Côme Chilliet
6de71bdaa0
Align copied file with our code style
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-02 16:07:32 +02:00
Côme Chilliet
f1fdc90fa3
Copy IpUtils from Symfony to avoid new dependency on backport
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-02 16:07:15 +02:00
Côme Chilliet
f4988d87ab Use Symfony IpUtils to check for local IP ranges
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:49:05 +00:00
Côme Chilliet
81c18a832f Check for local IPs nested in IPv6 as well
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:49:03 +00:00
Côme Chilliet
4b2fc65ac1 Refactor local IP if and set strict to true for in_array
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:49:01 +00:00
Côme Chilliet
c0be5cc91d Improve local IP detection
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:48:59 +00:00
Julien Veyssier
f744a0c97a
fix lint issues, stay compatible with php7.3
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-07-12 12:37:38 +02:00
Arthur Schiwon
a51b7fe6e7 avoid early DI of IAppManager
- might break install

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-12 08:52:06 +00:00
Arthur Schiwon
ebe48f415a load widgets only of enabled apps
- per design, all enabled apps have their registration run
- limitations, e.g. enabled by group, are not considered in that state,
  because we do not have a session (and might need apps?)
- before instantiation of widget it has to be checked whether the providing
  app is actually enabled for the logged in user.
- a public interface is being changed, but it is not meant to be
  implemented or used outside of the core handling. Therefore save to
  backport.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-12 08:52:04 +00:00
Louis Chemineau
7a454a7702 FInish backport to stable22 of #32322
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-07 12:45:34 +02:00
Louis Chemineau
3ecb7da97b Add setting to ignore email during search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-07 12:45:32 +02:00
Louis Chemineau
752a9fa8d6 Add settings to ignore second display name in search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-07 12:42:29 +02:00
Louis Chemineau
3b2d69c62b Add settings to not match userID during full match
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-07 12:41:56 +02:00
Carl Schwan
4398bb9077 Fix hook encryption with cron job
Make sure the setup fs is set before using the Update service

Backport of #29674

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-07 10:06:03 +00:00
Carl Schwan
b141d39944 Allow to disable password policy enforcement for selected groups
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-07-07 09:27:34 +02:00
Christopher Ng
bdf84c45ac Do not save invalid display name to the database
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-07-06 21:00:50 +00:00
blizzz
6509c841b3
Merge pull request #32681 from nextcloud/backport/32510/stable22
[stable22] Properly calculate primary element based on background luminance
2022-07-06 13:32:49 +02:00
Jonas
3fbd7a6602 Check whether entry is of type ICacheEntry in Cache->remove()
In some scenarios (file not in cache, but partial data of it in the
object), Cache->get() might return an array, which leads to errors like
"Call to a member function getId() on array".

So check whether the returned entry is of type ICacheEntry before doing
operations on it in Cache->remove().

Fixes: #33023

Signed-off-by: Jonas <jonas@freesources.org>
2022-06-30 12:24:01 +00:00
Côme Chilliet
6fc8060e95 Improve local domain detection
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-23 11:00:26 +00:00
Robin Appelman
2182b45a2c
Merge pull request #32816 from nextcloud/seeakble-http-stream-wrappers-22
[22] handle stream wrappers in SeekableHttpStream
2022-06-21 15:05:37 +00:00
blizzz
3e64e3e57d
Merge pull request #32917 from nextcloud/revert-32845-backport/32685/stable22
Revert "[stable22] Fix replacing external storage password during debug log"
2022-06-17 18:40:14 +02:00
Arthur Schiwon
f9270b21e8
make placeholder a const for reuse
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-17 14:58:01 +02:00
Arthur Schiwon
bf5487482d
fix overwriting original vars when logging
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-17 14:58:01 +02:00
blizzz
3226f0ca46
Revert "[stable22] Fix replacing external storage password during debug log" 2022-06-17 12:25:18 +02:00
Christoph Wurst
28b3be9aee
Merge pull request #32845 from nextcloud/backport/32685/stable22
[stable22] Fix replacing external storage password during debug log
2022-06-15 12:26:02 +02:00
blizzz
c46a8d8f86
Merge pull request #31707 from nextcloud/backport/31605/stable22
[stable22] cache the path of the certificate bundle
2022-06-13 11:20:58 +02:00
Christoph Wurst
6f2c402b3e Fix replacing external storage password during debug log
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-06-13 07:48:29 +00:00
Joas Schilling
3189626a81
Fix exception handling when profile data is too long
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-12 13:53:14 +02:00
Robin Appelman
682cc2ea53 remove storage wrappers when deleting the user storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-10 15:43:38 +00:00
Robin Appelman
64ed9964ac
handle stream wrappers in SeekableHttpStream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-10 17:06:06 +02:00