Commit graph

12299 commits

Author SHA1 Message Date
Julius Härtl
a04ed00f63 fix: Avoid resetting scss cacher when no variables are found
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-27 07:30:50 +00:00
Simon L
a420cb97df
Merge pull request #36730 from nextcloud/backport/36691/stable24
[stable24] add a disk_free_space check before writing config
2023-02-24 10:19:48 +01:00
Côme Chilliet
5061926573 Avoid extra parenthesis around SQL in IN expressions
The expression builder already suround the SQL with parenthesis when
 using in(), so we must not add another pair, this confuses at least
 sqlite.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-21 16:56:44 +00:00
Simon L
b3a64a9121 fix it for 32-bit
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-20 10:15:20 +01:00
Simon L
b3fb30b8b0 address review by Joas
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-15 17:57:06 +00:00
Simon L
a87f45a6ca add a disk_free_space check before writing config
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-15 17:57:03 +00:00
blizzz
4d0a68eca1
Merge pull request #36441 from nextcloud/backport/36433/stable24
[stable24] fix(encryption): don't throw on missing file
2023-02-09 13:07:18 +01:00
blizzz
6ff9ca9bfc
Merge pull request #36376 from nextcloud/backport/35894/stable24
[stable24] fix moving files of encrypted local storage to unencrypted local storage
2023-02-09 12:28:48 +01:00
Richard Steinmetz
18ca00b216 fix(encryption): don't throw on missing file
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-02-07 18:12:12 +00:00
Robin Appelman
920e8ad21a fix moving files of encrypted local storage to unencrypted local storage
for example when moving encrypted files to a groupfolder

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-07 18:00:28 +00:00
Joas Schilling
fc711c9539 Fix double where() usage in resource manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-07 17:59:46 +00:00
Julius Härtl
f23532b095 Do not store generated mysql password if it was not used
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-01-27 06:43:39 +00:00
Simon L
664133edbb imaginary - add tiff to supported formats
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-01-25 20:23:44 +00:00
Christoph Wurst
fa08275ab2
Merge pull request #35824 from nextcloud/backport/35614/stable24
[stable24] Fix array to string conversion in errorlog writer
2023-01-25 19:34:19 +01:00
Christoph Wurst
f9fc4fbdd9
fix(logging): Fix array to string conversion in errorlog writer
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-24 08:54:10 +01:00
Vincent Petry
617088835f
Merge pull request #35946 from nextcloud/backport/33813/stable24
[stable24] Compare lowercase email when updating from ldap
2023-01-19 10:13:10 +01:00
Julius Härtl
739d6951f8
Merge pull request #36168 from nextcloud/backport/35970/stable24
[stable24] Improve exception serializing
2023-01-19 10:09:37 +01:00
Julius Härtl
a2073f4d4d
fix(ExceptionSerializer): encode arguments before filtering the trace
This will avoid running into a Nesting level too deep error as the
encodeArg calls will limit potential recursive calls on the arguments to
a nesting level of 5

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-01-18 16:34:52 +01:00
Robin Appelman
0bd5bcdaeb escape path prefix when doing cache jail search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-01-11 17:12:40 +00:00
John Molakvoæ
467c213795
Merge pull request #35094 from nextcloud/invalidateTokensWhenDeletingOAuthClient
fixes https://github.com/nextcloud/server/issues/35068
2023-01-06 08:52:57 +01:00
Louis Chemineau
34a93a0e12 I dug into it again, and the issue is much simpler than I previously though.
- LDAP has an email address with capital letters
- NC store this address in lower case
- When the user logs in, we compare the [stored email with the new lower case email](https://github.com/nextcloud/server/blob/master/lib/private/AllConfig.php#L259-L261) before storing it. Here, both email will be the same, so we won't store the new email address with upper case letters. Which is what we want.
- We then [compare emails as they are before triggering an event](https://github.com/nextcloud/server/blob/master/lib/private/User/User.php#L202-L204), they won't match, so the user will receive an email signaling an email change every time he logs in.

The fix is to compare the old email with the new lower case email before sending the event.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-02 15:30:15 +00:00
Côme Chilliet
6def133792
Remove null from quota type
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 15:49:53 +01:00
Côme Chilliet
602cc7260c
Silence a warning from psalm with explanation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 12:24:29 +01:00
Côme Chilliet
39cb3549be
Adapt types of subclasses
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 12:24:18 +01:00
Côme Chilliet
5421510b12
Make it clear that file sizes may be float on 32bits
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 12:24:05 +01:00
Vincent Petry
82397529ef
Remove quota value type for 32-bit systems
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-02 12:22:07 +01:00
Artur Neumann
0570327c7e public interface to invalidate tokens of user
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-20 16:26:49 +00:00
Christoph Wurst
125ddf01cc fix(logging): Fix array to string conversion in errorlog writer
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-19 13:46:38 +00:00
Vincent Petry
28b8d6b94f
Merge pull request #35799 from nextcloud/backport/35780/stable24
[stable24] Fix missing cast of double controller parameters
2022-12-19 12:07:23 +01:00
Vincent Petry
488d10b6fc
Merge pull request #35524 from nextcloud/backport/35502/stable24
[stable24] Fix SQL comparison with int array during external storage deletion
2022-12-16 18:16:04 +01:00
Christoph Wurst
7fceb57843 fix(app framework): Fix missing cast of double controller parameters
``settype`` allows 'double' as alias of 'float'.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-16 15:33:51 +00:00
Vincent Petry
07361adb48
Merge pull request #35657 from nextcloud/backport/35649/stable24
[stable24] Update the unencrypted file size when closing streams
2022-12-16 16:33:24 +01:00
Artur Neumann
8cf9878fd2 check if params given to API are really an array
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-16 10:50:41 +00:00
Varun Patil
eea1f3c53e preview: fix HEIC orientation
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2022-12-11 11:19:57 +00:00
Julius Härtl
d843ba9822 Also update the unencrypted size of files when creating them with empty content
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 21:15:57 +00:00
Julius Härtl
da45a807ac Update the unencrypted file size when closing streams
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 21:15:57 +00:00
Andy Xheli
775c62860c Fix Executing a query: SQLSTATE[42000]
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Fix https://github.com/nextcloud/server/issues/32007#issuecomment-1329405245

Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
2022-11-30 15:04:47 +00:00
Vincent Petry
c73f11ba4d
Float the quota
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-24 21:09:28 +01:00
Vincent Petry
7a66cb84dc
Revert "[stable24] Fix quota type to int"
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-24 21:09:28 +01:00
Louis
8707beb89c
Merge pull request #35367 from nextcloud/backport/35353/stable24
[stable24] Update cache when file size === 0
2022-11-23 19:39:59 +01:00
Louis Chemineau
cadcebf962 Update cache when file size === 0
The conditions were false when $result === 0.
$results here contains the number of written bits.
The correct way of checking for operation success is to check if $result === false

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-11-23 15:04:34 +00:00
Joas Schilling
c892ba43d1 Fix forwarding the object id when searching comments
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-23 10:42:25 +00:00
Vincent Petry
c39caba4a0
Don't use quota cache through user management
When querying the free space through user management APIs, don't use the
cached quota value. The latter is only there to accelerate PROPFINDs.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-21 23:47:10 +01:00
Simon L
c56fcca872
Merge pull request #35250 from nextcloud/bugfix/noid/quota-zero
[stable24] Properly compare quota against both float/int values
2022-11-21 18:39:49 +01:00
Côme Chilliet
e24df2255d
Merge pull request #35141 from nextcloud/backport/34160/stable24
[stable24] Detect weird local ips
2022-11-21 09:33:17 +01:00
Joas Schilling
9f8b6e99da
Merge pull request #35245 from nextcloud/backport/32288/stable24
[stable24] Fix JSON error when comment has no reactions
2022-11-19 20:44:09 +01:00
Robin Appelman
4b4b80bc1c delay updating setup providers untill we register the mounts
otherwise the fallback to a full setup for a missing cached mount provider will lead to a race condition

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-18 14:38:30 +00:00
Julius Härtl
f66226d18e
Properly compare quota against both float/int values
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-18 14:12:43 +01:00
Joas Schilling
3f1865b729
Fix JSON error when comment has no reactions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-18 11:13:54 +01:00
Joas Schilling
996bb092ff
Mark more config values as sensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-16 10:08:04 +01:00