Commit graph

20018 commits

Author SHA1 Message Date
Claus-Justus Heine
a355410b88
Use the unjailed-path in OC_Helper::getStorageInfo() for files located in SharedStorage.
The current implementation already switches the storage-backend to
$storage->getSourceStorage(). However, it then calls
$rootInfo->getInternalPath() which returns the internal path relative to
the storage where the share is mounted. This is wrong, we need also to
unjail the path. Compare, e.g., with
OCA\Files_Sharing\SharedStorage::file_get/put_contents() for the
"logic".

Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2022-02-03 10:05:49 +01:00
Nextcloud bot
e167d7f44c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-03 02:26:58 +00:00
Joas Schilling
5e5c31ea84
Merge pull request #30235 from nextcloud/bugfix/noid/primary-key-for-ratelimit-table
Add primary key for ratelimit table
2022-02-02 10:03:26 +01:00
Robin Appelman
c712987878
send request id in response header
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-01 14:24:01 +01:00
Côme Chilliet
d635d58d19
Merge pull request #29286 from nextcloud/enhancement/drop-php-7-3
Drop PHP7.3
2022-02-01 10:50:28 +01:00
Claus-Justus Heine
a234217bb7
Allow sub-admins to access delegated settings.
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2022-01-31 14:08:49 +01:00
Joas Schilling
b59df35426
Make the DB query simpler (as we just deleted all other entries)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-28 16:55:17 +01:00
Joas Schilling
fcb3e9a071
Add a primary key to ratelimit_entries table
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-28 16:55:16 +01:00
Joas Schilling
e8c66d0f89
Merge pull request #30794 from nextcloud/techdebt/noid/allow-to-get-comments-with-verb
Allow to get comments with a given set of verbs
2022-01-28 16:41:42 +01:00
John Molakvoæ
73e3d06781
Merge pull request #30855 from nextcloud/psalm/theming 2022-01-27 20:04:02 +01:00
Vincent Petry
363bf208a0
Merge pull request #30876 from nextcloud/docs/deprecate_addScript
Add deprecation notice to script & addScript func
2022-01-27 17:34:13 +01:00
Carl Schwan
f778cbe7b9
Fix registerEventListener issues
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-27 11:12:45 +01:00
Louis
34f425c150
Merge pull request #30858 from nextcloud/fix/ajax-list-dir-content-on-file
Return 404 when AJAX tries to list dir content but file given
2022-01-27 11:08:23 +01:00
Louis Chemineau
04c9de7312 Add deprecation notice to script & addScript func
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-27 11:04:30 +01:00
Simon L
d23de2653e
Merge pull request #30832 from nextcloud/untrusted_domains_warning
Makes untrusted domain error a warning.
2022-01-26 18:28:17 +01:00
Joas Schilling
fe6ceba03a
Merge pull request #30822 from nextcloud/bugfix/29287/remove-create-function-calls
Remove createPluralFunction which is replaced by Symfony\Translations…
2022-01-26 16:31:21 +01:00
MichaIng
ba1338e680 Return 404 when AJAX tries to list dir content but file given
Due to a code mistake, the expected 404 return when AJAX tries to list a directory content with a non-directory file path given, does not happen. It instead fails with another exception.

This commit restores the original intention to return 404 in the first place when passing a non-directory path with the "dir" parameter.

Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-26 16:11:50 +01:00
Carl Schwan
e3a12b3482
Fix psalm issues in theming app
After this change, we are down to only one psalm warning for this app
and related to the Application.php. This also make composer
psam:update-baseline not silently ignore new errors.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-26 14:26:58 +01:00
Christoph Wurst
4259391162
Drop PHP7.3
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-01-25 17:25:08 +01:00
Côme Chilliet
5cca86ce19
Remove redundant if clause
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-25 16:53:35 +01:00
Côme Chilliet
35dcda36a3
Fix OC\Files\Storage\DAV::hasUpdated when cache is not set
Fixes the test OCA\Files_External\Tests\Storage\WebdavTest::testStat on
 PHP>=7.4

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-25 16:53:19 +01:00
Pierre Ozoux
e6d9ef2e38 Makes untrusted domain error a warning.
It sends a 400 to the client, so I could even argue that it should be an error.

But currently as an admin, I'm quiet surprised that I get a 400 in the UI, and nothing in the log with the default level.

I saw this commit that explains the reason why info. But I disagree.

Feel free to close the PR if you don't agree with it.

Signed-off-by: Pierre Ozoux <pierre@ozoux.net>
2022-01-25 10:33:31 +01:00
John Molakvoæ
272f4cd6df
Merge pull request #30763 from nextcloud/feature/noid/allow-to-log-audit-to-syslog 2022-01-25 10:25:13 +01:00
Côme Chilliet
ddae16d480
Add specific psalm-return for getAllUserValues
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-24 11:16:44 +01:00
Côme Chilliet
a6eb7dc676
Fix signatures and null $userId corner case
Configuration values are sometimes queried when there is no user in
 session, so $userId is null and we just want to return the default

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-24 11:16:44 +01:00
Côme Chilliet
d630af4ca8
Add a new method getAllUserValues($userId) to IConfig
The method was already there in AllConfig but private

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-24 11:16:37 +01:00
Joas Schilling
f03468342e
Remove createPluralFunction which is replaced by Symfony\Translations lib
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-24 09:27:01 +01:00
Nextcloud bot
6e47104bb6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-24 02:26:40 +00:00
Nextcloud bot
9f489422b4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-22 02:26:35 +00:00
Joas Schilling
fccb98c8b6
Merge pull request #30379 from nextcloud/feature/add-comments-reactions
Add comments reactions
2022-01-21 15:08:12 +01:00
Joas Schilling
d2833a6552
Fix typo in deprecated
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 14:34:45 +01:00
Joas Schilling
1ceba64863
Allow to get comments with a given set of verbs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 13:42:04 +01:00
Vitor Mattos
ab630f2cab
Fix conflict
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:41 -03:00
Vitor Mattos
b9f74584a1
Fix check after change from string to mb_string
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:41 -03:00
Joas Schilling
c9f2f00777
Fix CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:40 -03:00
Joas Schilling
ecb98f772e
Throw if trying to save reaction without support
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:40 -03:00
Joas Schilling
e0b89cd576
Only check mb_strlen()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:40 -03:00
Joas Schilling
d850dc0220
Remove order from groupConcat as it is not working everywhere
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:39 -03:00
Joas Schilling
189f9f96ce
Limit the summary and sort it afterwards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:39 -03:00
Vitor Mattos
f071b4dfbb
Fix groupConcat and ordering on Oracle
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:39 -03:00
Vitor Mattos
f7cd995612
Order the reaction summary, improvements on validations
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:39 -03:00
Vitor Mattos
1ce894a50c
Disable reactions if database don't support utf8mb4
Fix column size

Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:37 -03:00
Vitor Mattos
b845042a67
Update composer autoload and change string to constant
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:07 -03:00
Vitor Mattos
898e87fe1a
Rename vars and move logic to method
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:07 -03:00
Vitor Mattos
afe5b6dd8a
Prevent query error when use subquery
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 -03:00
Vitor Mattos
a7c0868a4c
Prevent violate constraint
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 -03:00
Vitor Mattos
1dda03e1b5
Rename vars
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:05 -03:00
Vitor Mattos
9efbc9c1d5
Add comments reactions
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:04 -03:00
Julien Veyssier
7f7980f35c
Merge pull request #30770 from nextcloud/enh/logo-link-target-config
Allow changing the top-left logo link target in config.php
2022-01-20 18:02:37 +01:00
Côme Chilliet
ff809410f8
Merge pull request #30769 from nextcloud/fix/memcached_clear
Always call flush() as getAllKeys() is broken
2022-01-20 16:30:26 +01:00