upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-01 13:00:44 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 8
60040 commits 695 branches 1186 tags 7 GiB
Commit graph

121 commits

Author SHA1 Message Date
Robin Appelman
6502dfae34
add better index for finding unindexed paths 
for the following query 'SELECT "path" FROM "oc_filecache" WHERE ("storage" = $storage) AND ("size" < 0) ORDER BY "fileid" DESC LIMIT 1;'

currently the database will in some cases decide to priorize the sort by fileid over the filter when picking what index to use, resulting in a much slower query.

by creating an index that allows first sorting by fileid and also filter by storage and size this case will be greatly sped up

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-10-07 16:11:49 +02:00
Carl Schwan
6958d8005a
Add admin privilege delegation for admin settings 
This makes it possible for selected groups to access some settings
pages.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-09-29 21:43:31 +02:00
Lukas Reschke
474a5b55d3 Implement review feedback 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-09-13 11:01:35 +02:00
Lukas Reschke
358eaba7dd
Apply suggestions from code review 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
 2021-09-13 10:43:01 +02:00
Lukas Reschke
471167019c Implement PR review feedback 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-09-07 18:03:34 +02:00
Lukas Reschke
a915372c56 phpcs 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-09-06 17:50:23 +02:00
Lukas Reschke
378cc922c4 Adjust logic to store period instead of current timestamp 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-09-06 17:31:36 +02:00
Lukas Reschke
d4f97affc1 Add database ratelimiting backend 
In case no distributed memory cache is specified this adds
a database backend for ratelimit purposes.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-09-06 16:31:01 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Roeland Jago Douma
14ee17e5c5
Revert "add a prefix index to filecache.path" 2021-04-08 10:09:13 +02:00
Robin Appelman
b28f0a0e94
add a prefix index to filecache.path 
The reason that `filecache.path` hasn't had an index added is the mysql limitation of ~1kb for indexeded fields,
which is to small for the `path`, however mysql supports indexing only the first N bytes of a column instead of the entire column,
allowing us to add an index even if the column is to long.

Because the index doesn't cover the entire column it can't be used in all situations where a normal index would be used, but it does cover the `path like 'folder/path/%'` queries that are used in various places.

Sqlite and Postgresql don't support prefix indexes, but they also don't have the 1kb limit and DBAL handles the differences in index creation.

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-19 18:52:25 +01:00
Joas Schilling
47e14c9a79
Add missing index on the user column 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-17 09:51:31 +01:00
Joas Schilling
f1bb4e5699
Add a KnownUsers database with model 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-10 15:05:48 +01:00
Roeland Jago Douma
2ea3cb7c93 Drop redundant indes 
Those indexes are already covered by others. So those can just be used.
THose extra indexes just take up space.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-02-16 11:38:43 +01:00
Roeland Jago Douma
3d61adc908
Drop authtoken_version_index 
The index was used when deleting old tokens. On top of that the index is
of course not that great since the version is either 1 or 2.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-01-20 09:34:41 +01:00
Christoph Wurst
c1d4f8161b
Migrate internal classes to the OCP db col types 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-12 14:09:13 +01:00
Morris Jobke
5ed673e5eb
Merge pull request #25073 from nextcloud/psalm/24521/remove-unneeded-casts 
Remove unneeded casts that were found by Psalm
 2021-01-11 14:15:16 +01:00
Morris Jobke
24d436cb60
Remove unneeded casts that were found by Psalm 
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-11 13:14:41 +01:00
Vincent Petry
2a93c403a4
Don't remove assignable column for now 
It causes side effects.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-01-11 11:58:14 +01:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-08 11:45:19 +01:00
Joas Schilling
30c603c6b2
Fix column name to check prior to deleting 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-01-07 10:50:36 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Julius Härtl
0befe07127
Change further columns to be nullable with a default of 0 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 15:23:29 +01:00
Julius Härtl
28491ad2d8
Handle oc_dav_properties migration 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 12:13:35 +01:00
Julius Härtl
3c9218ab26
Move authtoken login_name column to varchar(255) 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 12:13:34 +01:00
Julius Härtl
76addfa44c
Add missing mount_id index 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 12:13:34 +01:00
Julius Härtl
fe80a65c3e
Drop attributes on oc_share table 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 12:13:34 +01:00
Julius Härtl
f276ccbbc3
Drop assignable systemtag column 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 12:13:34 +01:00
Julius Härtl
de67719d9f
Drop oc_dav_job_status table 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 12:13:34 +01:00
Vincent Petry
ab43d6a11e
Adjust execution duration to 0 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2020-12-09 12:13:33 +01:00
Julius Härtl
83f4f480ab
Fix missing authtoken scope 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 12:13:32 +01:00
Julius Härtl
9c2e9f2625
Add missing table columns 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 12:13:32 +01:00
Joas Schilling
eaba155a09
Add a database table for the accounts data so we can search it better 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:37 +01:00
Julius Härtl
81070c753b
Merge pull request #24053 from nextcloud/bugfix/noid/fix-user-status-for-oracle 2020-11-12 21:43:31 +01:00
Robin Appelman
6b8078a009
fix migration of oc_credentials table 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-12 15:03:21 +01:00
Joas Schilling
85ec5eb531
Also make direct_edit.accessed nullable 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-11 14:46:06 +01:00
Joas Schilling
264d54b388
Fix CS 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:43:34 +01:00
Joas Schilling
d5df033ede
Create primary keys on all tables and add a command to create the afterwards 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:36:27 +01:00
Joas Schilling
5b5aebbf66
Replace the credentials table with one that can have empty user 
Primary key columns on Oracle can not have empty strings

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:36:27 +01:00
Joas Schilling
ecbb066dec
Make sure columns with an empty default are nullable for Oracle 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:35:16 +01:00
Robin Appelman
634c051be6
add size index for filecache 
improves performance of #23004

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-09-22 15:15:34 +02:00
Morris Jobke
99c9423766
Remove @suppress SqlInjectionChecker 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-09-16 15:53:56 +02:00
Joas Schilling
5e3c4f9609
Fix installing on Oracle 
Empty strings are stored as null in Oracle,
so a column with NotNull can not have an empty string as default

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-09-07 11:58:34 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Daniel Kesselberg
87dd760a89
Replace TYPE with TYPES 
As TYPE::* is deprecated.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-30 23:46:22 +02:00
Mario Danic
6e28c2807b
Add index to properties table 
Signed-off-by: Mario Danic <mario@lovelyhq.com>
 2020-04-30 23:04:15 +02:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
2a529e453a
Use a blank line after the opening tag 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:50:14 +02:00
Roeland Jago Douma
9a4193f557
Merge pull request #19761 from nextcloud/bugfix/19658/add_missing_index_to_original_migration 
Add missing index to original migration
 2020-04-06 09:44:34 +02:00