Carl Schwan
4c79c2faff
Merge pull request #57591 from nextcloud/carl/query-exception
...
refactor(QueryException): Remove most usage of QueryException
2026-01-20 15:59:56 +01:00
nextcloud-command
dd6a947a2a
chore: Update minimum supported desktop version
...
Signed-off-by: GitHub <noreply@github.com>
2026-01-18 21:54:53 +01:00
Carl Schwan
9a8d45d81f
refactor(QueryException): Remove most usage of QueryException
...
This is preparation to move QueryException from OCP to OC as part of
Nextcloud 34.
Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-01-16 11:55:06 +01:00
Andy Scherzinger
6a0e7e318b
Merge pull request #57513 from nextcloud/carl/shareplugin
...
refactor(dav): Remove dead property
2026-01-14 17:50:22 +01:00
Ferdinand Thiessen
0fa396d0b8
Merge pull request #57509 from nextcloud/fix/use-strict-array-search
...
CodeQL Advanced / Analyze (actions) (push) Waiting to run
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Integration sqlite / changes (push) Waiting to run
Integration sqlite / integration-sqlite (master, 8.4, main, --tags ~@large files_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, capabilities_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, collaboration_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, comments_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, dav_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, federation_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, file_conversions) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, files_reminders) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, filesdrop_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, ldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, openldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, openldap_numerical_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, remoteapi_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, routing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, setup_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, sharees_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, sharing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, theming_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, videoverification_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite-summary (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis (push) Waiting to run
Psalm static code analysis / static-code-analysis-security (push) Waiting to run
Psalm static code analysis / static-code-analysis-ocp (push) Waiting to run
Psalm static code analysis / static-code-analysis-ncu (push) Waiting to run
Use strict array search
2026-01-13 15:22:20 +01:00
Carl Schwan
ea40ade012
refactor(dav): Remove dead property
...
The user folder is no longer used.
Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-01-13 14:09:05 +01:00
Côme Chilliet
dc843f6d0a
fix: Use strict array search in other shipped apps as well
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-01-13 11:48:36 +01:00
Carl Schwan
a1979c9cd1
perf(dav): Avoid getting DB Connection inside callback
...
Fetch it once outside instead and pass it to the callback.
Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-01-13 11:47:11 +01:00
Robin Appelman
c2cd236411
Merge pull request #57191 from nextcloud/dav-x-user-id
...
feat: also send x-user-id for dav responses
2026-01-09 18:43:36 +01:00
Benjamin Gaussorgues
5403284b23
Merge pull request #55293 from nextcloud/jtr/refactor-dav-quotaplugin
2026-01-08 11:18:02 +01:00
Robin Appelman
72632faaf1
Merge pull request #57284 from nextcloud/allow-cross-share-move-delete
...
fix: allow moving from of non-resharable to other share if the user has delete permissions
2026-01-06 14:23:51 +01:00
Robin Appelman
3580680f8f
Merge pull request #56166 from nextcloud/dav-file-get-log-id
...
feat: add fileid to exception message when reading a dav file fails
2026-01-02 15:30:22 +01:00
Stephan Orbaugh
97ba753e09
Merge pull request #57230 from nextcloud/fix/inodebypath-forbidden-responses
...
fix: drop readable check
2026-01-02 11:07:45 +01:00
Robin Appelman
d21fa1c0b5
feat: add fileid to exception message when reading a dav file fails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-12-31 14:06:46 +01:00
Andy Scherzinger
32327c6285
Merge pull request #56773 from nextcloud/carl/remove-sciencemesh
...
refactor(share): Remove code related to science mesh integration
2025-12-30 14:18:53 +01:00
Robin Appelman
39c8141f0c
fix: allow moving from of non-resharable to other share if the user has delete permissions
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-12-29 17:39:43 +01:00
Salvatore Martire
678bf538bf
fix: drop readable check
...
This check was introduced in a previous PR, causing disruptive
changes in PROPFIND responses in some cases.
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-12-22 18:48:10 +01:00
Robin Appelman
69249a3ce3
feat: also send x-user-id for dav responses
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-12-19 18:20:01 +01:00
Salvatore Martire
2a4ee2df9f
fix: add INodeByPath to Directory
...
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-12-10 18:30:44 +01:00
Andy Scherzinger
71c2e94123
Merge pull request #54436 from nextcloud/s3-signed-url
...
perf(s3): Provide direct pre-signed download link
2025-12-09 12:38:20 +01:00
Carl Schwan
b6313f68d3
perf(s3): Expose pre-signed urls for S3
...
This is faster than going back to nextcloud to download the files.
This is an opt-in setting that can be enabled by setting
use_presigned_url in the object store config.
Additionally add support for the proxy config which is needed in a
docker setup. See https://github.com/juliusknorr/nextcloud-docker-dev/pull/431
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-12-09 11:21:35 +01:00
nextcloud-command
40c504ec2d
chore: Update minimum supported desktop version
...
Signed-off-by: GitHub <noreply@github.com>
2025-12-08 00:32:02 +00:00
Salvatore Martire
31af870ef0
Merge pull request #55147 from nextcloud/fixPublicShares
...
CodeQL Advanced / Analyze (actions) (push) Waiting to run
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Integration sqlite / changes (push) Waiting to run
Integration sqlite / integration-sqlite (master, 8.4, main, --tags ~@large files_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, capabilities_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, collaboration_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, comments_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, dav_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, federation_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, file_conversions) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, files_reminders) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, filesdrop_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, ldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, openldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, openldap_numerical_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, remoteapi_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, routing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, setup_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, sharees_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, sharing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, theming_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, videoverification_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite-summary (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis (push) Waiting to run
Psalm static code analysis / static-code-analysis-security (push) Waiting to run
Psalm static code analysis / static-code-analysis-ocp (push) Waiting to run
Psalm static code analysis / static-code-analysis-ncu (push) Waiting to run
Reflect public shares in `isPublic` flag and fix permission check
2025-12-03 16:37:33 +01:00
Carl Schwan
cc7655136c
refactor(share): Remove code related to science mesh integration
...
The app was not updated for the past 2 years.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-12-03 14:11:58 +01:00
Salvatore Martire
631318f86f
style: apply cs-fixer to publicwebdav.php
...
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-12-01 18:09:25 +01:00
Salvatore Martire
4ac0fcf02e
fix: check instance of storage using helper function
...
instanceof cannot be used to check the instance of a storage, doing so
breaks the check in certain cases. In this case, enabling the
`files_accesscontrol` app breaks the check.
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-12-01 18:09:25 +01:00
Salvatore Martire
38f8423cd6
fix: isPublicShare =true when share is public
...
The isPublicShare was set to false in one instance where it should have
been true. Flipping the value to true, would break the functionality for
PROPFIND /public.php/webdav/ which returns properties of files in a
share identified by the username being the share token.
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-12-01 18:09:25 +01:00
Salvatore Martire
c5ad20d925
refactor: extract tree initialization logic
...
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-12-01 18:09:25 +01:00
provokateurin
b1deae7232
fix(QuotaPlugin): Always check the quota before moving
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-12-01 16:07:02 +01:00
Ferdinand Thiessen
d6d6747a73
refactor: apply rector rules for PHPUnit 10
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-27 21:56:04 +01:00
skjnldsv
9c98b722f4
fix(dav): allow multiple link shares token in session
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-10-23 13:10:39 +02:00
Joas Schilling
d6cafee543
Merge pull request #55382 from nextcloud/bugfix/noid/files-live-photo-permission
...
fix(live-photo): Allow files-live-photo meta data with edit permissions
2025-10-07 20:55:53 +02:00
Carl Schwan
3004f628e9
refactor(Sabre/Node): Remove dead code
...
property_cache is no longer used.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-06 16:33:28 +02:00
Joas Schilling
7cc4a0e59f
fix(live-photo): Allow files-live-photo meta data with edit permissions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-09-28 17:31:51 +02:00
Josh
a9b17a1a16
chore: Add OCP\Util import
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-09-26 13:42:47 -04:00
Josh
5f5bb77bf3
fix: Update QuotaPlugin to handle 32-bit numeric lengths correctly
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-09-26 13:40:59 -04:00
Josh
fbe5238d7f
fix: review input
...
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-09-26 13:17:47 -04:00
Josh
cc96a16df5
fix: Apply suggestions from code review
...
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-09-26 13:11:51 -04:00
Josh
45eb87ba6e
chore: Change methods back to public for tests
...
Tagged with \@internal instead for now.
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-09-24 18:32:54 -04:00
Josh
01e0ca7298
chore: lint compliance :)
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-09-24 18:21:49 -04:00
Josh
3bb5ed502a
refactor(dav): Clean up QuotaPlugin and add new hints
...
Add new hints and improve documentation for the QuotaPlugin. This commit also removes unused code and tidies up some code, which improves readability and simplifies maintenance, without introducing breaking changes.
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-09-24 18:13:48 -04:00
Louis Chemineau
634e8d2587
fix: Dispatch favorite event with an actual path
...
The `$path` argument was added in https://github.com/nextcloud/server/pull/48612 , but was never actually used by the callers. The path was therefore missing in the favorite/unfavorite events, which lead to a broken activity information.
I also added a fallback to handle `addToFavorites` and `removeFromFavorites`, which are part of a public API, and are calling `tagAs` and `untag` without `$path`.
Fix https://github.com/nextcloud/activity/issues/2134
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-09-15 15:04:00 +02:00
Ferdinand Thiessen
6dede68baa
feat(ZipFolderPlugin): always use the parent folder name as archive name
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-10 21:10:01 +02:00
Carl Schwan
f60e7b93e7
Merge pull request #54507 from nextcloud/fix/54501/removeListener
...
fix: propfind query monitor breaking removeListener and removeAllList…
2025-09-03 18:51:03 +02:00
Ferdinand Thiessen
9ba4150a18
fix(dav): ensure moving or copying a file is possible
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-02 16:23:47 +02:00
Richard Steinmetz
40117dced3
Merge pull request #54426 from nextcloud/perf/prevent-fetching-account
...
perf: prevent fetching a principal's user account if the data is not needed
2025-08-28 16:59:38 +02:00
Richard Steinmetz
5b254ea39a
perf: prevent fetching a principal's user account if the data is not needed
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-08-28 14:13:29 +02:00
Git'Fellow
995c97acb4
chore(MtimeSanitizer): Print bad values to help debugging
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-08-28 11:44:06 +02:00
Salvatore Martire
5d028cfaf8
fix: propfind query monitor breaking removeListener and removeAllListeners
...
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-08-21 11:59:36 +02:00
Carl Schwan
94e2af0302
perf(comments): Also cache the comments count
...
Since we now have an easy way to fetch the comments count.
Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
2025-08-21 11:30:56 +02:00
