upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-11 06:44:09 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 10
54658 commits 697 branches 1182 tags 8.2 GiB
Commit graph

4426 commits

Author SHA1 Message Date
Vincent Petry
ecaa02678a
Update user share must use correct expiration validation 
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.

To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-19 11:07:04 +01:00
Morris Jobke
f302616544
Merge pull request #26092 from nextcloud/backport/25722/stable19 
[stable19] apply object store copy optimization when 'cross storage' copy is wit…
 2021-03-17 20:09:11 +01:00
Robin Appelman
1d1d4de991
adjust tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-16 15:27:00 +01:00
Robin Appelman
b9b2c6d2fa
fix search in nested jails 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-16 15:27:00 +01:00
Robin Appelman
75a48fbc2a
fix cachjail searching for root 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-16 15:26:59 +01:00
Robin Appelman
564390e303
do cachejail search filtering in sql 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-16 15:26:59 +01:00
Robin Appelman
b39f9fb2c9 apply object store copy optimization when 'cross storage' copy is within the same object store 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-12 16:16:38 +00:00
Arthur Schiwon
8315de942c
adjust applicable version 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-02-17 20:07:56 +01:00
Arthur Schiwon
1bb5314491
compatibility to Nc 19 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-02-17 17:26:18 +01:00
Arthur Schiwon
8f499b9c8a
add missing changes from backport source 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-02-17 17:25:41 +01:00
Arthur Schiwon
1dca63ea99 test: adjust expectation 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-02-02 20:48:44 +00:00
Arthur Schiwon
fcf358e0df add repair job for unencoded calendars 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-02-02 20:48:39 +00:00
Arthur Schiwon
83b0b84c1f
DB: warn on parameter number constraints 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-01-15 00:53:37 +01:00
Morris Jobke
57e165c244
Merge pull request #24593 from nextcloud/backport/23912/stable19 
[stable19] use in objectstore copy
 2021-01-07 13:28:38 +01:00
Julius Härtl
d77b3345b2
Show unique displayname context in the sharing input 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-01-05 10:06:32 +01:00
Robin Appelman
dedff0facb use in objectstore copy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-12-07 16:07:25 +00:00
Arthur Schiwon
10a252c905
set the display name of federated sharees from addressbook 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-11-25 14:32:06 +01:00
Daniel Calviño Sánchez
a50132e4e1 Add unit tests for "validateExpirationDateInternal" 
They were copied and adjusted as needed from the tests for
"validateExpirationDate".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:20:13 +00:00
Daniel Calviño Sánchez
ca133ea2cc Add explicit time to test date for clarity 
This shows in a clearer way that the expected expiration date is the
original one, but without time.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:20:08 +00:00
Daniel Calviño Sánchez
16b1b655cf Add unit test for expiration date with date and with default 
This adds back what was being actually tested in the unit test fixed in
the previous commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:20:05 +00:00
Daniel Calviño Sánchez
1aed476937 Fix unit test for expiration date without date but with default 
The expiration date was explicitly given, so it was not testing what it
should. Moreover, "link_defaultExpDays" needs to be mapped when testing
the default value (even if it will just fallback to the value of
"shareapi_expire_after_n_days").

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:20:02 +00:00
Daniel Calviño Sánchez
2e0352182b Fix unit test method name 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:19:59 +00:00
Daniel Calviño Sánchez
e13c5ece4f Fix unit test for verifying enforced valid expiration date. 
The enforced expiration date was not actually enabled, as for that
"shareapi_default_expire_date" needs to be explicitly set to "yes".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:19:56 +00:00
Daniel Calviño Sánchez
42782ceeba Fix unit test for verifying enforced expire date too far in the future 
The test should fail if no exception was thrown, and no exception was
thrown due to a missing configuration parameter. However, the use of
"addToAssertionCount(1)" made the test pass even if no exception was
thrown and, therefore, to silently fail.

Now the missing configuration parameter was added and the test will fail
if the expected exception is not thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:19:53 +00:00
Daniel Calviño Sánchez
94648f1ecd Add unit tests to enforce a relaxed default share expiration date 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:19:51 +00:00
Daniel Calviño Sánchez
24f067bdaf Remove wrong and misleading comment 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:19:48 +00:00
Daniel Calviño Sánchez
9e84664f21 Remove extra spaces 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:19:45 +00:00
Daniel Calviño Sánchez
53e73dc46f Fix typo in variable name 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:19:42 +00:00
Daniel Calviño Sánchez
bd431e2e59 Fix typos in method names 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 13:19:39 +00:00
Morris Jobke
a1fff88b64
Apply code style fixes 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-11 16:43:41 +01:00
Julius Härtl
5aef556016
Only retry fetching app store data once every 5 minutes in case it fails 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-11-09 11:50:00 +01:00
Morris Jobke
c48076c645
Clear cached app config while waiting for the SCSSCache to finish processing the file 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-16 18:18:26 +02:00
Roeland Jago Douma
9375660254 Allow configuring the activity update interval of token 
On some systems with a lot of users this creates a lot of extra DB
writes.
Being able to increase this interval helps there.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-10-06 08:04:19 +00:00
Morris Jobke
f8955b7092 In case the group backend returns $limit or more results it is expected to contain more results 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-21 11:23:15 +00:00
Morris Jobke
d7aa1c00ed
Merge pull request #21983 from nextcloud/backport/21628/stable19 
[stable19] fix moving files from external storage to object store trashbin
 2020-08-19 21:29:01 +02:00
Elijah Martin-Merrill
66bb6fdbb0 fix memory leak caused by not destroying image in Preview/Generate.php 
Signed-off-by: Elijah Martin-Merrill <elijah@nyp-itsours.com>
 2020-08-05 20:41:25 +00:00
Robin Appelman
7ac4d57fd5 use exceptions for error signaling in writeStream 
this remove the ambiguity when writing zero length files

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 21:01:23 +00:00
Robin Appelman
b6a600e653 rollback cache rename if trashbin move fails 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 21:01:23 +00:00
Morris Jobke
72fc3ecbfc Remove deprecated test of internal attributes via assertAttributeEquals in constructor tests 
I removed the tests completely because they just test that the constructor assigns the values to the internal properties. Nothing that should be cared about from the outside.

See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322

It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-23 20:26:46 +00:00
Morris Jobke
c4bedf468e Use assertEqualsCanonicalizing instead of deprecated assertEquals parameter 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-23 20:26:45 +00:00
Morris Jobke
f11d72a928 Remove deprecated test of internal attributes via assertAttributeEquals 
See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322

It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-23 20:26:44 +00:00
Morris Jobke
1d290e15e8 Use assertStringContainsString instead of assertContains on strings 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-23 20:26:44 +00:00
Roeland Jago Douma
b3c9b166a3
Merge pull request #21779 from nextcloud/backport/21499/stable19 
[stable19] fix #21285 as oneliner
 2020-07-09 19:27:21 +02:00
Lionel Elie Mamane
ae036b4dfa adapt testGetLoginCredentialsInvalidTokenLoginCredentials() unit test to uid != loginname 
Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
 2020-07-09 14:37:05 +00:00
Robin Appelman
b95ba97d27 ensure mounts are scanned during tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-09 12:33:20 +00:00
Roeland Jago Douma
f174fb91e0 Use the correct mountpoint to calculate 
If we use the owners mount point this results in null. And then the rest
of the checks get called with null. Which doesn't work.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-09 12:33:19 +00:00
Roeland Jago Douma
905fab3356
Revert "[stable19] Do not read certificate bundle from data dir by default" 2020-07-03 14:21:38 +02:00
Joas Schilling
9d541ccfd1
Increase timeout of the appstore requests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-02 23:36:24 +02:00
Joas Schilling
a471dba6e1 Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validating 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-02 10:09:45 +00:00
Joas Schilling
9e9e74736d
Merge pull request #21538 from nextcloud/backport/21452/stable19 
[stable19] Fix autocomplete for LDAP with `shareapi_only_share_with_group_members` on
 2020-07-01 10:13:19 +02:00