Commit graph

7138 commits

Author SHA1 Message Date
Ferdinand Thiessen
fa9edf3c77
test: adjust broken tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-14 09:39:40 +02:00
skjnldsv
066e3977f5 fix(files_sharing): fix share creation error handling
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-09 17:38:10 +02:00
Benjamin Gaussorgues
92ea5fbd55
feat(ip): use larger IPv6 range by default
Some providers assign `/48` IPv6 blocks instead of `/64` so it sounds safer
to use this mask by default.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-04-08 11:33:47 +02:00
Christoph Wurst
91fda246b8
fix(session): Only mark sessions of permanent tokens as app passwords
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2025-04-03 10:17:43 +02:00
Richard Steinmetz
a34029b9dc
fix(oauth2): retain support for legacy ownCloud clients
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-04-02 10:28:21 +02:00
Dario Mehlich
b540da607e
fix(preview): Filter for folders in cleanup old preview job
Fixes #35936.
When running `OC\Preview\BackgroundCleanupJob`, the main iteration loop
in `run()` expects a folder, however, `getOldPreviewLocations()`
currently does not filter by mimetype and therefore can yield a
non-folder entry which causes an Exception when constructing the Folder
impl.
Filtering for `httpd/unix-directory`, as `getNewPreviewLocations()`
already does, fixes this issue.

Signed-off-by: Dario Mehlich <d.mehlich@gmail.com>
2025-04-01 11:05:14 +02:00
Julius Knorr
dc82454c41
Merge pull request #51710 from nextcloud/backport/51707/stable29
[stable29] fix: filter out contacts with empty email addresses in sharee completion
2025-03-28 16:22:12 +01:00
Julius Knorr
a9d2ac3472 fix: Do not build encrypted password if there is none
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-28 15:16:34 +01:00
Julius Knorr
fc7ac7b136
test: Adapt tests to properly use valid email addresses
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-28 14:55:10 +01:00
Hamza Mahjoubi
408c4bf680 fix(cardav): only show useres from enabled addressBooks in contacts menu
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-03-21 14:57:56 +01:00
Ferdinand Thiessen
888726111b
test: fix CI when running Karma tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 18:02:17 +01:00
Ferdinand Thiessen
b8c34bbbb3 fix(mime-types): adjust compiled mime types and sign
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-13 21:30:14 +01:00
Ferdinand Thiessen
92c48d0394
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:58:09 +01:00
Ferdinand Thiessen
e674631f9b
fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:56:45 +01:00
skjnldsv
48a643f8c1 fix: update babel and fix karma
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-06 16:32:44 +01:00
Stephan Orbaugh
d8040d7d7f
Merge pull request #51201 from nextcloud/backport/51194/stable29
[stable29] refactor(TempManager): Simplify and unify implementations and remove legacy behavior
2025-03-04 10:20:18 +01:00
skjnldsv
1672a357bd fix: make sure we process mime extensions as string
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-04 09:29:12 +01:00
provokateurin
7e8ffd332b
refactor(TempManager): Simplify and unify implementations and remove legacy behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-04 07:50:44 +01:00
Ferdinand Thiessen
8830bdbb1a refactor: convert sanitize account properties repair step to background job
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 12:59:09 +01:00
Ferdinand Thiessen
fb714dfd40 fix: Optimize repair step performance
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 12:59:09 +01:00
Ferdinand Thiessen
62d122adfa fix: validate account properties as a repair step
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 12:59:09 +01:00
Johannes Endres
a49366910b fix: Change UserAgent to *cloud
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
2025-02-21 09:28:41 +00:00
Josh
635dbdc785 fix(Mailer): Fix sendmail binary fallback
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-02-17 19:21:42 +01:00
Louis Chemineau
85417b56bf test(View): Copy preserves content
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-13 23:37:04 +00:00
Louis Chemineau
ef4281ebe3 fix(files): Correctly copy the cache information on copy operations
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-13 23:37:04 +00:00
Louis Chemineau
25ec8053eb
test:(PasswordConfirmationMiddleware): Fix constructor call
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-11 11:56:30 +01:00
Ferdinand Thiessen
c4cc3f2888
fix(FediverseAction): Ensure valid fediverse links are generated
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-09 13:46:27 +01:00
Ferdinand Thiessen
4a7c8834d0
fix(AccountManager): Sanitize social media handles
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-09 13:46:26 +01:00
Robin Appelman
5b4ceb0eaa fix: improve checks for moving shares/storages into other mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:39:28 +01:00
Ferdinand Thiessen
a0d7d107f5
fix(sharing): Move permission validation to share manager
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-31 18:46:07 +01:00
Louis Chemineau
9626ff81bd
fix: Exclude non accepted shares when computing access list
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-30 11:07:28 +01:00
Ferdinand Thiessen
3f8244a841 fix(files): Do not array access null value
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-29 10:28:01 +00:00
Ferdinand Thiessen
092f1b7f34
fix: Correctly return app id and app version for core styles and images
fix(TemplateLayout): `core` is not an app but the server itself

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-29 10:14:51 +01:00
Louis Chemineau
840ee6d59a
fix: Metadata field search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-27 13:03:49 +01:00
Josh
7516b094c0 test: fix periodic Test\Group\DatabaseTest::testSearchGroups failure
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-22 17:45:17 +00:00
Côme Chilliet
56a5350806
chore: Remove syntax incompatible with PHP 8.0
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 15:50:23 +01:00
Côme Chilliet
97800c555d fix: Use getRelativePath method to check if node is inside folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +00:00
Côme Chilliet
e1a23cf0a7 fix: Fix promotion of reshares from subsubfolders
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +00:00
Côme Chilliet
0ee5c781f7 fix(tests): Fix share tests to test new reshare promotion system
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +00:00
Côme Chilliet
786424ef09 fix: Tidy up code for reshare deletion
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +00:00
Luka Trovic
dfbaa103f9 fix: delete re-shares when deleting the parent share
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
(cherry picked from commit 42181c2f49)
2024-12-19 14:16:47 +00:00
Côme Chilliet
a5017fc0d3 fix(tests): Adapt ManagerTest to change in Exception class used
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 20:15:35 +00:00
Robin Appelman
f8ad3d6cc9 fix: fix mimetype not being updated when changing file extention on object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-11 09:00:37 +00:00
Christoph Wurst
e6738874a7
fix(migration): Decrypt ownCloud secrets v2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-11-28 09:44:56 +01:00
georglauterbach
487d19a0b3 fix: do not query CNAME if A succeeded already
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-11-14 10:46:13 +00:00
Richard Steinmetz
4b563e0c71
Merge pull request #49097 from nextcloud/backport/48933/stable29
[stable29] Clear pending two factor tokens also from configuration
2024-11-13 11:04:35 +01:00
yemkareems
051af1a8b9
fix: conflicts resolved in apps.php loadDirectory
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-11-13 08:34:39 +05:30
Josh Richards
ce3cec9681
fix: Clean-up some remaining readdir calls with undesirable false evaluation potential
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

[skip ci]
2024-11-13 08:34:23 +05:30
Daniel Calviño Sánchez
4d9cc7dd8d fix: Handle exception when clearing previously removed two factor tokens
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:49:31 +00:00
Daniel Calviño Sánchez
44ed719027 fix: Clear pending two factor tokens also from configuration
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:49:31 +00:00