upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-27 03:50:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 11
75854 commits 688 branches 1186 tags 7 GiB
Commit graph

409 commits

Author SHA1 Message Date
nfebe
d84be6b946 refactor: Remove some deprecated containers and exceptions 
Signed-off-by: nfebe <fenn25.fn@gmail.com>
 2025-02-11 10:51:13 -08:00
Ferdinand Thiessen
b94da13f6c
fix(sharing): Ensure download restrictions are not dropped 
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-04 18:20:38 +01:00
Ferdinand Thiessen
ea37f03f7d
fix(files_sharing): Respect permissions passed when creating link shares 
Given:
User creates a link or email share with permissions=4 (create only = file drop).

Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.

Solution:
Respect what the user is requesting, create a file drop share.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-31 18:46:07 +01:00
Côme Chilliet
8ce499246f fix(files_sharing): Fix error messages from password policy 
Exceptions thrown from password_policy may bubble up in share creation
 or update when a password is used. Their message is meant to be shown
 to the user. This always the case for HintException so we catch that
 instead of the subclass GenericShareException.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-12-12 20:15:35 +00:00
Benjamin Gaussorgues
e39137de2d chore: stricter access to testremote endpoint 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-11-28 10:48:18 +00:00
provokateurin
e4603a7e27
fix(files_sharing): Cleanup error messages 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-28 13:11:47 +01:00
skjnldsv
b9ef97260d fix(files_sharing): adjust permissions from custom edit and delete check methods 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-09-11 13:55:06 +02:00
Marcel Klehr
c80dd9dfec fix: Display 'Leave share' instead of 'Delete' 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-09-11 11:54:35 +00:00
Git'Fellow
cdf29e6e87 fix(share): Rename Circle to Team 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-08-06 21:27:19 +00:00
Maxence Lange
4370f9f4e9 fix(inherited-shares): ignore top root folder 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-08-06 12:13:51 +00:00
F. E Noel Nfebe
b94bcef5c8
Merge pull request #46228 from nextcloud/backport/45608/stable29 
[stable29] docs(ShareApiController): Correct note about expiry date timezone
 2024-07-02 11:02:41 +01:00
Louis Chemineau
1fb0cc25d2
fix(files_sharing): Store the expiration date relative to the server's timezone 
This is needed as we want to store the difference between the server's and the user's timezones.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-07-01 22:23:26 +02:00
fenn-cs
78f4fb67ac docs(ShareApiController): Correct note about expiry date timezone 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-07-01 17:24:48 +00:00
fenn-cs
5dbb96fc8a fix(shareManager): Respect empty expireDate in server 
If `expireDate` is an empty string and not `null` then the server should not set a default.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-05-29 12:58:37 +01:00
Joas Schilling
84b0818ed3 fix(sharing): Don't change the type of the controller argument 
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-04-18 12:36:48 +00:00
fenn-cs
9202a21516 fix(shareApiController): avoid duplicated expiryDate operations 
`expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-04-18 01:27:47 +00:00
fenn-cs
e1fc954cc9 refactor(shareApiController): use contrusctor property promotion & DI logger 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-04-18 01:27:46 +00:00
Côme Chilliet
0b332ceac2 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-04 11:45:22 +02:00
Ferdinand Thiessen
2be421785f
fix(files_sharing): ShareesAPI - Return empty response when user is not allowed to share 
Resolves: https://github.com/nextcloud/server/issues/20950

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-15 15:51:15 +01:00
Robin Appelman
e7a7b4a401 perf: switch places that always use the first getById result to getFirstNodeById 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-04 13:57:31 +01:00
Benjamin Gaussorgues
3f269782aa
Merge pull request #43428 from nextcloud/feat/share-expiration-with-time 2024-02-26 10:07:41 +01:00
Aragon Gouveia
311d1d2306 fix truncated circleId returned from Share API 2024-02-23 14:43:31 +01:00
Benjamin Gaussorgues
01983d50d4
feat(share): save date and time for expiration 
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-02-22 11:26:01 +01:00
F. E Noel Nfebe
3fb1674251
Merge pull request #43461 from nextcloud/fix/get-rid-of-getlogger 
chore: Migrate away from OC::$server->getLogger
 2024-02-14 10:47:22 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person 
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2024-02-13 21:06:30 +01:00
Côme Chilliet
c0ce272e9c chore: Migrate away from OC::$server->getLogger 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-02-13 17:32:30 +01:00
provokateurin
b64ab5fba8
refactor: Migrate IgnoreOpenAPI attributes to OpenAPI 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-01-18 16:14:17 +01:00
Benjamin Gaussorgues
cc3a2c351a
fix(share): use user timezone to parse share expiration date 
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but
D-1 for the server (UTC).
This fix aims to apply the correct offset

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-01-09 17:28:11 +01:00
John Molakvoæ
82b5a19a35
fix: public dav and files_sharing testing fixes 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2024-01-09 10:56:14 +01:00
John Molakvoæ
7b6a650b6e
feat: public dav endpoint v2 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2024-01-09 10:56:06 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
jld3103
755de1e0b5 refactor: Rename OpenAPI type aliases to their namespaces 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-11-02 11:37:15 +01:00
Joas Schilling
91ebbe8003
fix(federation): Use sharing.federation.allowSelfSignedCertificates config for all OCM requests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-10-11 11:52:10 +02:00
jld3103
c2d45cb172
Add single status code descriptions for OpenAPI 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-09-27 08:05:21 +02:00
Maxence Lange
8b9e7e235d ocm controller 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-09-20 08:23:45 -01:00
jld3103
c6806684d2
files_sharing: Add OpenAPI spec 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-07-31 16:58:49 +02:00
John Molakvoæ
8e1c693be5
fix(files_sharing): error and size/mtime for deleted shares 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-07-11 13:55:10 +02:00
John Molakvoæ
f5f142d31b
fix: adjust testing 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-07-11 13:52:28 +02:00
John Molakvoæ
6f54f72bb4
feat(sharing): add sharing overview view 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-07-11 13:52:27 +02:00
Benjamin Gaussorgues
29c1848eda
Migrate files sharing to PSR LoggerInterface 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-07-06 14:08:42 +02:00
Maxence Lange
d2efd0e03c displayname on federated shares 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-06-28 09:28:03 -01:00
Faraz Samapoor
12e3594299 Refactors "strpos" calls in /apps/files_sharing to improve code readability. 
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-06-02 20:08:40 +03:30
Louis Chemineau
6b53e4b13a Mutualize expireDate handling when creating and updating a share 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-04-27 16:26:24 +02:00
rakekniven
86b17e2248 Update apps/files_sharing/lib/Controller/ShareAPIController.php 
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2023-04-18 12:08:38 +02:00
rakekniven
eaaeb32074 fix(l10n): Fixed grammar 
Reported at Transifex.
  
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>


Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2023-04-18 12:08:38 +02:00
Michiel de Jong
c0e84cb512 Add SHARE_TYPE_SCIENCEMESH 
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
 2023-03-08 16:46:55 +01:00
Julius Härtl
38ca468502
Merge pull request #36515 from nextcloud/fix/sharees-remove-deck 2023-02-16 21:17:16 +01:00
Vincent Petry
1fed799826
Merge pull request #36452 from nextcloud/perf/share-availability-check 
perf(federation): Only request root share info for checking availability
 2023-02-03 13:34:35 +01:00
jld3103
30858df737
Remove Deck from Sharees API 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-02-03 12:01:37 +01:00
Louis Chemineau
4ab3c16403 Pluggable share provider 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-02-02 15:41:26 +01:00