Commit graph

1614 commits

Author SHA1 Message Date
Andy Scherzinger
50d5aede17
Merge pull request #50795 from nextcloud/backport/50781/stable29
[stable29] perf(files): faster query to fetch incomplete directories
2025-02-17 19:15:40 +01:00
Robin Appelman
e020cbbfe7 fix: make locked exception path relative to the view
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-15 16:51:00 +01:00
Benjamin Gaussorgues
ce4d271386
perf(files): faster query to fetch incomplete directories
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-02-14 11:00:07 +01:00
Louis Chemineau
ef4281ebe3 fix(files): Correctly copy the cache information on copy operations
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-13 23:37:04 +00:00
Robin Appelman
804a0ec567 fix: explicitly ignore nested mounts when transfering ownership
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:39:28 +01:00
Robin Appelman
7a37fdddc5 fix: translate mount move error messages
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:39:28 +01:00
Robin Appelman
5b4ceb0eaa fix: improve checks for moving shares/storages into other mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:39:28 +01:00
Richard Steinmetz
43d4864261 fix(s3): treat empty sse_c_key as not set
Co-authored-by: Christian Becker <christian@dabecka.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-29 17:33:42 +00:00
Ferdinand Thiessen
3f8244a841 fix(files): Do not array access null value
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-29 10:28:01 +00:00
Louis Chemineau
840ee6d59a
fix: Metadata field search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-27 13:03:49 +01:00
Kate
3fef4b1a4d
Merge pull request #49990 from nextcloud/backport/49887/stable29 2025-01-20 17:28:04 +01:00
Robin Appelman
8744d9e752
chore: psalm fixes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-20 15:31:23 +01:00
Git'Fellow
aeca17c2ac fix(TemplateManager): Remove warning message
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-01-20 13:40:34 +00:00
Robin Appelman
43c37426cb
fix: don't skip scanner users filesystem if they have a mountpoint at /<user>/files/
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-20 14:27:52 +01:00
Git'Fellow
cf2b197a1f
Merge pull request #49675 from nextcloud/backport/49262/stable29
[stable29] fix: don't do same-storage move optimization with encryption wrappers
2025-01-09 09:50:47 +01:00
Robin Appelman
bb3e6ea9d9 fix: don't do same-storage move optimization with encryption wrappers
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-09 09:32:16 +01:00
Git'Fellow
359dc62233
Merge pull request #49655 from nextcloud/backport/48769/stable29
[stable29] Fix incorrect permissions when copying shared files
2025-01-09 07:48:17 +01:00
provokateurin
9a728db531 fix(View): Catch exceptions when executing mkdir for non-existent parents
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-12-17 09:38:46 +00:00
Git'Fellow
c085c1bc45 fix(TemplateManager): Make sure TemplateFolder is a Folder
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-12-16 06:04:02 +00:00
John Molakvoæ
c3caf1c6d2
Merge pull request #49654 from nextcloud/backport/49551/stable29
[stable29] fix: don't propagate future mtimes
2024-12-12 13:22:31 +01:00
Robin Appelman
f8ad3d6cc9 fix: fix mimetype not being updated when changing file extention on object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-11 09:00:37 +00:00
Robin Appelman
cd8694493e fix: use scan_permissions when copying cache items
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-09 13:47:27 +01:00
Robin Appelman
fb71c41823 fix: store unmaked source permissions as scan_permissions when loading share cache items
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-09 13:47:27 +01:00
Robin Appelman
ef8f2155cb fix: don't propagate future mtimes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-04 19:12:30 +00:00
Robin Appelman
27c04eb682
fix: fix availability wrapper not applying
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-26 18:45:52 +01:00
Robin Appelman
d2230f8479
fix: throw correct exception type when we can't verify if an s3 bucket exists
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-26 18:45:46 +01:00
Git'Fellow
8ec775bc84 fix(storage): Try to delete existing target
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-11-21 07:41:54 +01:00
Josh Richards
ce3cec9681
fix: Clean-up some remaining readdir calls with undesirable false evaluation potential
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

[skip ci]
2024-11-13 08:34:23 +05:30
Victor Dubiniuk
e9699a5a55 Fix Undefined variable: response notice in case of non-404 error
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-08 16:12:15 +00:00
Louis
8b42f46c3d
Merge pull request #48998 from nextcloud/backport/47986/stable29
[stable29] perf(ObjectStoreStorage): Improve (slow) move on same object bucket
2024-10-31 15:55:32 +01:00
Benjamin Gaussorgues
31aa1fe4f5
Merge pull request #48488 from nextcloud/backport/48235/stable29 2024-10-30 09:59:56 +01:00
Christoph Fiehe
68b9972889 perf(ObjectStoreStorage): Improve (slow) move on same object bucket
This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
2024-10-30 08:28:52 +00:00
Daniel Calviño Sánchez
6f962c75d4 fix: Fix copying or moving from shared groupfolders
When copying or moving between two local storages the source path (on
disk) to copy or move from is got from the unjailed path of the source
storage. However, if the source storage has more than one jail getting
the unjailed path resolves the most external jail, but the source path
needs to be got from the most internal jail instead (the one closer to
the local storage).

This can happen, for example, with a shared groupfolder: in that case
there is an external jail for the shared storage, and one internal jail
for the groupfolder storage wrapped by the shared storage.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-10-29 10:41:24 +00:00
Julius Knorr
433f939d43 fix: Allow overriding shouldApplyQuota check from child classes
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-10-09 16:43:10 +00:00
Robin Appelman
73bff23dd7 fix: rework move into object store to better preserve fileids
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-09 14:50:02 +02:00
Robin Appelman
dd663a91d2 fix: preserve fileid when moving from objectstore to non-objectstore
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-09 14:50:02 +02:00
Robin Appelman
97862e7452 fix: ensure source folder is removed from cache when moving to objectstore
otherwise this causes confusion down the line as it's contents will be moved to the new cache

Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-09 14:50:02 +02:00
Daniel Kesselberg
1af2df8b4e
fix(s3): suppress php deprecation warning on php8
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-26 12:38:05 +02:00
Robin Appelman
79e7c48144 fix: ensure parent folder exists when writing a file to object storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:53 +02:00
Robin Appelman
671170a269 fix: verify that parent exists in cache when inserting
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:45 +02:00
Robin Appelman
48cd657d26 fix: fix object store id for test object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:41 +02:00
Robin Appelman
6683711516 fix: cleanup objectstore file_put_content
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:34 +02:00
Robin Appelman
f71dce6c9e fix: create intermediate directories for objectstore moveFromStorage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:30 +02:00
Robin Appelman
68e82ba0e5 fix: get source file before moving the cache item in objectstore moveFromStorage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:27 +02:00
John Molakvoæ
790ef0ea17 chore: improve hash_file php usage in Local Storage
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-16 15:18:02 +00:00
Louis Chemineau
41111e5f0a fix(files): Ensure that the hash method does not return null
To match beececf660/lib/private/Files/View.php (L1050)

- Fix https://github.com/nextcloud/server/issues/44110

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-16 15:18:02 +00:00
John Molakvoæ
408c870f61
Merge pull request #47862 from nextcloud/backport/47860/stable29 2024-09-16 11:01:28 +02:00
John Molakvoæ
038eff0b60
Merge pull request #47795 from nextcloud/backport/47756/stable29
[stable29] fix(files): Check if target path is a descendant of the shared folder
2024-09-15 22:17:41 +02:00
John Molakvoæ
21a37d79f1
Merge pull request #47873 from nextcloud/backport/47853/stable29
[stable29] fix: make swift connect exception message more informative
2024-09-15 22:14:49 +02:00
John Molakvoæ
d792bc5a07
Merge pull request #48034 from nextcloud/backport/48016/stable29
[stable29] fix(S3ConfigTrait): Allow proxy field to take false
2024-09-15 22:12:26 +02:00