Commit graph

7119 commits

Author SHA1 Message Date
Ferdinand Thiessen
fb714dfd40 fix: Optimize repair step performance
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 12:59:09 +01:00
Ferdinand Thiessen
62d122adfa fix: validate account properties as a repair step
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 12:59:09 +01:00
Johannes Endres
a49366910b fix: Change UserAgent to *cloud
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
2025-02-21 09:28:41 +00:00
Josh
635dbdc785 fix(Mailer): Fix sendmail binary fallback
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-02-17 19:21:42 +01:00
Louis Chemineau
85417b56bf test(View): Copy preserves content
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-13 23:37:04 +00:00
Louis Chemineau
ef4281ebe3 fix(files): Correctly copy the cache information on copy operations
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-13 23:37:04 +00:00
Louis Chemineau
25ec8053eb
test:(PasswordConfirmationMiddleware): Fix constructor call
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-11 11:56:30 +01:00
Ferdinand Thiessen
c4cc3f2888
fix(FediverseAction): Ensure valid fediverse links are generated
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-09 13:46:27 +01:00
Ferdinand Thiessen
4a7c8834d0
fix(AccountManager): Sanitize social media handles
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-09 13:46:26 +01:00
Robin Appelman
5b4ceb0eaa fix: improve checks for moving shares/storages into other mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:39:28 +01:00
Ferdinand Thiessen
a0d7d107f5
fix(sharing): Move permission validation to share manager
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-31 18:46:07 +01:00
Louis Chemineau
9626ff81bd
fix: Exclude non accepted shares when computing access list
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-30 11:07:28 +01:00
Ferdinand Thiessen
3f8244a841 fix(files): Do not array access null value
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-29 10:28:01 +00:00
Ferdinand Thiessen
092f1b7f34
fix: Correctly return app id and app version for core styles and images
fix(TemplateLayout): `core` is not an app but the server itself

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-29 10:14:51 +01:00
Louis Chemineau
840ee6d59a
fix: Metadata field search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-27 13:03:49 +01:00
Josh
7516b094c0 test: fix periodic Test\Group\DatabaseTest::testSearchGroups failure
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-22 17:45:17 +00:00
Côme Chilliet
56a5350806
chore: Remove syntax incompatible with PHP 8.0
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 15:50:23 +01:00
Côme Chilliet
97800c555d fix: Use getRelativePath method to check if node is inside folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +00:00
Côme Chilliet
e1a23cf0a7 fix: Fix promotion of reshares from subsubfolders
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +00:00
Côme Chilliet
0ee5c781f7 fix(tests): Fix share tests to test new reshare promotion system
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +00:00
Côme Chilliet
786424ef09 fix: Tidy up code for reshare deletion
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +00:00
Luka Trovic
dfbaa103f9 fix: delete re-shares when deleting the parent share
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
(cherry picked from commit 42181c2f49)
2024-12-19 14:16:47 +00:00
Côme Chilliet
a5017fc0d3 fix(tests): Adapt ManagerTest to change in Exception class used
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 20:15:35 +00:00
Robin Appelman
f8ad3d6cc9 fix: fix mimetype not being updated when changing file extention on object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-11 09:00:37 +00:00
Christoph Wurst
e6738874a7
fix(migration): Decrypt ownCloud secrets v2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-11-28 09:44:56 +01:00
georglauterbach
487d19a0b3 fix: do not query CNAME if A succeeded already
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-11-14 10:46:13 +00:00
Richard Steinmetz
4b563e0c71
Merge pull request #49097 from nextcloud/backport/48933/stable29
[stable29] Clear pending two factor tokens also from configuration
2024-11-13 11:04:35 +01:00
yemkareems
051af1a8b9
fix: conflicts resolved in apps.php loadDirectory
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-11-13 08:34:39 +05:30
Josh Richards
ce3cec9681
fix: Clean-up some remaining readdir calls with undesirable false evaluation potential
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

[skip ci]
2024-11-13 08:34:23 +05:30
Daniel Calviño Sánchez
4d9cc7dd8d fix: Handle exception when clearing previously removed two factor tokens
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:49:31 +00:00
Daniel Calviño Sánchez
44ed719027 fix: Clear pending two factor tokens also from configuration
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:49:31 +00:00
Louis
8b42f46c3d
Merge pull request #48998 from nextcloud/backport/47986/stable29
[stable29] perf(ObjectStoreStorage): Improve (slow) move on same object bucket
2024-10-31 15:55:32 +01:00
Côme Chilliet
74438f7f96
fix(tests): Fix most obvious errors in ObjectStore tests
Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-31 14:40:37 +01:00
Benjamin Gaussorgues
31aa1fe4f5
Merge pull request #48488 from nextcloud/backport/48235/stable29 2024-10-30 09:59:56 +01:00
Christoph Fiehe
68b9972889 perf(ObjectStoreStorage): Improve (slow) move on same object bucket
This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
2024-10-30 08:28:52 +00:00
Robin Appelman
a61d2ab4c4 test: add test for nested jail cross-storage move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-29 10:41:24 +00:00
yemkareems
de14601944
fix: crypto added manually as expected
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 18:47:05 +05:30
yemkareems
e4c22e02e0 fix: crypto type made not nullable and tests run using ICrypto
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 12:32:00 +00:00
yemkareems
7fa219e834 fix: encrypt and store password, decrypt and retrieve the same
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 12:32:00 +00:00
Joas Schilling
b2c8a10444
Merge pull request #48764 from nextcloud/backport/48539/stable29
[stable29] fix(message): Fix logic of Mail test
2024-10-17 21:15:20 +02:00
Ferdinand Thiessen
658aa1a2dd
Merge pull request #48588 from nextcloud/backport/47896/stable29
[stable29] fix: Make user removal more resilient
2024-10-17 18:21:57 +02:00
Joas Schilling
35933a62f7 fix(message): Fix logic of Mail test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-17 12:45:06 +00:00
Ferdinand Thiessen
00d3e37e6d
fix(share): Return empty string if no label is set
* Resolves: https://github.com/nextcloud/server/issues/48629

While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-15 16:56:59 +02:00
provokateurin
7dc1c7f762
fix(UserTrait): Fix backend initialization
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-15 16:50:28 +02:00
Ferdinand Thiessen
5d5c307a1a
fix: Make user removal more resilient
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-15 16:50:27 +02:00
Robin Appelman
90a6a75e11 test: re-add object store primary storage phpunit tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-09 14:50:02 +02:00
Richard Steinmetz
e2373b56fe
fix: gracefully parse non-standard trusted certificates
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-09-30 09:21:59 +02:00
Louis Chemineau
1e870c02f5
fix(users): Don't crash if disabled user is missing in the database
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-23 18:08:17 +02:00
Côme Chilliet
617c663c3b fix(tests): Fix Folder tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-19 17:51:51 +02:00
Robin Appelman
f38d70404d test: put parent items into cache in tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:45:28 +02:00