Commit graph

12200 commits

Author SHA1 Message Date
Robin Appelman
fbebc4bfe7 dont try email login if the provider username is not a valid email
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-16 13:27:10 +00:00
Vincent Petry
c63d861375
Merge pull request #33700 from nextcloud/groupfolder-system-encryption-24
[24] make groupfolders use system wide encryption keys
2022-09-15 22:58:05 +02:00
Robin Appelman
aafb4f8d5f
make groupfolders use system wide encryption keys
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-15 15:30:50 +02:00
Côme Chilliet
6b8b85a375 Do not empty config.php file if reading failed for any reason
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-12 07:48:03 +00:00
Carl Schwan
f072520cbd Filter out old files when trying to get recent files
Only do so when asking for less than 100 files and having an offset
equal to 0.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-08 14:43:57 +00:00
blizzz
c5bf31cd24
Revert "[stable24] Compare lowercase email when updating from ldap" 2022-09-07 12:26:16 +02:00
Louis Chemineau
7ea5b39e89 I dug into it again, and the issue is much simpler than I previously though.
- LDAP has an email address with capital letters
- NC store this address in lower case
- When the user logs in, we compare the [stored email with the new lower case email](https://github.com/nextcloud/server/blob/master/lib/private/AllConfig.php#L259-L261) before storing it. Here, both email will be the same, so we won't store the new email address with upper case letters. Which is what we want.
- We then [compare emails as they are before triggering an event](https://github.com/nextcloud/server/blob/master/lib/private/User/User.php#L202-L204), they won't match, so the user will receive an email signaling an email change every time he logs in.

The fix is to compare the old email with the new lower case email before sending the event.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-09-06 15:19:52 +00:00
Vincent Petry
e76bb271ec
Merge pull request #33749 from nextcloud/backport/33734/stable24
[stable24] remove leading slash for search results at mountpoint root
2022-09-01 09:27:59 +02:00
blizzz
a6be5e0dd7
Merge pull request #33696 from nextcloud/backport/33375/stable24
[stable24] Add back TokenCleanupJob to invalidate old temporary tokens
2022-08-30 17:48:30 +02:00
blizzz
7e980a1f1f
Merge pull request #33656 from nextcloud/backport/33574/stable24
[stable24] directly build the search filter for shared storage instead of setting up the source cache
2022-08-30 17:48:11 +02:00
blizzz
2d25bdac2a
Merge pull request #33603 from nextcloud/jail-search-post-24
[24] optimize search post-processing for jail wrapper
2022-08-30 17:47:49 +02:00
blizzz
4503adc70d
Merge pull request #33514 from nextcloud/backport/33513/stable24
[stable24] Recover installation when creating the database user fails and improve password strength
2022-08-30 17:45:29 +02:00
Robin Appelman
ee8cabe2ce remove leading slash for search results at mountpoint root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-30 10:24:30 +00:00
Thomas Citharel
6e9fb83977 Add back TokenCleanupJob to invalidate old temporary tokens
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-08-25 12:05:18 +00:00
Arthur Schiwon
650900252c
logger ignore args of sharepoint-related methods
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-08-25 11:48:03 +02:00
Robin Appelman
9cadbe811e directly build the search filter for shared storage instead of setting up the source cache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-23 12:19:14 +00:00
Robin Appelman
9deae5b17a optimize search post-processing for jail wrapper
don't both asking the wrapped cache if we know it's not in our jail anyway

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-18 13:39:36 +02:00
Robin Appelman
ea9509eaf9 fix updating size when folder is empty
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-16 13:40:45 +02:00
Joas Schilling
be5c39321b
Create more secure passwords by default
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-12 11:22:48 +02:00
Joas Schilling
d09533cf28
Recover installation when creating the user failed
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-12 11:21:27 +02:00
Julius Härtl
874146285f Do not update passwords if nothing changed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-09 18:54:33 +00:00
blizzz
d81e38d296
Merge pull request #32273 from nextcloud/backport/32152/stable24
[stable24] Allow compatibility wrapper on local external storage
2022-08-04 11:42:56 +02:00
Carl Schwan
aafaa39515
Multiple fixes
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-03 13:24:38 +02:00
Vincent Petry
e959b57c31
Inherit hide download from share attributes
When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:20 +02:00
Vincent Petry
cc7564758b
Fix view-only code after code review comments
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:20 +02:00
Vincent Petry
9e59a6a731
Attempt to fix sqlite json issue
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:19 +02:00
Vincent Petry
cf3d92015b
Fix share attribute related tests + code style
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:19 +02:00
Vincent Petry
f1ab964819
Add share attributes + prevent download permission
Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:13 +02:00
blizzz
6088f720bd
Merge pull request #33439 from nextcloud/backport/32958/stable24
[stable24] Fix file public link permissions if public upload is not enabled
2022-08-03 11:27:10 +02:00
Vincent Petry
3a3a52de83
Merge pull request #33407 from nextcloud/backport/stable24/one-time-password
[stable24] Handle one time and large passwords
2022-08-03 09:07:54 +02:00
Julien Veyssier
933bd27ea9 don't reduce file public link permissions if public upload is not enabled
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-08-02 14:56:59 +00:00
blizzz
039fd75a88
Merge pull request #33353 from nextcloud/backport/33031/stable24
[stable24] Improve local IP detection
2022-08-02 12:36:10 +02:00
Côme Chilliet
5daf307a0d
Remove call to undefined function, fix typing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-01 12:24:39 +02:00
Côme Chilliet
ead97ba46d
Align copied file with our code style
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-01 11:34:28 +02:00
Côme Chilliet
d3a2fd02c2
Copy IpUtils from Symfony to avoid new dependency on backport
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-01 11:30:51 +02:00
Carl Schwan
f4795f6dac
Handle one time and large passwords
For passwords bigger than 250 characters, use a bigger key since the
performance impact is minor (around one second to encrypt the password).

For passwords bigger than 470 characters, give up earlier and throw
exeception recommanding admin to either enable the previously enabled
configuration or use smaller passwords.

This adds an option to disable storing passwords in the database. This
might be desirable when using single use token as passwords or very
large passwords.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-29 16:15:38 +02:00
Robin Appelman
afdeae2cc2 don't set null as a bundle path
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-07-27 13:46:34 +00:00
Côme Chilliet
d0ceedf054 Use Symfony IpUtils to check for local IP ranges
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:42:33 +00:00
Côme Chilliet
8cddb75c2b Check for local IPs nested in IPv6 as well
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:42:32 +00:00
Côme Chilliet
1d0ddcfca1 Refactor local IP if and set strict to true for in_array
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:42:32 +00:00
Côme Chilliet
7ab50248dc Improve local IP detection
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:42:32 +00:00
Vincent Petry
a2166864d4
Merge pull request #33326 from nextcloud/backport/33308/stable24
[stable24] always triger setup of builtin storage wrappers
2022-07-25 17:04:19 +02:00
blizzz
22822a836d
Merge pull request #33252 from nextcloud/backport/32963/stable24
[stable24] also use nextcloud certificate bundle when downloading from s3
2022-07-22 23:54:41 +02:00
Robin Appelman
2c6cd0daf8 always triger setup of builtin storage wrappers
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-07-22 20:24:35 +00:00
Jonas
78a3bfd120
Merge pull request #33212 from nextcloud/backport/33211/stable24
[stable24] Fix listening for circle events in SetupManager
2022-07-19 10:25:45 +02:00
Arthur Schiwon
7af9f2741f fix loading legacy app.php with multi app dir
- requireAppFile() only appends /appinfo/app.php
- without the absolute path, require_once looks into include_path
- the first match in inlcude_path however migth be different from appPath
- fixed by providing the tested(!), full path to the app


Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-19 06:18:59 +00:00
Jonas
786317e1cb
Fix listening for circle events in SetupManager
So far, SetupManager listened for deprecated events that are no longer
triggered. Instead, use the circle events that actually get triggered
when adding or removing a circle or circle member. Also, these events
get triggered on each instance of a globalscale setup.

Fixes: #33210

Signed-off-by: Jonas <jonas@freesources.org>
2022-07-18 21:09:37 +01:00
Robin Appelman
d4de68f1d4 only use nextcloud bundle when explicitly enabled
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-07-18 07:54:55 +00:00
Robin Appelman
e640ee4720 also use nextcloud certificate bundle when downloading from s3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-07-18 07:54:54 +00:00
John Molakvoæ
dec16a9543
Merge pull request #33157 from nextcloud/backport/33153/stable24 2022-07-08 08:28:29 +02:00