upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-22 06:37:56 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 54
69442 commits 876 branches 1195 tags 8.3 GiB
Commit graph

1386 commits

Author SHA1 Message Date
Robin Appelman
64f62f7cfd
Merge pull request #39863 from nextcloud/sharing-mask-wrapper 
move share permission logic to storage wrapper
 2023-09-04 14:05:14 +02:00
Simon L
489a57e9a3
Merge pull request #39707 from nextcloud/bugfix/39706/local-ext-storage-unavailable-mode 2023-09-04 12:05:36 +02:00
John Molakvoæ
750a9f2c4a
fix: prevent sharing permissions on user root folder 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-09-01 13:53:41 +02:00
Robin Appelman
4711c775b8
Merge pull request #36068 from nextcloud/gf-encryption-fix 
extend fix-key-location to handle cases from broken cross-storage moves
 2023-09-01 13:01:04 +02:00
Thomas Citharel
3f28fc58aa fix(s3): fix handling verify_bucket_exists parameter 
If 'verify_bucket_exists' is set to false in the config.php s3 configuration, it's supposed to avoid
verifying that the bucket exists. However empty(falsy) will  always return true, so this condition
would not work.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-08-31 21:36:03 +02:00
Robin Appelman
e4f85226c5
extend fix-key-location to handle cases from broken cross-storage moves 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-31 19:46:47 +02:00
Vincent Petry
8d1a3daa3f Allow ext storage Local to go unavailable 
Whenever an external storage of type Local points at a non-existing
directory, process this as a StorageNotAvailable instead of returning
404.

This makes desktop clients ignore the folder instead of deleting it when
it becomes unavailable.

The code change was limited to external storages to avoid issues during
setup and with the default home storage.
Signed-off-by: Vincent Petry <pvince81@yahoo.fr>
 2023-08-29 11:04:31 +02:00
John Molakvoæ
b11532ce56
Merge pull request #39958 from nextcloud/dav-permissions-perf 2023-08-22 19:14:53 +02:00
Robin Appelman
b6c3507aa0 only determine quota_include_external_storage once for quota wrapper 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-18 14:25:28 +02:00
Robin Appelman
e98e8f10c9 improve performance of calculating dav permissions 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-18 14:09:03 +02:00
Robin Appelman
9ea03a9534 reuse dependencies from wrapped cache 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-18 11:14:52 +02:00
Julius Härtl
45595a8417
Merge pull request #39481 from nextcloud/fix/transfer-ownersip 2023-08-17 13:23:04 +02:00
Anna Larch
556f29bef5 fix: don't emit Hooks when hookpaths are empty 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-08-17 09:32:14 +02:00
Robin Appelman
e73889a240 cleanup di for share permissions wrapper 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-16 15:25:05 +02:00
Ferdinand Thiessen
9c04c07622 fix: Prevent PHP warnings when optional CacheEntry attributes are unset 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-08-16 14:12:51 +02:00
Robin Appelman
a031bc4788 more share permission logic to storage wrapper 
this way we only have to determine the share permissions once

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-14 18:17:27 +02:00
Robin Appelman
658aed27ea select the fileid first when looking for incomplete files 
this seems to improve mariadbs index selection

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-14 18:08:01 +02:00
Daniel
2ea6c5364d
Merge pull request #39644 from nextcloud/fix/noid/copy-delete-fallback-for-files 
fix: copy-and-delete fallback should use unlink
 2023-08-14 12:29:40 +02:00
John Molakvoæ
b27a2e9ec5
Merge pull request #39698 from joshtrichards/invalid-source-storage-path-catch 2023-08-05 12:17:33 +02:00
John Molakvoæ
7b7d1e3c09
fix: simplify sourceData check 
Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2023-08-05 12:05:36 +02:00
Joas Schilling
44b4c16a09
Merge pull request #39605 from nextcloud/bugfix/noid/final-events-cleanup 
fix!: Final round of moving to IEventDispatcher
 2023-08-04 10:39:57 +02:00
Josh Richards
deecb48e54
Catch more invalid cache source storage paths 
OC\Files\Cache\Cache::get can return string|false|null, not just string|false.

- nextcloud/server#26270 added handling of false, but null is needed too.
- Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason

Related: nextcloud/server#19009

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2023-08-03 09:53:46 -04:00
Daniel Kesselberg
f1d4f7c7e4
fix: copy-and-delete fallback should use unlink 
because rmdir does not work for files.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-07-31 21:41:25 +02:00
Daniel Kesselberg
b4ff557b8c fix(storage): fallback to copy and unlink when rename fails 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-07-31 18:54:21 +02:00
Tobias Zimmerer
23f85b5ac2 fix(s3): add SSE-C parameters to headObject call 
Signed-off-by: Tobias Zimmerer <3228193+ir0nhide@users.noreply.github.com>
 2023-07-30 22:54:58 +02:00
Robin Appelman
fda820a64d
expose MovableMount in public interface 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-07-28 14:42:09 +02:00
Joas Schilling
3962cd0aa8
fix!: Move getEventDispatcher usage to IEventDispatcher 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-28 14:11:22 +02:00
Joas Schilling
44a0a62107
fix: Move Node HookConnecter events to IEventDispatcher 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-27 09:57:53 +02:00
Robin Appelman
31f1ff87d0
Merge pull request #39367 from nextcloud/s3-fopen-exception 
handle more exceptions in AmazonS3::fopen
 2023-07-20 19:32:03 +02:00
Robin Appelman
c912a3f0f6
Merge pull request #38860 from nextcloud/scanner-change-summary 
add summary of detected changes to files:scan output
 2023-07-20 18:37:07 +02:00
Julius Härtl
77f249726d
Merge pull request #38934 from nextcloud/bugfix/noid/ssec-multipart 2023-07-20 11:00:08 +02:00
Robin Appelman
b0e663fa28
fix SeekableHttpStream::stream_stat errors on failed open 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-07-13 15:38:58 +02:00
Arthur Schiwon
f2642fcceb
fix(node): non-existing folder is not searchable 
the previosuly introduced searchBySystemTag was not overwritten in
NonExistingFolder and could run the inherited method.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-13 00:01:32 +02:00
Christoph Wurst
14719110b9 chore: Replace \OC::$server->query with \OCP\Server::get in /lib 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-07-06 15:21:22 +02:00
Richard Steinmetz
c4eccbb304
fix(sse): don't update uncached files 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2023-07-04 12:42:29 +02:00
Julius Härtl
eddb64f8c3
Merge pull request #37969 from nextcloud/poc/noid/systemtags-perf-tag-endpoint 2023-06-28 07:53:35 +02:00
Robin Appelman
39a0554c09
Merge pull request #38858 from nextcloud/scanner-performance3 
file scanner performance improvements
 2023-06-26 17:01:18 +02:00
Arthur Schiwon
17515995fa
Merge pull request #38625 from nextcloud/fix/noid/querysearchehelper-narrow-type 
fix: expect interface, not a specific implementation
 2023-06-24 00:13:43 +02:00
Robin Appelman
493e151be0
dav: clean path before putting it in the statcache 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-06-23 14:39:17 +02:00
Robin Appelman
279822c217
implement optimized getDirectoryContent for DAV 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-06-22 16:34:32 +02:00
Arthur Schiwon
a0f9556f7c
fix: cominbation of small fixes 
- possible null return
- parameter name mismatch in implementation
- incomplete unit test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 20:28:01 +02:00
Arthur Schiwon
49db546f78
fix: include invisible tags for admins 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 20:28:01 +02:00
Julius Härtl
ea575e342f
fix(s3): Pass SSE-C parameters for multipart upload 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-06-21 18:32:24 +02:00
Arthur Schiwon
221562d45d
feat: add searchBySystemTag as PHP API 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 18:19:09 +02:00
Arthur Schiwon
783e32a64d
fix: favorites view and universal search against tags 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 18:19:08 +02:00
Arthur Schiwon
b0d1cf5730
fix: change if with conditionless else to switch; and a parameter value 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 18:19:08 +02:00
Arthur Schiwon
58f7fd2370
use efficient tag retrieval on DAV report request 
- uses DAV search approach against valid files joined by systemtag selector
- reduced table join for tag/systemtag search
- supports pagination
- no changes to the output formats or similar

Example request body:

<?xml version="1.0"?>
<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns">
  <d:prop>
    <d:getcontentlength/>
    <d:getcontenttype/>
    <d:getetag/>
    <d:getlastmodified/>
    <d:resourcetype/>
    <nc:face-detections/>
    <nc:file-metadata-size/>
    <nc:has-preview/>
    <nc:realpath/>
    <oc:favorite/>
    <oc:fileid/>
    <oc:permissions/>
    <nc:nbItems/>
  </d:prop>
  <oc:filter-rules>
    <oc:systemtag>32</oc:systemtag>
  </oc:filter-rules>
  <d:limit>
    <d:nresults>50</d:nresults>
    <nc:firstresult>0</nc:firstresult>
  </d:limit>
</oc:filter-files>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 18:19:08 +02:00
Arthur Schiwon
088a0eea29
ci: pro forma check of existence of internal method 
createNode() is protected and used by Folder, but being an internal-only
method it shall not be exposed in the Folder or IRootFolder interface.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 16:53:20 +02:00
Arthur Schiwon
71e41ffeeb
refactor: declare getMount() and getMountsIn() at IRootFolder 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 16:53:20 +02:00
Arthur Schiwon
f6ac874dbf
chore: ugly type juggling 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 16:53:20 +02:00