nextcloud/apps/files/js
Daniel Calviño Sánchez 036bfa08dd Fix dropping a folder on a folder row
When the uploaded files have a relative path (that is, when a folder is
uploaded) it is first ensured that all the parent folders exist, which
is done by trying to create them. When a folder is created in the
currently opened folder the file list is updated and a row for the new
folder is added. However, this was done too when the folder already
existed, which caused the previous row to be removed and a new one added
to replace it.

For security reasons, some special headers need to be set in requests;
this is done automatically for jQuery by handling the "ajaxSend" event
in the document. In the case of DAV requests, if the headers are not set
the server rejects the request with "CSRF check not passed".

When a file or folder is dropped on a folder row the jQuery upload
events are chained from the initial drop event, which has the row as its
target. In order to upload the file jQuery performs a request, which
triggers the "ajaxSend" event in the row; this event then bubbles up to
the document, which is then handled by adding the special headers to the
request.

However, when a folder was dropped on a folder row that folder row was
removed when ensuring that the folder exists. The jQuery upload events
were still triggered on the row, but as it had been removed it had no
parent nodes, and thus the events did not bubble up. Due to this the
"ajaxSend" event never reached the document when triggered on the
removed row, the headers were not set, and the upload failed.

All this is simply fixed by not removing the folder row when trying to
create it if it existed already.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-29 14:49:26 +00:00
..
templates Upload autorename on client side 2016-11-02 22:15:03 +01:00
admin.js Do not error on maxUploadChange 2016-08-22 20:25:58 +02:00
app.js Enable chunking for bigger files in authenticated web upload 2017-11-03 17:19:23 +01:00
breadcrumb.js Improve documentation of "getTotalWidth" 2018-03-01 20:33:14 +01:00
detailfileinfoview.js Make file actions work from sidebar 2015-08-12 17:30:20 +02:00
detailsview.js Remove unused variables 2017-11-06 09:43:45 +01:00
detailtabview.js Hide sidebar tab headers conditionally 2015-09-28 14:57:44 +02:00
favoritesfilelist.js Remove event handler no longer needed 2018-10-23 17:03:37 +02:00
favoritesplugin.js Fix opening a section again in the Files app 2018-10-23 17:02:54 +02:00
file-upload.js Fix dropping a folder on a folder row 2019-01-29 14:49:26 +00:00
fileactions.js Fixed files copy/move when in favorites or recent section 2018-04-18 17:54:04 +02:00
fileactionsmenu.js Add support to FileActionsMenu for icon class functions 2017-10-19 01:46:13 +02:00
fileinfomodel.js added quit option in commentstabview.js 2017-03-23 13:12:29 -06:00
filelist.js Fix opening a section again in the Files app 2018-10-23 17:02:54 +02:00
files.js Fixup! removed unwanted line 2018-01-03 17:55:53 +01:00
filesummary.js Translate file summary connector (#26221) 2016-09-27 18:38:56 +02:00
gotoplugin.js Fix closing details view when viewing file in folder 2017-04-25 17:45:42 +02:00
jquery-visibility.js update jquery-visibility in files app 2015-08-17 09:39:21 +02:00
jquery.fileupload.js Add callback to clean up after misbehaved drag and drop events 2018-06-12 15:25:50 +02:00
keyboardshortcuts.js Fixed many issues, clean up 2014-05-15 17:51:04 +02:00
mainfileinfodetailview.js Hide favourite icon in details view if favourite action is not available 2018-01-05 19:06:06 +01:00
merged-index.json Merge file view JS files 2017-03-24 19:42:22 +01:00
navigation.js Only set the active item when there is one (not the case for quota) 2017-06-13 11:17:44 +02:00
newfilemenu.js Make new file file tooltip error text change 2017-05-21 08:23:17 +05:45
recentfilelist.js block user sorting in recent files 2016-07-22 15:20:55 +02:00
recentplugin.js Fix opening a section again in the Files app 2018-10-23 17:02:54 +02:00
search.js Use proper mime icons for search results 2017-05-16 14:30:49 +02:00
sidebarpreviewmanager.js allow registering sidebar preview handlers for mimetypes that dont come with server side previews 2016-12-01 15:43:17 +01:00
sidebarpreviewtext.js Do not fetch the whole text file for the sidebar preview 2017-08-03 20:32:59 +02:00
tagsplugin.js Remove requeriment for read permission on some actions 2017-11-02 19:37:01 +01:00
upload.js Improved Javascript docs for JSDoc 2014-10-31 13:43:30 +01:00