mirror of
https://github.com/nextcloud/server.git
synced 2026-04-26 00:27:49 -04:00
92bc33dd1e
comments should compile mentions also if done by author it is used by clients for formatting reasons, there is no reason not format the author if her handle is included in the comment body. It is unrelated to sending out notifications. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> do not offer the handle of the current user for auto completion Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> add types to php doc Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
492 lines
11 KiB
PHP
492 lines
11 KiB
PHP
<?php
|
|
/**
|
|
* @copyright Copyright (c) 2017 Arthur Schiwon <blizzz@arthur-schiwon.de>
|
|
*
|
|
* @author Arthur Schiwon <blizzz@arthur-schiwon.de>
|
|
*
|
|
* @license GNU AGPL version 3 or any later version
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as
|
|
* published by the Free Software Foundation, either version 3 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
namespace Test\Collaboration\Collaborators;
|
|
|
|
use OC\Collaboration\Collaborators\SearchResult;
|
|
use OC\Collaboration\Collaborators\UserPlugin;
|
|
use OCP\Collaboration\Collaborators\ISearchResult;
|
|
use OCP\IConfig;
|
|
use OCP\IGroupManager;
|
|
use OCP\IUser;
|
|
use OCP\IUserManager;
|
|
use OCP\IUserSession;
|
|
use OCP\Share;
|
|
use Test\TestCase;
|
|
|
|
class UserPluginTest extends TestCase {
|
|
/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject */
|
|
protected $config;
|
|
|
|
/** @var IUserManager|\PHPUnit_Framework_MockObject_MockObject */
|
|
protected $userManager;
|
|
|
|
/** @var IGroupManager|\PHPUnit_Framework_MockObject_MockObject */
|
|
protected $groupManager;
|
|
|
|
/** @var IUserSession|\PHPUnit_Framework_MockObject_MockObject */
|
|
protected $session;
|
|
|
|
/** @var UserPlugin */
|
|
protected $plugin;
|
|
|
|
/** @var ISearchResult */
|
|
protected $searchResult;
|
|
|
|
/** @var int */
|
|
protected $limit = 2;
|
|
|
|
/** @var int */
|
|
protected $offset = 0;
|
|
|
|
/** @var IUser|\PHPUnit_Framework_MockObject_MockObject */
|
|
protected $user;
|
|
|
|
public function setUp() {
|
|
parent::setUp();
|
|
|
|
$this->config = $this->createMock(IConfig::class);
|
|
|
|
$this->userManager = $this->createMock(IUserManager::class);
|
|
|
|
$this->groupManager = $this->createMock(IGroupManager::class);
|
|
|
|
$this->session = $this->createMock(IUserSession::class);
|
|
|
|
$this->searchResult = new SearchResult();
|
|
|
|
$this->user = $this->getUserMock('admin', 'Administrator');
|
|
}
|
|
|
|
public function instantiatePlugin() {
|
|
// cannot be done within setUp, because dependent mocks needs to be set
|
|
// up with configuration etc. first
|
|
$this->plugin = new UserPlugin(
|
|
$this->config,
|
|
$this->userManager,
|
|
$this->groupManager,
|
|
$this->session
|
|
);
|
|
}
|
|
|
|
public function getUserMock($uid, $displayName) {
|
|
$user = $this->createMock(IUser::class);
|
|
|
|
$user->expects($this->any())
|
|
->method('getUID')
|
|
->willReturn($uid);
|
|
|
|
$user->expects($this->any())
|
|
->method('getDisplayName')
|
|
->willReturn($displayName);
|
|
|
|
return $user;
|
|
}
|
|
|
|
public function dataGetUsers() {
|
|
return [
|
|
['test', false, true, [], [], [], [], true, false],
|
|
['test', false, false, [], [], [], [], true, false],
|
|
['test', true, true, [], [], [], [], true, false],
|
|
['test', true, false, [], [], [], [], true, false],
|
|
[
|
|
'test', false, true, [], [],
|
|
[
|
|
['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
|
|
], [], true, $this->getUserMock('test', 'Test')
|
|
],
|
|
[
|
|
'test', false, false, [], [],
|
|
[
|
|
['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
|
|
], [], true, $this->getUserMock('test', 'Test')
|
|
],
|
|
[
|
|
'test', true, true, [], [],
|
|
[], [], true, $this->getUserMock('test', 'Test')
|
|
],
|
|
[
|
|
'test', true, false, [], [],
|
|
[], [], true, $this->getUserMock('test', 'Test')
|
|
],
|
|
[
|
|
'test', true, true, ['test-group'], [['test-group', 'test', 2, 0, []]],
|
|
[
|
|
['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
|
|
], [], true, $this->getUserMock('test', 'Test')
|
|
],
|
|
[
|
|
'test', true, false, ['test-group'], [['test-group', 'test', 2, 0, []]],
|
|
[
|
|
['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
|
|
], [], true, $this->getUserMock('test', 'Test')
|
|
],
|
|
[
|
|
'test',
|
|
false,
|
|
true,
|
|
[],
|
|
[
|
|
$this->getUserMock('test1', 'Test One'),
|
|
],
|
|
[],
|
|
[
|
|
['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
|
|
],
|
|
true,
|
|
false,
|
|
],
|
|
[
|
|
'test',
|
|
false,
|
|
false,
|
|
[],
|
|
[
|
|
$this->getUserMock('test1', 'Test One'),
|
|
],
|
|
[],
|
|
[],
|
|
true,
|
|
false,
|
|
],
|
|
[
|
|
'test',
|
|
false,
|
|
true,
|
|
[],
|
|
[
|
|
$this->getUserMock('test1', 'Test One'),
|
|
$this->getUserMock('test2', 'Test Two'),
|
|
],
|
|
[],
|
|
[
|
|
['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
|
|
['label' => 'Test Two', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test2']],
|
|
],
|
|
false,
|
|
false,
|
|
],
|
|
[
|
|
'test',
|
|
false,
|
|
false,
|
|
[],
|
|
[
|
|
$this->getUserMock('test1', 'Test One'),
|
|
$this->getUserMock('test2', 'Test Two'),
|
|
],
|
|
[],
|
|
[],
|
|
true,
|
|
false,
|
|
],
|
|
[
|
|
'test',
|
|
false,
|
|
true,
|
|
[],
|
|
[
|
|
$this->getUserMock('test0', 'Test'),
|
|
$this->getUserMock('test1', 'Test One'),
|
|
$this->getUserMock('test2', 'Test Two'),
|
|
],
|
|
[
|
|
['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test0']],
|
|
],
|
|
[
|
|
['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
|
|
['label' => 'Test Two', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test2']],
|
|
],
|
|
false,
|
|
false,
|
|
],
|
|
[
|
|
'test',
|
|
false,
|
|
false,
|
|
[],
|
|
[
|
|
$this->getUserMock('test0', 'Test'),
|
|
$this->getUserMock('test1', 'Test One'),
|
|
$this->getUserMock('test2', 'Test Two'),
|
|
],
|
|
[
|
|
['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test0']],
|
|
],
|
|
[],
|
|
true,
|
|
false,
|
|
],
|
|
[
|
|
'test',
|
|
true,
|
|
true,
|
|
['abc', 'xyz'],
|
|
[
|
|
['abc', 'test', 2, 0, ['test1' => 'Test One']],
|
|
['xyz', 'test', 2, 0, []],
|
|
],
|
|
[],
|
|
[
|
|
['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
|
|
],
|
|
true,
|
|
false,
|
|
],
|
|
[
|
|
'test',
|
|
true,
|
|
false,
|
|
['abc', 'xyz'],
|
|
[
|
|
['abc', 'test', 2, 0, ['test1' => 'Test One']],
|
|
['xyz', 'test', 2, 0, []],
|
|
],
|
|
[],
|
|
[],
|
|
true,
|
|
false,
|
|
],
|
|
[
|
|
'test',
|
|
true,
|
|
true,
|
|
['abc', 'xyz'],
|
|
[
|
|
['abc', 'test', 2, 0, [
|
|
'test1' => 'Test One',
|
|
'test2' => 'Test Two',
|
|
]],
|
|
['xyz', 'test', 2, 0, [
|
|
'test1' => 'Test One',
|
|
'test2' => 'Test Two',
|
|
]],
|
|
],
|
|
[],
|
|
[
|
|
['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
|
|
['label' => 'Test Two', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test2']],
|
|
],
|
|
false,
|
|
false,
|
|
],
|
|
[
|
|
'test',
|
|
true,
|
|
false,
|
|
['abc', 'xyz'],
|
|
[
|
|
['abc', 'test', 2, 0, [
|
|
'test1' => 'Test One',
|
|
'test2' => 'Test Two',
|
|
]],
|
|
['xyz', 'test', 2, 0, [
|
|
'test1' => 'Test One',
|
|
'test2' => 'Test Two',
|
|
]],
|
|
],
|
|
[],
|
|
[],
|
|
true,
|
|
false,
|
|
],
|
|
[
|
|
'test',
|
|
true,
|
|
true,
|
|
['abc', 'xyz'],
|
|
[
|
|
['abc', 'test', 2, 0, [
|
|
'test' => 'Test One',
|
|
]],
|
|
['xyz', 'test', 2, 0, [
|
|
'test2' => 'Test Two',
|
|
]],
|
|
],
|
|
[
|
|
['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
|
|
],
|
|
[
|
|
['label' => 'Test Two', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test2']],
|
|
],
|
|
false,
|
|
false,
|
|
],
|
|
[
|
|
'test',
|
|
true,
|
|
false,
|
|
['abc', 'xyz'],
|
|
[
|
|
['abc', 'test', 2, 0, [
|
|
'test' => 'Test One',
|
|
]],
|
|
['xyz', 'test', 2, 0, [
|
|
'test2' => 'Test Two',
|
|
]],
|
|
],
|
|
[
|
|
['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
|
|
],
|
|
[],
|
|
true,
|
|
false,
|
|
],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataGetUsers
|
|
*
|
|
* @param string $searchTerm
|
|
* @param bool $shareWithGroupOnly
|
|
* @param bool $shareeEnumeration
|
|
* @param array $groupResponse
|
|
* @param array $userResponse
|
|
* @param array $exactExpected
|
|
* @param array $expected
|
|
* @param bool $reachedEnd
|
|
* @param bool|IUser $singleUser
|
|
*/
|
|
public function testSearch(
|
|
$searchTerm,
|
|
$shareWithGroupOnly,
|
|
$shareeEnumeration,
|
|
array $groupResponse,
|
|
array $userResponse,
|
|
array $exactExpected,
|
|
array $expected,
|
|
$reachedEnd,
|
|
$singleUser
|
|
) {
|
|
$this->config->expects($this->any())
|
|
->method('getAppValue')
|
|
->willReturnCallback(
|
|
function($appName, $key, $default)
|
|
use ($shareWithGroupOnly, $shareeEnumeration)
|
|
{
|
|
if ($appName === 'core' && $key === 'shareapi_only_share_with_group_members') {
|
|
return $shareWithGroupOnly ? 'yes' : 'no';
|
|
} else if ($appName === 'core' && $key === 'shareapi_allow_share_dialog_user_enumeration') {
|
|
return $shareeEnumeration ? 'yes' : 'no';
|
|
}
|
|
return $default;
|
|
}
|
|
);
|
|
|
|
$this->instantiatePlugin();
|
|
|
|
$this->session->expects($this->any())
|
|
->method('getUser')
|
|
->willReturn($this->user);
|
|
|
|
if(!$shareWithGroupOnly) {
|
|
$this->userManager->expects($this->once())
|
|
->method('searchDisplayName')
|
|
->with($searchTerm, $this->limit, $this->offset)
|
|
->willReturn($userResponse);
|
|
} else {
|
|
if ($singleUser !== false) {
|
|
$this->groupManager->expects($this->exactly(2))
|
|
->method('getUserGroupIds')
|
|
->withConsecutive(
|
|
$this->user,
|
|
$singleUser
|
|
)
|
|
->willReturn($groupResponse);
|
|
} else {
|
|
$this->groupManager->expects($this->once())
|
|
->method('getUserGroupIds')
|
|
->with($this->user)
|
|
->willReturn($groupResponse);
|
|
}
|
|
|
|
$this->groupManager->expects($this->exactly(sizeof($groupResponse)))
|
|
->method('displayNamesInGroup')
|
|
->with($this->anything(), $searchTerm, $this->limit, $this->offset)
|
|
->willReturnMap($userResponse);
|
|
}
|
|
|
|
if ($singleUser !== false) {
|
|
$this->userManager->expects($this->once())
|
|
->method('get')
|
|
->with($searchTerm)
|
|
->willReturn($singleUser);
|
|
}
|
|
|
|
|
|
$moreResults = $this->plugin->search($searchTerm, $this->limit, $this->offset, $this->searchResult);
|
|
$result = $this->searchResult->asArray();
|
|
|
|
$this->assertEquals($exactExpected, $result['exact']['users']);
|
|
$this->assertEquals($expected, $result['users']);
|
|
$this->assertSame($reachedEnd, $moreResults);
|
|
}
|
|
|
|
public function takeOutCurrentUserProvider() {
|
|
$inputUsers = [
|
|
'alice' => 'Alice',
|
|
'bob' => 'Bob',
|
|
'carol' => 'Carol'
|
|
];
|
|
return [
|
|
[
|
|
$inputUsers,
|
|
['alice', 'carol'],
|
|
'bob'
|
|
],
|
|
[
|
|
$inputUsers,
|
|
['alice', 'bob', 'carol'],
|
|
'dave'
|
|
],
|
|
[
|
|
$inputUsers,
|
|
['alice', 'bob', 'carol'],
|
|
null
|
|
]
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider takeOutCurrentUserProvider
|
|
* @param array $users
|
|
* @param array $expectedUIDs
|
|
* @param $currentUserId
|
|
*/
|
|
public function testTakeOutCurrentUser(array $users, array $expectedUIDs, $currentUserId) {
|
|
$this->instantiatePlugin();
|
|
|
|
$this->session->expects($this->once())
|
|
->method('getUser')
|
|
->willReturnCallback(function() use ($currentUserId) {
|
|
if($currentUserId !== null) {
|
|
return $this->getUserMock($currentUserId, $currentUserId);
|
|
}
|
|
return null;
|
|
});
|
|
|
|
$this->plugin->takeOutCurrentUser($users);
|
|
$this->assertSame($expectedUIDs, array_keys($users));
|
|
}
|
|
}
|