nextcloud/apps
Louis Chemineau 009d0c550c
fix: Move CSRF check from base to PublicAuth for public.php
This currently prevent directly accessing a ressource when clicking on a link on a third party site. Example, clicking on `https://example.com/public.php/dav/files/pqLWcA269zfzXez/?accept=zip` in a GitHub comment.

Skipping the check is an issue with password protected shares, as it allows third party sites to request the ressource when the user already entered the password, aka CSRF.  So after removing the check from `base.php`, we need to add the it again in the `PublicAuth` plugin.

We also add a redirect to be helpful to the user.

**Warning**: this adds the limitation that clicking on a direct download link for password protected shares will redirect you to the password form, and then to the main share view.

Fix #52482

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-05-21 16:01:36 +02:00
..
admin_audit fix(admin_audit): Survive if file change id after rename (it should not) 2025-05-13 23:37:52 +02:00
cloud_federation_api fix(l10n): Update translations from Transifex 2025-04-30 00:23:19 +00:00
comments test: Fix coding standards 2025-05-15 08:48:13 +02:00
contactsinteraction test: Fix some apps/*/tests 2025-05-15 08:26:15 +02:00
dashboard test: Fix some apps/*/tests 2025-05-15 08:26:15 +02:00
dav fix: Move CSRF check from base to PublicAuth for public.php 2025-05-21 16:01:36 +02:00
encryption Merge pull request #52707 from nextcloud/encryption-no-header-size-error 2025-05-10 09:47:21 +02:00
federatedfilesharing fix(l10n): Update translations from Transifex 2025-05-13 00:22:59 +00:00
federation fix(l10n): Update translations from Transifex 2025-05-10 00:22:59 +00:00
files chore: remove files file templates deprecated since v18 and provided by richdocuments 2025-05-16 12:45:55 +02:00
files_external test: Make extending tests also static already 2025-05-15 08:29:33 +02:00
files_reminders fix(l10n): Update translations from Transifex 2025-05-11 00:22:42 +00:00
files_sharing fix(l10n): Update translations from Transifex 2025-05-16 00:22:51 +00:00
files_trashbin refactor: Extend rector to core/ 2025-05-15 00:16:54 +02:00
files_versions Merge pull request #52820 from nextcloud/refactor/rector-core 2025-05-15 01:42:15 +02:00
lookup_server_connector Fix(l10n): Update translations from Transifex 2025-04-10 00:22:46 +00:00
oauth2 fix(l10n): Update translations from Transifex 2025-04-28 00:23:11 +00:00
profile Fix(l10n): Update translations from Transifex 2025-04-12 00:23:05 +00:00
provisioning_api fix(l10n): Update translations from Transifex 2025-05-02 00:22:57 +00:00
settings fix(l10n): Update translations from Transifex 2025-05-16 00:22:51 +00:00
sharebymail Merge pull request #52634 from nextcloud/perf/share20/get-all-shares-in-folder 2025-05-08 16:24:21 +02:00
systemtags fix(l10n): Update translations from Transifex 2025-05-14 00:22:28 +00:00
testing chore: Apply new rector configuration to apps folder 2025-02-13 11:46:42 +01:00
theming fix(l10n): Update translations from Transifex 2025-05-14 00:22:28 +00:00
twofactor_backupcodes test: Fix coding standards 2025-05-15 08:48:13 +02:00
updatenotification test: Fix some apps/*/tests 2025-05-15 08:26:15 +02:00
user_ldap fix(l10n): Update translations from Transifex 2025-05-16 00:22:51 +00:00
user_status test: Fix coding standards 2025-05-15 08:48:13 +02:00
weather_status fix (WeatherStatus): Check if result is an array 2025-04-30 08:01:35 +02:00
webhook_listeners test: Fix some apps/*/tests 2025-05-15 08:26:15 +02:00
workflowengine test: Fix some apps/*/tests 2025-05-15 08:26:15 +02:00