nextcloud/apps/files
Daniel Calviño Sánchez 10e9eeec45 Fix menu visibility
The crumb for the menu was shown like any other crumb when calling
"_showCrumb", but it was also shown when other crumbs were hidden
without taking into account the available width. This caused several
related problems, like the breadcrumbs taking too much space when the
menu was sometimes shown after the rest of the crumbs were adjusted to
the available width, or the menu being shown instead of the last crumb
even if there was room for it when the available width was increased.

Now the menu is always hidden before starting the resizing of the crumbs
to ensure that whether it was previously shown or not does not affect
the result. In a similar way, the menu will no longer be shown by
"_showCrumb", as it is not a regular crumb that has to be shown simply
if there is enough room. The menu is now shown as soon as any other
crumb is hidden; this ensures that the menu width will be taken into
account in further width checks. As when _updateMenu" is called it no
longer needs to take care of showing the menu this fixes the issue
revealed when fixing the test setup in the previous commit.

Finally, this implicitly fixes the failure in the breadcrumbs tests when
run on Firefox, as it was caused by the menu interfering in the
calculations of the other crumbs when increasing the width.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
..
ajax Use ::class statement instead of string 2018-01-29 12:03:47 +01:00
appinfo Fix info.xml files of shipped apps 2018-02-16 10:24:03 +01:00
composer Update composer 2018-01-12 23:16:10 +01:00
css Merge pull request #7634 from Abijeet/bug-7539 2018-01-03 08:28:26 +01:00
img Add some whitespace around change.svg icon 2018-02-22 15:46:21 +01:00
js Fix menu visibility 2018-02-28 15:03:26 +01:00
l10n [tx-robot] updated from transifex 2018-02-28 01:12:31 +00:00
lib Use ::class statement instead of string 2018-01-29 12:03:47 +01:00
templates Split move and copy operations 2018-02-15 18:51:12 +01:00
tests Fix menu visibility 2018-02-28 15:03:26 +01:00
download.php Use normal header() calls instead of private method calls 2018-02-19 09:40:25 +01:00
list.php Remove upload_limit in files app as it is not needed with PUT upload (#26069) 2016-11-02 20:43:35 +01:00
recentlist.php Change @georgehrke's email 2017-11-06 20:38:59 +01:00
simplelist.php Fix apps/ 2016-07-21 18:13:57 +02:00