mirror of
https://github.com/nextcloud/server.git
synced 2026-07-12 19:16:25 -04:00
1b2b4cb660
Switch all encryption config reads/writes from deprecated string-typed IConfig to bool-typed IAppConfig (getValueBool/setValueBool). Adds RetypeEncryptionConfigKeys repair step to retype existing string values to bool on upgrade. Includes lazy IAppConfig resolution in Manager and AppConfigTypeConflictException fallbacks throughout for safety during the upgrade window. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>
98 lines
3.4 KiB
PHP
98 lines
3.4 KiB
PHP
<?php
|
|
|
|
/**
|
|
* SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
|
|
* SPDX-FileCopyrightText: 2016 ownCloud, Inc.
|
|
* SPDX-License-Identifier: AGPL-3.0-only
|
|
*/
|
|
|
|
namespace Tests\Core\Command\Encryption;
|
|
|
|
use OC\Core\Command\Encryption\Enable;
|
|
use OCP\Encryption\IManager;
|
|
use OCP\IAppConfig;
|
|
use Symfony\Component\Console\Input\InputInterface;
|
|
use Symfony\Component\Console\Output\OutputInterface;
|
|
use Test\TestCase;
|
|
|
|
class EnableTest extends TestCase {
|
|
/** @var \PHPUnit\Framework\MockObject\MockObject */
|
|
protected $appConfig;
|
|
/** @var \PHPUnit\Framework\MockObject\MockObject */
|
|
protected $manager;
|
|
/** @var \PHPUnit\Framework\MockObject\MockObject */
|
|
protected $consoleInput;
|
|
/** @var \PHPUnit\Framework\MockObject\MockObject */
|
|
protected $consoleOutput;
|
|
|
|
/** @var \Symfony\Component\Console\Command\Command */
|
|
protected $command;
|
|
|
|
#[\Override]
|
|
protected function setUp(): void {
|
|
parent::setUp();
|
|
|
|
$appConfig = $this->appConfig = $this->getMockBuilder(IAppConfig::class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$manager = $this->manager = $this->getMockBuilder(IManager::class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$this->consoleInput = $this->getMockBuilder(InputInterface::class)->getMock();
|
|
$this->consoleOutput = $this->getMockBuilder(OutputInterface::class)->getMock();
|
|
|
|
/** @var \OCP\IAppConfig $appConfig */
|
|
/** @var \OCP\Encryption\IManager $manager */
|
|
$this->command = new Enable($appConfig, $manager);
|
|
}
|
|
|
|
public static function dataEnable(): array {
|
|
return [
|
|
[false, '', [], true, 'Encryption enabled', 'No encryption module is loaded'],
|
|
[true, '', [], false, 'Encryption is already enabled', 'No encryption module is loaded'],
|
|
[false, '', ['OC_TEST_MODULE' => []], true, 'Encryption enabled', 'No default module is set'],
|
|
[false, 'OC_NO_MODULE', ['OC_TEST_MODULE' => []], true, 'Encryption enabled', 'The current default module does not exist: OC_NO_MODULE'],
|
|
[false, 'OC_TEST_MODULE', ['OC_TEST_MODULE' => []], true, 'Encryption enabled', 'Default module: OC_TEST_MODULE'],
|
|
];
|
|
}
|
|
|
|
#[\PHPUnit\Framework\Attributes\DataProvider('dataEnable')]
|
|
public function testEnable(bool $oldStatus, ?string $defaultModule, array $availableModules, bool $isUpdating, string $expectedString, string $expectedDefaultModuleString): void {
|
|
if ($isUpdating) {
|
|
$this->appConfig->expects($this->once())
|
|
->method('setValueBool')
|
|
->with('core', 'encryption_enabled', true);
|
|
}
|
|
|
|
$this->manager->expects($this->atLeastOnce())
|
|
->method('getEncryptionModules')
|
|
->willReturn($availableModules);
|
|
|
|
$this->appConfig->expects($this->once())
|
|
->method('getValueBool')
|
|
->with('core', 'encryption_enabled', false)
|
|
->willReturn($oldStatus);
|
|
|
|
if (!empty($availableModules)) {
|
|
$this->appConfig->expects($this->once())
|
|
->method('getValueString')
|
|
->with('core', 'default_encryption_module', '')
|
|
->willReturn((string)$defaultModule);
|
|
}
|
|
|
|
$calls = [
|
|
[$expectedString, 0],
|
|
['', 0],
|
|
[$expectedDefaultModuleString, 0],
|
|
];
|
|
$this->consoleOutput->expects($this->exactly(3))
|
|
->method('writeln')
|
|
->willReturnCallback(function (string $message, int $level) use (&$calls): void {
|
|
$call = array_shift($calls);
|
|
$this->assertStringContainsString($call[0], $message);
|
|
$this->assertSame($call[1], $level);
|
|
});
|
|
|
|
self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
|
|
}
|
|
}
|