mirror of
https://github.com/nextcloud/server.git
synced 2026-02-03 20:41:22 -05:00
To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
392 lines
11 KiB
PHP
392 lines
11 KiB
PHP
<?php
|
|
/**
|
|
* @copyright Copyright (c) 2016, ownCloud, Inc.
|
|
*
|
|
* @author Bjoern Schiessle <bjoern@schiessle.org>
|
|
* @author Björn Schießle <bjoern@schiessle.org>
|
|
* @author Christoph Wurst <christoph@winzerhof-wurst.at>
|
|
* @author Clark Tomlinson <fallen013@gmail.com>
|
|
* @author Joas Schilling <coding@schilljs.com>
|
|
* @author Morris Jobke <hey@morrisjobke.de>
|
|
* @author Roeland Jago Douma <roeland@famdouma.nl>
|
|
*
|
|
* @license AGPL-3.0
|
|
*
|
|
* This code is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*
|
|
*/
|
|
|
|
namespace OCA\Encryption\Tests\Hooks;
|
|
|
|
use OCA\Encryption\Crypto\Crypt;
|
|
use OCA\Encryption\Hooks\UserHooks;
|
|
use OCA\Encryption\KeyManager;
|
|
use OCA\Encryption\Recovery;
|
|
use OCA\Encryption\Session;
|
|
use OCA\Encryption\Users\Setup;
|
|
use OCA\Encryption\Util;
|
|
use OCP\ILogger;
|
|
use OCP\IUser;
|
|
use OCP\IUserManager;
|
|
use OCP\IUserSession;
|
|
use PHPUnit\Framework\MockObject\MockObject;
|
|
use Test\TestCase;
|
|
|
|
/**
|
|
* Class UserHooksTest
|
|
*
|
|
* @group DB
|
|
* @package OCA\Encryption\Tests\Hooks
|
|
*/
|
|
class UserHooksTest extends TestCase {
|
|
/**
|
|
* @var \PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
private $utilMock;
|
|
/**
|
|
* @var \PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
private $recoveryMock;
|
|
/**
|
|
* @var \PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
private $sessionMock;
|
|
/**
|
|
* @var \PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
private $keyManagerMock;
|
|
/**
|
|
* @var \PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
private $userManagerMock;
|
|
|
|
/**
|
|
* @var \PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
private $userSetupMock;
|
|
/**
|
|
* @var \PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
private $userSessionMock;
|
|
/**
|
|
* @var MockObject|IUser
|
|
*/
|
|
private $user;
|
|
/**
|
|
* @var \PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
private $cryptMock;
|
|
/**
|
|
* @var \PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
private $loggerMock;
|
|
/**
|
|
* @var UserHooks
|
|
*/
|
|
private $instance;
|
|
|
|
private $params = ['uid' => 'testUser', 'password' => 'password'];
|
|
|
|
public function testLogin() {
|
|
$this->userSetupMock->expects($this->once())
|
|
->method('setupUser')
|
|
->willReturnOnConsecutiveCalls(true, false);
|
|
|
|
$this->keyManagerMock->expects($this->once())
|
|
->method('init')
|
|
->with('testUser', 'password');
|
|
|
|
$this->assertNull($this->instance->login($this->params));
|
|
}
|
|
|
|
public function testLogout() {
|
|
$this->sessionMock->expects($this->once())
|
|
->method('clear');
|
|
$this->instance->logout();
|
|
$this->addToAssertionCount(1);
|
|
}
|
|
|
|
public function testPostCreateUser() {
|
|
$this->userSetupMock->expects($this->once())
|
|
->method('setupUser');
|
|
|
|
$this->instance->postCreateUser($this->params);
|
|
$this->addToAssertionCount(1);
|
|
}
|
|
|
|
public function testPostDeleteUser() {
|
|
$this->keyManagerMock->expects($this->once())
|
|
->method('deletePublicKey')
|
|
->with('testUser');
|
|
|
|
$this->instance->postDeleteUser($this->params);
|
|
$this->addToAssertionCount(1);
|
|
}
|
|
|
|
public function testPrePasswordReset() {
|
|
$params = ['uid' => 'user1'];
|
|
$expected = ['user1' => true];
|
|
$this->instance->prePasswordReset($params);
|
|
$passwordResetUsers = $this->invokePrivate($this->instance, 'passwordResetUsers');
|
|
|
|
$this->assertSame($expected, $passwordResetUsers);
|
|
}
|
|
|
|
public function testPostPasswordReset() {
|
|
$params = ['uid' => 'user1', 'password' => 'password'];
|
|
$this->invokePrivate($this->instance, 'passwordResetUsers', [['user1' => true]]);
|
|
$this->keyManagerMock->expects($this->once())->method('backupUserKeys')
|
|
->with('passwordReset', 'user1');
|
|
$this->keyManagerMock->expects($this->once())->method('deleteUserKeys')
|
|
->with('user1');
|
|
$this->userSetupMock->expects($this->once())->method('setupUser')
|
|
->with('user1', 'password');
|
|
|
|
$this->instance->postPasswordReset($params);
|
|
$passwordResetUsers = $this->invokePrivate($this->instance, 'passwordResetUsers');
|
|
$this->assertEmpty($passwordResetUsers);
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataTestPreSetPassphrase
|
|
*/
|
|
public function testPreSetPassphrase($canChange) {
|
|
|
|
/** @var UserHooks | \PHPUnit_Framework_MockObject_MockObject $instance */
|
|
$instance = $this->getMockBuilder(UserHooks::class)
|
|
->setConstructorArgs(
|
|
[
|
|
$this->keyManagerMock,
|
|
$this->userManagerMock,
|
|
$this->loggerMock,
|
|
$this->userSetupMock,
|
|
$this->userSessionMock,
|
|
$this->utilMock,
|
|
$this->sessionMock,
|
|
$this->cryptMock,
|
|
$this->recoveryMock
|
|
]
|
|
)
|
|
->setMethods(['setPassphrase'])
|
|
->getMock();
|
|
|
|
$userMock = $this->createMock(IUser::class);
|
|
|
|
$this->userManagerMock->expects($this->once())
|
|
->method('get')
|
|
->with($this->params['uid'])
|
|
->willReturn($userMock);
|
|
$userMock->expects($this->once())
|
|
->method('canChangePassword')
|
|
->willReturn($canChange);
|
|
|
|
if ($canChange) {
|
|
// in this case the password will be changed in the post hook
|
|
$instance->expects($this->never())->method('setPassphrase');
|
|
} else {
|
|
// if user can't change the password we update the encryption
|
|
// key password already in the pre hook
|
|
$instance->expects($this->once())
|
|
->method('setPassphrase')
|
|
->with($this->params);
|
|
}
|
|
|
|
$instance->preSetPassphrase($this->params);
|
|
}
|
|
|
|
public function dataTestPreSetPassphrase() {
|
|
return [
|
|
[true],
|
|
[false]
|
|
];
|
|
}
|
|
|
|
public function XtestSetPassphrase() {
|
|
$this->sessionMock->expects($this->once())
|
|
->method('getPrivateKey')
|
|
->willReturn(true);
|
|
|
|
$this->cryptMock->expects($this->exactly(4))
|
|
->method('encryptPrivateKey')
|
|
->willReturn(true);
|
|
|
|
$this->cryptMock->expects($this->any())
|
|
->method('generateHeader')
|
|
->willReturn(Crypt::HEADER_START . ':Cipher:test:' . Crypt::HEADER_END);
|
|
|
|
$this->keyManagerMock->expects($this->exactly(4))
|
|
->method('setPrivateKey')
|
|
->willReturnCallback(function ($user, $key) {
|
|
$header = substr($key, 0, strlen(Crypt::HEADER_START));
|
|
$this->assertSame(
|
|
Crypt::HEADER_START,
|
|
$header, 'every encrypted file should start with a header');
|
|
});
|
|
|
|
$this->assertNull($this->instance->setPassphrase($this->params));
|
|
$this->params['recoveryPassword'] = 'password';
|
|
|
|
$this->recoveryMock->expects($this->exactly(3))
|
|
->method('isRecoveryEnabledForUser')
|
|
->with('testUser1')
|
|
->willReturnOnConsecutiveCalls(true, false);
|
|
|
|
|
|
$this->instance = $this->getMockBuilder(UserHooks::class)
|
|
->setConstructorArgs(
|
|
[
|
|
$this->keyManagerMock,
|
|
$this->userManagerMock,
|
|
$this->loggerMock,
|
|
$this->userSetupMock,
|
|
$this->userSessionMock,
|
|
$this->utilMock,
|
|
$this->sessionMock,
|
|
$this->cryptMock,
|
|
$this->recoveryMock
|
|
]
|
|
)->setMethods(['initMountPoints'])->getMock();
|
|
|
|
$this->instance->expects($this->exactly(3))->method('initMountPoints');
|
|
|
|
$this->params['uid'] = 'testUser1';
|
|
|
|
// Test first if statement
|
|
$this->assertNull($this->instance->setPassphrase($this->params));
|
|
|
|
// Test Second if conditional
|
|
$this->keyManagerMock->expects($this->exactly(2))
|
|
->method('userHasKeys')
|
|
->with('testUser1')
|
|
->willReturn(true);
|
|
|
|
$this->assertNull($this->instance->setPassphrase($this->params));
|
|
|
|
// Test third and final if condition
|
|
$this->utilMock->expects($this->once())
|
|
->method('userHasFiles')
|
|
->with('testUser1')
|
|
->willReturn(false);
|
|
|
|
$this->cryptMock->expects($this->once())
|
|
->method('createKeyPair');
|
|
|
|
$this->keyManagerMock->expects($this->once())
|
|
->method('setPrivateKey');
|
|
|
|
$this->recoveryMock->expects($this->once())
|
|
->method('recoverUsersFiles')
|
|
->with('password', 'testUser1');
|
|
|
|
$this->assertNull($this->instance->setPassphrase($this->params));
|
|
}
|
|
|
|
public function testSetPassphraseResetUserMode() {
|
|
$params = ['uid' => 'user1', 'password' => 'password'];
|
|
$this->invokePrivate($this->instance, 'passwordResetUsers', [[$params['uid'] => true]]);
|
|
$this->sessionMock->expects($this->never())->method('getPrivateKey');
|
|
$this->keyManagerMock->expects($this->never())->method('setPrivateKey');
|
|
$this->assertTrue($this->instance->setPassphrase($params));
|
|
$this->invokePrivate($this->instance, 'passwordResetUsers', [[]]);
|
|
}
|
|
|
|
public function XtestSetPasswordNoUser() {
|
|
$userSessionMock = $this->getMockBuilder(IUserSession::class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$userSessionMock->expects($this->any())->method('getUser')->willReturn(null);
|
|
|
|
$this->recoveryMock->expects($this->once())
|
|
->method('isRecoveryEnabledForUser')
|
|
->with('testUser')
|
|
->willReturn(false);
|
|
|
|
$userHooks = $this->getMockBuilder(UserHooks::class)
|
|
->setConstructorArgs(
|
|
[
|
|
$this->keyManagerMock,
|
|
$this->userManagerMock,
|
|
$this->loggerMock,
|
|
$this->userSetupMock,
|
|
$userSessionMock,
|
|
$this->utilMock,
|
|
$this->sessionMock,
|
|
$this->cryptMock,
|
|
$this->recoveryMock
|
|
]
|
|
)->setMethods(['initMountPoints'])->getMock();
|
|
|
|
/** @var \OCA\Encryption\Hooks\UserHooks $userHooks */
|
|
$this->assertNull($userHooks->setPassphrase($this->params));
|
|
}
|
|
|
|
protected function setUp(): void {
|
|
parent::setUp();
|
|
$this->loggerMock = $this->createMock(ILogger::class);
|
|
$this->keyManagerMock = $this->getMockBuilder(KeyManager::class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$this->userManagerMock = $this->getMockBuilder(IUserManager::class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$this->userSetupMock = $this->getMockBuilder(Setup::class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->user = $this->createMock(IUser::class);
|
|
$this->user->expects($this->any())
|
|
->method('getUID')
|
|
->willReturn('testUser');
|
|
|
|
$this->userSessionMock = $this->createMock(IUserSession::class);
|
|
$this->userSessionMock->expects($this->any())
|
|
->method('getUser')
|
|
->willReturn($this->user);
|
|
|
|
$utilMock = $this->getMockBuilder(Util::class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$sessionMock = $this->getMockBuilder(Session::class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->cryptMock = $this->getMockBuilder(Crypt::class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$recoveryMock = $this->getMockBuilder(Recovery::class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->sessionMock = $sessionMock;
|
|
$this->recoveryMock = $recoveryMock;
|
|
$this->utilMock = $utilMock;
|
|
$this->utilMock->expects($this->any())->method('isMasterKeyEnabled')->willReturn(false);
|
|
|
|
$this->instance = $this->getMockBuilder(UserHooks::class)
|
|
->setConstructorArgs(
|
|
[
|
|
$this->keyManagerMock,
|
|
$this->userManagerMock,
|
|
$this->loggerMock,
|
|
$this->userSetupMock,
|
|
$this->userSessionMock,
|
|
$this->utilMock,
|
|
$this->sessionMock,
|
|
$this->cryptMock,
|
|
$this->recoveryMock
|
|
]
|
|
)->setMethods(['setupFS'])->getMock();
|
|
}
|
|
}
|