nextcloud/tests/lib/AppFramework/Middleware/Security/PasswordConfirmationMiddlewareTest.php
Arthur Schiwon 340939e688
fix(Session): avoid password confirmation on SSO
SSO backends like SAML and OIDC tried a trick to suppress password
confirmations as they are not possible by design. At least for SAML it was
not reliable when existing user backends where used as user repositories.

Now we are setting a special scope with the token, and also make sure that
the scope is taken over when tokens are regenerated.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-05 19:01:13 +02:00

199 lines
5.6 KiB
PHP

<?php
/**
* SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
namespace Test\AppFramework\Middleware\Security;
use OC\AppFramework\Middleware\Security\Exceptions\NotConfirmedException;
use OC\AppFramework\Middleware\Security\PasswordConfirmationMiddleware;
use OC\AppFramework\Utility\ControllerMethodReflector;
use OC\Authentication\Token\IProvider;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\Authentication\Token\IToken;
use OCP\IRequest;
use OCP\ISession;
use OCP\IUser;
use OCP\IUserSession;
use Test\AppFramework\Middleware\Security\Mock\PasswordConfirmationMiddlewareController;
use Test\TestCase;
class PasswordConfirmationMiddlewareTest extends TestCase {
/** @var ControllerMethodReflector */
private $reflector;
/** @var ISession|\PHPUnit\Framework\MockObject\MockObject */
private $session;
/** @var IUserSession|\PHPUnit\Framework\MockObject\MockObject */
private $userSession;
/** @var IUser|\PHPUnit\Framework\MockObject\MockObject */
private $user;
/** @var PasswordConfirmationMiddleware */
private $middleware;
/** @var PasswordConfirmationMiddlewareController */
private $controller;
/** @var ITimeFactory|\PHPUnit\Framework\MockObject\MockObject */
private $timeFactory;
private IProvider|\PHPUnit\Framework\MockObject\MockObject $tokenProvider;
protected function setUp(): void {
$this->reflector = new ControllerMethodReflector();
$this->session = $this->createMock(ISession::class);
$this->userSession = $this->createMock(IUserSession::class);
$this->user = $this->createMock(IUser::class);
$this->timeFactory = $this->createMock(ITimeFactory::class);
$this->tokenProvider = $this->createMock(IProvider::class);
$this->controller = new PasswordConfirmationMiddlewareController(
'test',
$this->createMock(IRequest::class)
);
$this->middleware = new PasswordConfirmationMiddleware(
$this->reflector,
$this->session,
$this->userSession,
$this->timeFactory,
$this->tokenProvider,
);
}
public function testNoAnnotationNorAttribute() {
$this->reflector->reflect($this->controller, __FUNCTION__);
$this->session->expects($this->never())
->method($this->anything());
$this->userSession->expects($this->never())
->method($this->anything());
$this->middleware->beforeController($this->controller, __FUNCTION__);
}
public function testDifferentAnnotation() {
$this->reflector->reflect($this->controller, __FUNCTION__);
$this->session->expects($this->never())
->method($this->anything());
$this->userSession->expects($this->never())
->method($this->anything());
$this->middleware->beforeController($this->controller, __FUNCTION__);
}
/**
* @dataProvider dataProvider
*/
public function testAnnotation($backend, $lastConfirm, $currentTime, $exception) {
$this->reflector->reflect($this->controller, __FUNCTION__);
$this->user->method('getBackendClassName')
->willReturn($backend);
$this->userSession->method('getUser')
->willReturn($this->user);
$this->session->method('get')
->with('last-password-confirm')
->willReturn($lastConfirm);
$this->timeFactory->method('getTime')
->willReturn($currentTime);
$token = $this->createMock(IToken::class);
$token->method('getScopeAsArray')
->willReturn([]);
$this->tokenProvider->expects($this->once())
->method('getToken')
->willReturn($token);
$thrown = false;
try {
$this->middleware->beforeController($this->controller, __FUNCTION__);
} catch (NotConfirmedException $e) {
$thrown = true;
}
$this->assertSame($exception, $thrown);
}
/**
* @dataProvider dataProvider
*/
public function testAttribute($backend, $lastConfirm, $currentTime, $exception) {
$this->reflector->reflect($this->controller, __FUNCTION__);
$this->user->method('getBackendClassName')
->willReturn($backend);
$this->userSession->method('getUser')
->willReturn($this->user);
$this->session->method('get')
->with('last-password-confirm')
->willReturn($lastConfirm);
$this->timeFactory->method('getTime')
->willReturn($currentTime);
$token = $this->createMock(IToken::class);
$token->method('getScopeAsArray')
->willReturn([]);
$this->tokenProvider->expects($this->once())
->method('getToken')
->willReturn($token);
$thrown = false;
try {
$this->middleware->beforeController($this->controller, __FUNCTION__);
} catch (NotConfirmedException $e) {
$thrown = true;
}
$this->assertSame($exception, $thrown);
}
public function dataProvider() {
return [
['foo', 2000, 4000, true],
['foo', 2000, 3000, false],
['user_saml', 2000, 4000, false],
['user_saml', 2000, 3000, false],
['foo', 2000, 3815, false],
['foo', 2000, 3816, true],
];
}
public function testSSO() {
static $sessionId = 'mySession1d';
$this->reflector->reflect($this->controller, __FUNCTION__);
$this->user->method('getBackendClassName')
->willReturn('fictional_backend');
$this->userSession->method('getUser')
->willReturn($this->user);
$this->session->method('get')
->with('last-password-confirm')
->willReturn(0);
$this->session->method('getId')
->willReturn($sessionId);
$this->timeFactory->method('getTime')
->willReturn(9876);
$token = $this->createMock(IToken::class);
$token->method('getScopeAsArray')
->willReturn(['sso-based-login' => true]);
$this->tokenProvider->expects($this->once())
->method('getToken')
->with($sessionId)
->willReturn($token);
$thrown = false;
try {
$this->middleware->beforeController($this->controller, __FUNCTION__);
} catch (NotConfirmedException) {
$thrown = true;
}
$this->assertSame(false, $thrown);
}
}