mirror of
https://github.com/nextcloud/server.git
synced 2026-02-13 15:54:59 -05:00
This adds a phan plugin which checks for SQL injections on code using our QueryBuilder, while it isn't perfect it should already catch most potential issues. As always, static analysis will sometimes have false positives and this is also here the case. So in some cases the analyzer just doesn't know if something is potential user input or not, thus I had to add some `@suppress SqlInjectionChecker` in front of those potential injections. The Phan plugin hasn't the most awesome code but it works and I also added a file with test cases. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
173 lines
5.8 KiB
PHP
173 lines
5.8 KiB
PHP
<?php
|
|
/**
|
|
* @copyright Copyright (c) 2016, ownCloud, Inc.
|
|
*
|
|
* @author Bart Visscher <bartv@thisnet.nl>
|
|
* @author eduardo <eduardo@vnexu.net>
|
|
* @author Joas Schilling <coding@schilljs.com>
|
|
* @author Morris Jobke <hey@morrisjobke.de>
|
|
* @author Robin Appelman <robin@icewind.nl>
|
|
* @author Roeland Jago Douma <roeland@famdouma.nl>
|
|
* @author Thomas Müller <thomas.mueller@tmit.eu>
|
|
*
|
|
* @license AGPL-3.0
|
|
*
|
|
* This code is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*
|
|
*/
|
|
namespace OC\Setup;
|
|
|
|
use OC\DatabaseException;
|
|
use OC\DB\QueryBuilder\Literal;
|
|
use OCP\IDBConnection;
|
|
|
|
class PostgreSQL extends AbstractDatabase {
|
|
public $dbprettyname = 'PostgreSQL';
|
|
|
|
/**
|
|
* @param string $username
|
|
* @throws \OC\DatabaseSetupException
|
|
* @suppress SqlInjectionChecker
|
|
*/
|
|
public function setupDatabase($username) {
|
|
try {
|
|
$connection = $this->connect([
|
|
'dbname' => 'postgres'
|
|
]);
|
|
//check for roles creation rights in postgresql
|
|
$builder = $connection->getQueryBuilder();
|
|
$builder->automaticTablePrefix(false);
|
|
$query = $builder
|
|
->select('rolname')
|
|
->from('pg_roles')
|
|
->where($builder->expr()->eq('rolcreaterole', new Literal('TRUE')))
|
|
->andWhere($builder->expr()->eq('rolname', $builder->createNamedParameter($this->dbUser)));
|
|
|
|
try {
|
|
$result = $query->execute();
|
|
$canCreateRoles = $result->rowCount() > 0;
|
|
} catch (DatabaseException $e) {
|
|
$canCreateRoles = false;
|
|
}
|
|
|
|
if ($canCreateRoles) {
|
|
//use the admin login data for the new database user
|
|
|
|
//add prefix to the postgresql user name to prevent collisions
|
|
$this->dbUser = 'oc_' . strtolower($username);
|
|
//create a new password so we don't need to store the admin config in the config file
|
|
$this->dbPassword = \OC::$server->getSecureRandom()->generate(30, \OCP\Security\ISecureRandom::CHAR_LOWER . \OCP\Security\ISecureRandom::CHAR_DIGITS);
|
|
|
|
$this->createDBUser($connection);
|
|
}
|
|
|
|
$this->config->setValues([
|
|
'dbuser' => $this->dbUser,
|
|
'dbpassword' => $this->dbPassword,
|
|
]);
|
|
|
|
//create the database
|
|
$this->createDatabase($connection);
|
|
$query = $connection->prepare("select count(*) FROM pg_class WHERE relname=? limit 1");
|
|
$query->execute([$this->tablePrefix . "users"]);
|
|
$tablesSetup = $query->fetchColumn() > 0;
|
|
|
|
// the connection to dbname=postgres is not needed anymore
|
|
$connection->close();
|
|
} catch (\Exception $e) {
|
|
$this->logger->logException($e);
|
|
$this->logger->warning('Error trying to connect as "postgres", assuming database is setup and tables need to be created');
|
|
$tablesSetup = false;
|
|
$this->config->setValues([
|
|
'dbuser' => $this->dbUser,
|
|
'dbpassword' => $this->dbPassword,
|
|
]);
|
|
}
|
|
|
|
// connect to the ownCloud database (dbname=$this->dbname) and check if it needs to be filled
|
|
$this->dbUser = $this->config->getValue('dbuser');
|
|
$this->dbPassword = $this->config->getValue('dbpassword');
|
|
$connection = $this->connect();
|
|
try {
|
|
$connection->connect();
|
|
} catch (\Exception $e) {
|
|
$this->logger->logException($e);
|
|
throw new \OC\DatabaseSetupException($this->trans->t('PostgreSQL username and/or password not valid'),
|
|
$this->trans->t('You need to enter details of an existing account.'));
|
|
}
|
|
|
|
|
|
if (!$tablesSetup) {
|
|
\OC_DB::createDbFromStructure($this->dbDefinitionFile);
|
|
}
|
|
}
|
|
|
|
private function createDatabase(IDBConnection $connection) {
|
|
if (!$this->databaseExists($connection)) {
|
|
//The database does not exists... let's create it
|
|
$query = $connection->prepare("CREATE DATABASE " . addslashes($this->dbName) . " OWNER " . addslashes($this->dbUser));
|
|
try {
|
|
$query->execute();
|
|
} catch (DatabaseException $e) {
|
|
$this->logger->error('Error while trying to create database');
|
|
$this->logger->logException($e);
|
|
}
|
|
} else {
|
|
$query = $connection->prepare("REVOKE ALL PRIVILEGES ON DATABASE " . addslashes($this->dbName) . " FROM PUBLIC");
|
|
try {
|
|
$query->execute();
|
|
} catch (DatabaseException $e) {
|
|
$this->logger->error('Error while trying to restrict database permissions');
|
|
$this->logger->logException($e);
|
|
}
|
|
}
|
|
}
|
|
|
|
private function userExists(IDBConnection $connection) {
|
|
$builder = $connection->getQueryBuilder();
|
|
$builder->automaticTablePrefix(false);
|
|
$query = $builder->select('*')
|
|
->from('pg_roles')
|
|
->where($builder->expr()->eq('rolname', $builder->createNamedParameter($this->dbUser)));
|
|
$result = $query->execute();
|
|
return $result->rowCount() > 0;
|
|
}
|
|
|
|
private function databaseExists(IDBConnection $connection) {
|
|
$builder = $connection->getQueryBuilder();
|
|
$builder->automaticTablePrefix(false);
|
|
$query = $builder->select('datname')
|
|
->from('pg_database')
|
|
->where($builder->expr()->eq('datname', $builder->createNamedParameter($this->dbName)));
|
|
$result = $query->execute();
|
|
return $result->rowCount() > 0;
|
|
}
|
|
|
|
private function createDBUser(IDBConnection $connection) {
|
|
$dbUser = $this->dbUser;
|
|
try {
|
|
$i = 1;
|
|
while ($this->userExists($connection)) {
|
|
$i++;
|
|
$this->dbUser = $dbUser . $i;
|
|
};
|
|
|
|
// create the user
|
|
$query = $connection->prepare("CREATE USER " . addslashes($this->dbUser) . " CREATEDB PASSWORD '" . addslashes($this->dbPassword) . "'");
|
|
$query->execute();
|
|
} catch (DatabaseException $e) {
|
|
$this->logger->error('Error while trying to create database user');
|
|
$this->logger->logException($e);
|
|
}
|
|
}
|
|
}
|