mirror of
https://github.com/nextcloud/server.git
synced 2026-06-18 05:00:03 -04:00
3f3f9c6464
Address review feedback (@marcelklehr, Copilot): - lockTask claims only SCHEDULED tasks (was status != RUNNING) and stamps started_at in the same atomic UPDATE, so a finished task cannot be re-claimed and the external-provider claim path records started_at as well. - claimWithBoundedRetry re-reads after lockTask instead of a follow-up UPDATE. - Oracle joins SQLite on the bounded-retry fallback: Oracle cannot combine a row-limiting clause with FOR UPDATE (ORA-02014), which failed the claim tests on Oracle CI. - Reword the worker docblock/comments to "prefer oldest available" (parallel SKIP LOCKED does not guarantee a strict global order). - Add a regression test that lockTask does not resurrect a finished task. Signed-off-by: Yoan Bozhilov <bygadd@gmail.com> Assisted-by: Claude Code:claude-opus-4-8 |
||
|---|---|---|
| .. | ||
| apps | ||
| blueprints | ||
| Core | ||
| data | ||
| docker | ||
| lib | ||
| objectstore | ||
| autoload.php | ||
| bootstrap.php | ||
| databases-all-config.php | ||
| drone-run-php-tests.sh | ||
| drone-wait-objectstore.sh | ||
| enable_all.php | ||
| memcached.config.php | ||
| phpunit-autotest-external.xml | ||
| phpunit-autotest.xml | ||
| preseed-config.php | ||
| redis-cluster.config.php | ||
| redis.config.php | ||
| startsessionlistener.php | ||