mirror of
https://github.com/nextcloud/server.git
synced 2026-02-03 20:41:22 -05:00
Any `\OCP\Authentication\IApacheBackend` previously had to implement `getLogoutAttribute` which returns a string.
This string is directly injected into the logout `<a>` tag, so returning something like `href="foo"` would result
in `<a href="foo">`.
This is rather error prone and also in Nextcloud 12 broken as the logout entry has been moved with
054e161eb5 inside the navigation manager where one cannot simply inject attributes.
Thus this feature is broken in Nextcloud 12 which effectively leads to the bug described at nextcloud/user_saml#112,
people cannot logout anymore when using SAML using SLO. Basically in case of SAML you have a SLO url which redirects
you to the IdP and properly logs you out there as well.
Instead of monkey patching the Navigation manager I decided to instead change `\OCP\Authentication\IApacheBackend` to
use `\OCP\Authentication\IApacheBackend::getLogoutUrl` instead where it can return a string with the appropriate logout
URL. Since this functionality is only prominently used in the SAML plugin. Any custom app would need a small change but
I'm not aware of any and there's simply no way to fix this properly otherwise.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
292 lines
7.5 KiB
PHP
292 lines
7.5 KiB
PHP
<?php
|
|
/**
|
|
* @copyright Copyright (c) 2016, ownCloud GmbH
|
|
*
|
|
* @author Bart Visscher <bartv@thisnet.nl>
|
|
* @author Joas Schilling <coding@schilljs.com>
|
|
* @author Morris Jobke <hey@morrisjobke.de>
|
|
* @author Robin McCorkell <robin@mccorkell.me.uk>
|
|
* @author Thomas Müller <thomas.mueller@tmit.eu>
|
|
*
|
|
* @license AGPL-3.0
|
|
*
|
|
* This code is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*
|
|
*/
|
|
|
|
namespace OC;
|
|
|
|
use OC\App\AppManager;
|
|
use OC\Group\Manager;
|
|
use OCP\App\IAppManager;
|
|
use OCP\IConfig;
|
|
use OCP\IGroupManager;
|
|
use OCP\INavigationManager;
|
|
use OCP\IURLGenerator;
|
|
use OCP\IUserSession;
|
|
use OCP\L10N\IFactory;
|
|
|
|
/**
|
|
* Manages the ownCloud navigation
|
|
*/
|
|
|
|
class NavigationManager implements INavigationManager {
|
|
protected $entries = [];
|
|
protected $closureEntries = [];
|
|
protected $activeEntry;
|
|
/** @var bool */
|
|
protected $init = false;
|
|
/** @var IAppManager|AppManager */
|
|
protected $appManager;
|
|
/** @var IURLGenerator */
|
|
private $urlGenerator;
|
|
/** @var IFactory */
|
|
private $l10nFac;
|
|
/** @var IUserSession */
|
|
private $userSession;
|
|
/** @var IGroupManager|Manager */
|
|
private $groupManager;
|
|
/** @var IConfig */
|
|
private $config;
|
|
|
|
public function __construct(IAppManager $appManager,
|
|
IURLGenerator $urlGenerator,
|
|
IFactory $l10nFac,
|
|
IUserSession $userSession,
|
|
IGroupManager $groupManager,
|
|
IConfig $config) {
|
|
$this->appManager = $appManager;
|
|
$this->urlGenerator = $urlGenerator;
|
|
$this->l10nFac = $l10nFac;
|
|
$this->userSession = $userSession;
|
|
$this->groupManager = $groupManager;
|
|
$this->config = $config;
|
|
}
|
|
|
|
/**
|
|
* Creates a new navigation entry
|
|
*
|
|
* @param array|\Closure $entry Array containing: id, name, order, icon and href key
|
|
* The use of a closure is preferred, because it will avoid
|
|
* loading the routing of your app, unless required.
|
|
* @return void
|
|
*/
|
|
public function add($entry) {
|
|
if ($entry instanceof \Closure) {
|
|
$this->closureEntries[] = $entry;
|
|
return;
|
|
}
|
|
|
|
$entry['active'] = false;
|
|
if(!isset($entry['icon'])) {
|
|
$entry['icon'] = '';
|
|
}
|
|
if(!isset($entry['type'])) {
|
|
$entry['type'] = 'link';
|
|
}
|
|
$this->entries[] = $entry;
|
|
}
|
|
|
|
/**
|
|
* returns all the added Menu entries
|
|
* @param string $type
|
|
* @return array an array of the added entries
|
|
*/
|
|
public function getAll($type = 'link') {
|
|
$this->init();
|
|
foreach ($this->closureEntries as $c) {
|
|
$this->add($c());
|
|
}
|
|
$this->closureEntries = array();
|
|
|
|
if ($type === 'all') {
|
|
return $this->entries;
|
|
}
|
|
|
|
return array_filter($this->entries, function($entry) use ($type) {
|
|
return $entry['type'] === $type;
|
|
});
|
|
}
|
|
|
|
/**
|
|
* removes all the entries
|
|
*/
|
|
public function clear($loadDefaultLinks = true) {
|
|
$this->entries = [];
|
|
$this->closureEntries = [];
|
|
$this->init = !$loadDefaultLinks;
|
|
}
|
|
|
|
/**
|
|
* Sets the current navigation entry of the currently running app
|
|
* @param string $id of the app entry to activate (from added $entry)
|
|
*/
|
|
public function setActiveEntry($id) {
|
|
$this->activeEntry = $id;
|
|
}
|
|
|
|
/**
|
|
* gets the active Menu entry
|
|
* @return string id or empty string
|
|
*
|
|
* This function returns the id of the active navigation entry (set by
|
|
* setActiveEntry
|
|
*/
|
|
public function getActiveEntry() {
|
|
return $this->activeEntry;
|
|
}
|
|
|
|
private function init() {
|
|
if ($this->init) {
|
|
return;
|
|
}
|
|
$this->init = true;
|
|
|
|
$l = $this->l10nFac->get('lib');
|
|
if ($this->config->getSystemValue('knowledgebaseenabled', true)) {
|
|
$this->add([
|
|
'type' => 'settings',
|
|
'id' => 'help',
|
|
'order' => 5,
|
|
'href' => $this->urlGenerator->linkToRoute('settings_help'),
|
|
'name' => $l->t('Help'),
|
|
'icon' => $this->urlGenerator->imagePath('settings', 'help.svg'),
|
|
]);
|
|
}
|
|
|
|
if ($this->userSession->isLoggedIn()) {
|
|
if ($this->isAdmin()) {
|
|
// App management
|
|
$this->add([
|
|
'type' => 'settings',
|
|
'id' => 'core_apps',
|
|
'order' => 3,
|
|
'href' => $this->urlGenerator->linkToRoute('settings.AppSettings.viewApps'),
|
|
'icon' => $this->urlGenerator->imagePath('settings', 'apps.svg'),
|
|
'name' => $l->t('Apps'),
|
|
]);
|
|
}
|
|
|
|
// Personal and (if applicable) admin settings
|
|
$this->add([
|
|
'type' => 'settings',
|
|
'id' => 'settings',
|
|
'order' => 1,
|
|
'href' => $this->urlGenerator->linkToRoute('settings.PersonalSettings.index'),
|
|
'name' => $l->t('Settings'),
|
|
'icon' => $this->urlGenerator->imagePath('settings', 'admin.svg'),
|
|
]);
|
|
|
|
$logoutUrl = \OC_User::getLogoutUrl();
|
|
if($logoutUrl !== '') {
|
|
// Logout
|
|
$this->add([
|
|
'type' => 'settings',
|
|
'id' => 'logout',
|
|
'order' => 99999,
|
|
'href' => $logoutUrl,
|
|
'name' => $l->t('Log out'),
|
|
'icon' => $this->urlGenerator->imagePath('core', 'actions/logout.svg'),
|
|
]);
|
|
}
|
|
|
|
if ($this->isSubadmin()) {
|
|
// User management
|
|
$this->add([
|
|
'type' => 'settings',
|
|
'id' => 'core_users',
|
|
'order' => 4,
|
|
'href' => $this->urlGenerator->linkToRoute('settings_users'),
|
|
'name' => $l->t('Users'),
|
|
'icon' => $this->urlGenerator->imagePath('settings', 'users.svg'),
|
|
]);
|
|
}
|
|
}
|
|
|
|
if ($this->appManager === 'null') {
|
|
return;
|
|
}
|
|
|
|
if ($this->userSession->isLoggedIn()) {
|
|
$apps = $this->appManager->getEnabledAppsForUser($this->userSession->getUser());
|
|
} else {
|
|
$apps = $this->appManager->getInstalledApps();
|
|
}
|
|
|
|
foreach ($apps as $app) {
|
|
if (!$this->userSession->isLoggedIn() && !$this->appManager->isEnabledForUser($app, $this->userSession->getUser())) {
|
|
continue;
|
|
}
|
|
|
|
// load plugins and collections from info.xml
|
|
$info = $this->appManager->getAppInfo($app);
|
|
if (empty($info['navigations'])) {
|
|
continue;
|
|
}
|
|
foreach ($info['navigations'] as $nav) {
|
|
if (!isset($nav['name'])) {
|
|
continue;
|
|
}
|
|
if (!isset($nav['route'])) {
|
|
continue;
|
|
}
|
|
$role = isset($nav['@attributes']['role']) ? $nav['@attributes']['role'] : 'all';
|
|
if ($role === 'admin' && !$this->isAdmin()) {
|
|
continue;
|
|
}
|
|
$l = $this->l10nFac->get($app);
|
|
$id = isset($nav['id']) ? $nav['id'] : $app;
|
|
$order = isset($nav['order']) ? $nav['order'] : 100;
|
|
$type = isset($nav['type']) ? $nav['type'] : 'link';
|
|
$route = $this->urlGenerator->linkToRoute($nav['route']);
|
|
$icon = isset($nav['icon']) ? $nav['icon'] : 'app.svg';
|
|
foreach ([$icon, "$app.svg"] as $i) {
|
|
try {
|
|
$icon = $this->urlGenerator->imagePath($app, $i);
|
|
break;
|
|
} catch (\RuntimeException $ex) {
|
|
// no icon? - ignore it then
|
|
}
|
|
}
|
|
if ($icon === null) {
|
|
$icon = $this->urlGenerator->imagePath('core', 'default-app-icon');
|
|
}
|
|
|
|
$this->add([
|
|
'id' => $id,
|
|
'order' => $order,
|
|
'href' => $route,
|
|
'icon' => $icon,
|
|
'type' => $type,
|
|
'name' => $l->t($nav['name']),
|
|
]);
|
|
}
|
|
}
|
|
}
|
|
|
|
private function isAdmin() {
|
|
$user = $this->userSession->getUser();
|
|
if ($user !== null) {
|
|
return $this->groupManager->isAdmin($user->getUID());
|
|
}
|
|
return false;
|
|
}
|
|
|
|
private function isSubadmin() {
|
|
$user = $this->userSession->getUser();
|
|
if ($user !== null) {
|
|
return $this->groupManager->getSubAdmin()->isSubAdmin($user);
|
|
}
|
|
return false;
|
|
}
|
|
}
|