upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-24 11:24:37 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
nextcloud/tests
History
Lukas Reschke a04feff9a7
Properly allow \OCP\Authentication\IApacheBackend to specify logout URL 
Any `\OCP\Authentication\IApacheBackend` previously had to implement `getLogoutAttribute` which returns a string.
This string is directly injected into the logout `<a>` tag, so returning something like `href="foo"` would result
in `<a href="foo">`.

This is rather error prone and also in Nextcloud 12 broken as the logout entry has been moved with
054e161eb5 inside the navigation manager where one cannot simply inject attributes.

Thus this feature is broken in Nextcloud 12 which effectively leads to the bug described at nextcloud/user_saml#112,
people cannot logout anymore when using SAML using SLO. Basically in case of SAML you have a SLO url which redirects
you to the IdP and properly logs you out there as well.

Instead of monkey patching the Navigation manager I decided to instead change `\OCP\Authentication\IApacheBackend` to
use `\OCP\Authentication\IApacheBackend::getLogoutUrl` instead where it can return a string with the appropriate logout
URL. Since this functionality is only prominently used in the SAML plugin. Any custom app would need a small change but
I'm not aware of any and there's simply no way to fix this properly otherwise.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-08-18 12:22:44 +02:00
..
acceptance Add acceptance tests for setting the color in the Theming app 2017-08-10 12:37:57 +02:00
apps Version and dependency are now required 2017-05-22 09:54:44 +02:00
Core Properly allow \OCP\Authentication\IApacheBackend to specify logout URL 2017-08-18 12:22:44 +02:00
data Remove windows config settings in tests 2017-08-17 09:39:49 +02:00
docker Namespace and array syntax fixes 2017-03-19 14:52:54 -06:00
lib Properly allow \OCP\Authentication\IApacheBackend to specify logout URL 2017-08-18 12:22:44 +02:00
objectstore make object prefix configurable 2016-11-14 15:10:56 +01:00
Settings Update the URLs in tests to use example.org 2017-08-01 11:16:04 +02:00
travis Changed name of default logfile from owncloud.log to nextcloud.log. 2016-07-04 11:50:32 +02:00
apps.php Fix the tests again 2016-05-25 16:51:02 +02:00
bootstrap.php unit test adjustment 2017-04-07 18:06:50 +08:00
enable_all.php Fix tests 2016-10-31 17:17:45 +01:00
karma.config.js Extract toggle visibility of a SystemTagsInfoView to its own view 2017-06-09 09:13:29 +02:00
phpunit-autotest-external.xml Adjust the phpunit config 2016-05-25 15:14:37 +02:00
phpunit-autotest.xml Add tests for OAuth2 app 2017-05-18 20:49:10 +02:00
preseed-config.php Enable object storage tests again 2017-08-17 09:40:12 +02:00
redis-cluster.config.php Fix drone 2017-07-14 15:04:18 +02:00
redis.config.php Fix drone 2017-07-14 15:04:18 +02:00
startsessionlistener.php Make compatible with PHPUnit 5.1 2015-12-10 09:22:41 +01:00