nextcloud/core/src
Rodrigo Mendes Correia b7ebec6304
fix: #57282: icon color mismatch on download button in public share
The download button icon on the public share page always appeared
in the opposite color of the button text. The root cause was the
wrong CSS variable for the filter applied to the icon.

Background-image icons are dark (black) by default. In light mode,
the icon must be inverted to white when the primary color is dark,
which requires --primary-invert-if-dark. The code was incorrectly
using --primary-invert-if-bright, inverting in the wrong direction.

In dark mode, icons.css swaps the icon variables so that
--icon-download-dark resolves to the white SVG. The filter logic
must be reversed: --primary-invert-if-bright is needed to invert
the white icon to black when the primary color is bright.

Fix by using --primary-invert-if-dark in light mode and
--primary-invert-if-bright in dark mode, handling both the
prefers-color-scheme media query and the Nextcloud data-themes
attribute for explicit theme selection.

Signed-off-by: Rodrigo Mendes Correia <rodrigo.mendes.correia@tecnico.ulisboa.pt>
2026-06-11 11:48:37 +02:00
..
components fix(core): keep app menu settings icon legible on light backgrounds 2026-06-10 12:29:23 +00:00
mixins chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
OC chore!(core): remove deprecated Handlebars globals 2026-04-24 07:46:38 +02:00
OCA chore: Add SPDX header 2024-05-13 17:41:36 +02:00
OCP chore(legacy): fix @stylistic/exp-list-style ESLint rule 2026-01-26 00:05:29 +01:00
services fix: Add support for AscDesktopEditor browser user agent 2026-01-28 18:28:01 +01:00
store fix: Use searchFrom property for client side plugins 2025-01-30 17:35:00 +00:00
tests fix: tests 2026-06-02 11:46:57 +00:00
types feat: provide api to register actions in contacts menu 2025-08-19 09:17:44 +08:00
Util chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
utils fix(core): use btoa() instead of window.Buffer.from() for base64 encoding 2026-05-04 19:48:19 +02:00
views fix: #57282: icon color mismatch on download button in public share 2026-06-11 11:48:37 +02:00
ajax-cron.ts chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
eventbus.d.ts feat(core): app menu waffle launcher 2026-05-07 19:25:15 +02:00
globals.js chore!(core): remove deprecated Handlebars globals 2026-04-24 07:46:38 +02:00
init.js chore!(core): remove global snapper.js handling 2026-02-17 12:50:49 +01:00
install.ts chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
legacy-unified-search.js chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
logger.js chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
login-flow.ts refactor(core): migrate login flow ui from jQuery to Vue 2026-01-14 01:15:01 +01:00
login.js chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
main.js chore!(core): remove deprecated jQuery and jQuery UI 2026-02-17 12:51:42 +01:00
maintenance.js chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
public-page-menu.ts chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
public-page-user-menu.ts chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
public-share-auth.ts chore: fix or ignore linter issues 2026-01-15 23:30:21 +01:00
public.ts fix: Fix inaccessible content on public pages due to overlapping footer 2024-09-05 16:19:22 -07:00
recommendedapps.js fix(core): prompt for password once when installing recommended apps 2026-05-06 13:25:52 +02:00
session-heartbeat.ts chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
twofactor-request-token.ts fix: update request token on two-factor pages 2025-06-23 11:20:09 +02:00
unified-search.ts chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
unsupported-browser-redirect.js chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
unsupported-browser.js chore: adjust code to new codestyle 2025-10-02 13:19:42 +02:00
update.ts refactor(core): migrate web updater to Vue 2026-01-16 00:29:19 +01:00