nextcloud/apps/files_sharing
Anna Larch 9af4a2bb5a fix(sharing): restore STATUS_ACCEPTED for OC-migrated group share subshares
When an ownCloud-migrated group share (which has no per-user USERGROUP
subshare) is renamed for the first time, DefaultShareProvider::move()
inserted a new USERGROUP row without setting `accepted`. The column
defaulted to 0 (STATUS_PENDING), causing MountProvider to skip the
share on the next login — the shared file disappeared for the recipient.

Fix: set accepted = STATUS_ACCEPTED explicitly on the INSERT in
DefaultShareProvider::move() for the TYPE_GROUP branch.

Secondary fix: SharedMount::moveMount() silently returned true when
updateFileTarget() threw (e.g. group no longer exists on an OC-migrated
instance). Set $result = false in the catch block so View::rename()
propagates the failure instead of silently corrupting VFS state.

An opt-in occ command (sharing:fix-owncloud-group-shares) with --dry-run
support is included to repair existing broken instances. It targets only
TYPE_USERGROUP subshares with accepted=STATUS_PENDING and permissions!=0
(shares that were accepted but broken by the missing column default),
leaving explicitly declined shares (permissions=0) untouched.

AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
2026-06-02 09:14:34 +00:00
..
appinfo fix(sharing): restore STATUS_ACCEPTED for OC-migrated group share subshares 2026-06-02 09:14:34 +00:00
composer fix(sharing): restore STATUS_ACCEPTED for OC-migrated group share subshares 2026-06-02 09:14:34 +00:00
css chore(files_sharing): remove leftover of legacy files ui 2025-07-31 21:09:43 +02:00
img chore: Make app icons consistent Material Symbols with same settings 2024-07-10 15:53:45 +02:00
l10n fix(l10n): Update translations from Transifex 2026-05-27 00:23:28 +00:00
lib fix(sharing): restore STATUS_ACCEPTED for OC-migrated group share subshares 2026-06-02 09:14:34 +00:00
src Merge pull request #60508 from nextcloud/backport/60378/stable34 2026-05-20 15:24:50 +02:00
templates chore(files_sharing): remove leftover of legacy files ui 2025-07-31 21:09:43 +02:00
tests fix(sharing): restore STATUS_ACCEPTED for OC-migrated group share subshares 2026-06-02 09:14:34 +00:00
.l10nignore chore: Add SPDX header 2024-06-02 20:00:00 +02:00
openapi.json chore: update openapi 2026-04-21 19:13:53 +02:00
openapi.json.license chore: Add SPDX header 2024-06-02 20:00:00 +02:00