upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-18 05:00:03 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 15
nextcloud/apps/files/src/actions
History
Szymon Kłos ea899d2327 fix(files): Do not fail on missing sidebar in files list 
When using richdocuments it was failing in case of shared links
or when user with opened file did a wheel click on a refresh page.
Then new tab appeared but instead opening the file it was doing
nothing (showing the list of files) or downloading the file.

Make code more defensive. I found these logs while debugging:
OCA.Files.Settings initialized
Sidebar.js:19 OCA.Files.Sidebar initialized
ShareSearch.js:16 OCA.Sharing.ShareSearch initialized
comments-app.js:15 OCA.Comments.View initialized
index.mjs:54 files: Error while opening sidebar Object
log @ index.mjs:54
index.mjs:54 files: Error while opening sidebar Objectapp: "files"
TypeError: window.OCA.Files.Sidebar.open is not a function
    at h.exec (http://nc/dist/files-main.js?v=106d16db-0:1:70123)
    at o.openSidebarForFile (http://nc/dist/files-main.js?v=106d16db-0:1:163422)
    at o.handleOpenQueries (http://nc/dist/files-main.js?v=106d16db-0:1:163167)
    at o.openDetails (http://nc/dist/files-main.js?v=106d16db-0:1:162349)
    at fn (http://nc/dist/core-common.js?v=106d16db-0:1:3942538)
    at e.run (http://nc/dist/core-common.js?v=106d16db-0:1:3946900)
    at sa (http://nc/dist/core-common.js?v=106d16db-0:1:3948728)
    at Array.<anonymous> (http://nc/dist/core-common.js?v=106d16db-0:1:3943585)
    at bn (http://nc/dist/core-common.js?v=106d16db-0:1:3942986)level: 2uid: "admin"
       [[Prototype]]: Object
log @ index.mjs:54

Possibly regression from
e7001022c7

Fixes https://github.com/nextcloud/richdocuments/issues/3815

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2025-11-30 18:26:00 +00:00
..
convertAction.ts fix(files): properly update store on files conversions success 2025-02-04 16:46:46 +00:00
convertUtils.ts chore(i18n): Fixed plural strings 2025-11-06 17:00:37 +00:00
deleteAction.spec.ts feat(files_trashbin): Allow preventing trash to be deleted permanently 2025-01-13 15:19:19 +01:00
deleteAction.ts fix(files): also enable delete action if trashbin is disabled 2025-03-13 21:30:43 +01:00
deleteUtils.ts fix(files): improve delete display name when trashbin is disabled 2024-11-19 11:21:46 +01:00
downloadAction.spec.ts fix(files): verify files are still accessible before downloading 2025-08-29 07:26:05 +00:00
downloadAction.ts fix(files): verify files are still accessible before downloading 2025-08-29 07:26:05 +00:00
editLocallyAction.spec.ts chore: Resolve ESLint warnings 2025-01-16 22:18:29 +01:00
editLocallyAction.ts fix(files): use isDownloadable for isSyncable 2025-11-28 09:54:02 +01:00
favoriteAction.spec.ts test: Migrated all Jest tests to vitest 2024-08-26 17:27:22 +02:00
favoriteAction.ts feat(files): add hotkey service and unify action handling 2024-12-17 09:59:57 +01:00
moveOrCopyAction.ts fix(FilesPicker): Prevent selection of nodes without create permission 2025-10-22 18:13:05 +02:00
moveOrCopyActionUtils.ts fix(files): Do not allow copy action on public shares without create permission 2024-09-06 03:38:47 +02:00
openFolderAction.spec.ts test: Migrated all Jest tests to vitest 2024-08-26 17:27:22 +02:00
openFolderAction.ts chore(deps): Update @nextcloud/files to v3.6.0 2024-07-25 01:24:26 +02:00
openInFilesAction.spec.ts test: Migrated all Jest tests to vitest 2024-08-26 17:27:22 +02:00
openInFilesAction.ts chore(files): Fix ESLint issues with files and files_sharing app 2024-07-09 17:25:41 +02:00
renameAction.spec.ts fix: adapt rename action tests to check for parent permissions 2025-07-11 17:24:15 +02:00
renameAction.ts fix(files): allow renaming if parent allow creating 2025-07-11 14:41:47 +00:00
sidebarAction.spec.ts feat(files): add opendetails param and file list up/down keyboard shortcut 2024-12-17 09:59:56 +01:00
sidebarAction.ts fix(files): Do not fail on missing sidebar in files list 2025-11-30 18:26:00 +00:00
viewInFolderAction.spec.ts fix(files): check that node is in user root folder for view-in-folder action 2024-11-09 11:34:59 +01:00
viewInFolderAction.ts fix(files): check that node is in user root folder for view-in-folder action 2024-11-09 11:34:59 +01:00