mirror of
https://github.com/nextcloud/server.git
synced 2026-02-03 20:41:22 -05:00
To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
169 lines
4.6 KiB
PHP
169 lines
4.6 KiB
PHP
<?php
|
|
/**
|
|
* Copyright (c) 2014 Vincent Petry <pvince81@owncloud.com>
|
|
* This file is licensed under the Affero General Public License version 3 or
|
|
* later.
|
|
* See the COPYING-README file.
|
|
*/
|
|
|
|
namespace Test;
|
|
|
|
/**
|
|
* Tests for server check functions
|
|
*
|
|
* @group DB
|
|
*/
|
|
class UtilCheckServerTest extends \Test\TestCase {
|
|
private $datadir;
|
|
|
|
/**
|
|
* @param array $systemOptions
|
|
* @return \OC\SystemConfig | \PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
protected function getConfig($systemOptions) {
|
|
$systemOptions['datadirectory'] = $this->datadir;
|
|
$systemOptions['appstoreenabled'] = false; //it's likely that there is no app folder we can write in
|
|
$config = $this->getMockBuilder('\OC\SystemConfig')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$config->expects($this->any())
|
|
->method('getValue')
|
|
->willReturnCallback(function ($key, $default) use ($systemOptions) {
|
|
return isset($systemOptions[$key]) ? $systemOptions[$key] : $default;
|
|
});
|
|
return $config;
|
|
}
|
|
|
|
protected function setUp(): void {
|
|
parent::setUp();
|
|
|
|
$this->datadir = \OC::$server->getTempManager()->getTemporaryFolder();
|
|
|
|
file_put_contents($this->datadir . '/.ocdata', '');
|
|
\OC::$server->getSession()->set('checkServer_succeeded', false);
|
|
}
|
|
|
|
protected function tearDown(): void {
|
|
// clean up
|
|
@unlink($this->datadir . '/.ocdata');
|
|
parent::tearDown();
|
|
}
|
|
|
|
/**
|
|
* Test that checkServer() returns no errors in the regular case.
|
|
*/
|
|
public function testCheckServer() {
|
|
$result = \OC_Util::checkServer($this->getConfig([
|
|
'installed' => true
|
|
]));
|
|
$this->assertEmpty($result);
|
|
}
|
|
|
|
/**
|
|
* Test that checkServer() does not check the data dir validity
|
|
* when the server is not installed yet (else the setup cannot
|
|
* be run...)
|
|
*/
|
|
public function testCheckServerSkipDataDirValidityOnSetup() {
|
|
// simulate old version that didn't have it
|
|
unlink($this->datadir . '/.ocdata');
|
|
|
|
// even though ".ocdata" is missing, the error isn't
|
|
// triggered to allow setup to run
|
|
$result = \OC_Util::checkServer($this->getConfig([
|
|
'installed' => false
|
|
]));
|
|
$this->assertEmpty($result);
|
|
}
|
|
|
|
/**
|
|
* Test that checkServer() does not check the data dir validity
|
|
* when an upgrade is required (else the upgrade cannot be
|
|
* performed...)
|
|
*/
|
|
public function testCheckServerSkipDataDirValidityOnUpgrade() {
|
|
// simulate old version that didn't have it
|
|
unlink($this->datadir . '/.ocdata');
|
|
|
|
$session = \OC::$server->getSession();
|
|
$oldCurrentVersion = $session->get('OC_Version');
|
|
|
|
// upgrade condition to simulate needUpgrade() === true
|
|
$session->set('OC_Version', [6, 0, 0, 2]);
|
|
|
|
// even though ".ocdata" is missing, the error isn't
|
|
// triggered to allow for upgrade
|
|
$result = \OC_Util::checkServer($this->getConfig([
|
|
'installed' => true,
|
|
'version' => '6.0.0.1'
|
|
]));
|
|
$this->assertEmpty($result);
|
|
|
|
// restore versions
|
|
$session->set('OC_Version', $oldCurrentVersion);
|
|
}
|
|
|
|
/**
|
|
* Test that checkDataDirectoryValidity returns no error
|
|
* when ".ocdata" is present.
|
|
*/
|
|
public function testCheckDataDirValidity() {
|
|
$result = \OC_Util::checkDataDirectoryValidity($this->datadir);
|
|
$this->assertEmpty($result);
|
|
}
|
|
|
|
/**
|
|
* Test that checkDataDirectoryValidity and checkServer
|
|
* both return an error when ".ocdata" is missing.
|
|
*/
|
|
public function testCheckDataDirValidityWhenFileMissing() {
|
|
unlink($this->datadir . '/.ocdata');
|
|
$result = \OC_Util::checkDataDirectoryValidity($this->datadir);
|
|
$this->assertEquals(1, count($result));
|
|
|
|
$result = \OC_Util::checkServer($this->getConfig([
|
|
'installed' => true,
|
|
'version' => implode('.', \OCP\Util::getVersion())
|
|
]));
|
|
$this->assertCount(1, $result);
|
|
}
|
|
|
|
/**
|
|
* Tests that no error is given when the datadir is writable
|
|
*/
|
|
public function testDataDirWritable() {
|
|
$result = \OC_Util::checkServer($this->getConfig([
|
|
'installed' => true,
|
|
'version' => implode('.', \OCP\Util::getVersion())
|
|
]));
|
|
$this->assertEmpty($result);
|
|
}
|
|
|
|
/**
|
|
* Tests an error is given when the datadir is not writable
|
|
*/
|
|
public function testDataDirNotWritable() {
|
|
$this->markTestSkipped('TODO: Disable because fails on drone');
|
|
|
|
chmod($this->datadir, 0300);
|
|
$result = \OC_Util::checkServer($this->getConfig([
|
|
'installed' => true,
|
|
'version' => implode('.', \OCP\Util::getVersion())
|
|
]));
|
|
$this->assertCount(1, $result);
|
|
}
|
|
|
|
/**
|
|
* Tests no error is given when the datadir is not writable during setup
|
|
*/
|
|
public function testDataDirNotWritableSetup() {
|
|
chmod($this->datadir, 0300);
|
|
$result = \OC_Util::checkServer($this->getConfig([
|
|
'installed' => false,
|
|
'version' => implode('.', \OCP\Util::getVersion())
|
|
]));
|
|
chmod($this->datadir, 0700); //needed for cleanup
|
|
$this->assertEmpty($result);
|
|
}
|
|
}
|