mirror of
https://github.com/nextcloud/server.git
synced 2026-02-19 02:38:40 -05:00
f0e020f97d
Currently apps are broken if they have exports in the JS entry point,
because they then will import from the entry point but because they do
not know about the Nextcloud cache buster they will import without cache
buster.
This results in two problem:
1. The module might be outdated (old cached)
2. The module is duplicated, so the module will be loaded twice and will
have two different - out of sync - states. This also means it will
re-run sideeffects of the entry point.
To fix this we generate an import map which basically maps the plain
entry point script to the script with cache buster added.
(Some background: Bundler will try to minimize chunks (reduce page
loading time) so they can inline modules into entry points and thus
extend the entry point exports and then this issue would be caused).
For example:
```js
// entry.mjs
console.error('called')
async function onClick() {
await import('./chunk.mjs')
}
export const name = 'foo'
// chunk.mjs
import { name } from './entry.mjs'
console.error(name)
```
When calling `onClick` without this fix the output will be:
> called
> called
> foo
With this fix:
> called
> foo
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
||
|---|---|---|
| .. | ||
| Base.php | ||
| CSSResourceLocator.php | ||
| functions.php | ||
| JSCombiner.php | ||
| JSConfigHelper.php | ||
| JSResourceLocator.php | ||
| ResourceLocator.php | ||
| ResourceNotFoundException.php | ||
| Template.php | ||
| TemplateFileLocator.php | ||
| TemplateManager.php | ||