From fe7b161bb2a7fc8f03bf0aef4604e6b79c5cd6d8 Mon Sep 17 00:00:00 2001 From: Quanah Gibson-Mount Date: Wed, 20 Jan 2021 23:41:22 +0000 Subject: [PATCH] ITS#9440 - Don't set control to NULL before it's used for output. --- clients/tools/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/tools/common.c b/clients/tools/common.c index a22949720b..1395e69a4a 100644 --- a/clients/tools/common.c +++ b/clients/tools/common.c @@ -730,8 +730,6 @@ tool_args( int argc, char **argv ) } unknown_ctrls = tmpctrls; ctrl.ldctl_oid = control; - /* don't free it */ - control = NULL; ctrl.ldctl_value.bv_val = NULL; ctrl.ldctl_value.bv_len = 0; ctrl.ldctl_iscritical = crit; @@ -758,6 +756,8 @@ tool_args( int argc, char **argv ) ctrl.ldctl_value = bv; } + /* don't free it */ + control = NULL; unknown_ctrls[ unknown_ctrls_num ] = ctrl; unknown_ctrls_num++;