mirror of
https://github.com/opentofu/opentofu.git
synced 2026-05-21 17:47:24 -04:00
a800d250e5
Some checks are pending
build / Build for freebsd_386 (push) Waiting to run
build / Build for linux_386 (push) Waiting to run
build / Build for openbsd_386 (push) Waiting to run
build / Build for windows_386 (push) Waiting to run
build / Build for freebsd_amd64 (push) Waiting to run
build / Build for linux_amd64 (push) Waiting to run
build / Build for openbsd_amd64 (push) Waiting to run
build / Build for solaris_amd64 (push) Waiting to run
build / Build for windows_amd64 (push) Waiting to run
build / Build for freebsd_arm (push) Waiting to run
build / Build for linux_arm (push) Waiting to run
build / Build for linux_arm64 (push) Waiting to run
build / Build for darwin_amd64 (push) Waiting to run
build / Build for darwin_arm64 (push) Waiting to run
build / End-to-end Tests for linux_386 (push) Waiting to run
build / End-to-end Tests for windows_386 (push) Waiting to run
build / End-to-end Tests for darwin_amd64 (push) Waiting to run
build / End-to-end Tests for linux_amd64 (push) Waiting to run
build / End-to-end Tests for windows_amd64 (push) Waiting to run
Quick Checks / List files changed for pull request (push) Waiting to run
Quick Checks / Unit tests for linux_386 (push) Blocked by required conditions
Quick Checks / Unit tests for linux_amd64 (push) Blocked by required conditions
Quick Checks / Unit tests for windows_amd64 (push) Blocked by required conditions
Quick Checks / Unit tests for linux_arm (push) Blocked by required conditions
Quick Checks / Unit tests for darwin_arm64 (push) Blocked by required conditions
Quick Checks / Unit tests for linux_arm64 (push) Blocked by required conditions
Quick Checks / Race Tests (push) Blocked by required conditions
Quick Checks / End-to-end Tests (push) Blocked by required conditions
Quick Checks / Code Consistency Checks (push) Blocked by required conditions
Quick Checks / License Checks (push) Waiting to run
Website checks / List files changed for pull request (push) Waiting to run
Website checks / Build (push) Blocked by required conditions
Website checks / Test Installation Instructions (push) Blocked by required conditions
We don't typically just broadly run automatic rewriting tools like "go fix" across our codebase because that tends to cause annoying and unnecessary merge conflicts when we're backporting to earlier release branches. But all of the files in this commit were changed in some non-trivial way already during the OpenTofu v1.11 development period anyway, and so the likelyhood we'd be able to successfully backport from them is reduced and therefore this seems like a good opportunity to do some focused modernization using "go fix". My rules for what to include or not are admittedly quite "vibes-based", but the general idea was: - Focusing on files under the "command" directory only, because that's already been an area of intentional refactoring during this development period. - If the existing diff in a file is already significantly larger than the changes the fixer proposed to make, or if the fixer is proposing to change a line that was already changed in this development period. - More willing to include "_test.go" files than non-test files, even if they hadn't changed as much already, just because backports from test files for bug fixes tend to be entirely new test cases more than they are modifications to existing test cases, and so the risk of conflicts is lower there. Signed-off-by: Martin Atkins <mart@degeneration.co.uk> |
||
|---|---|---|
| .. | ||
| json | ||
| jsonfunction | ||
| testdata | ||
| apply.go | ||
| apply_test.go | ||
| console.go | ||
| console_test.go | ||
| fmt.go | ||
| fmt_test.go | ||
| get.go | ||
| get_test.go | ||
| graph.go | ||
| graph_test.go | ||
| hook_count.go | ||
| hook_count_test.go | ||
| hook_json.go | ||
| hook_json_test.go | ||
| hook_module_install.go | ||
| hook_module_install_test.go | ||
| hook_ui.go | ||
| hook_ui_test.go | ||
| import.go | ||
| import_test.go | ||
| init.go | ||
| init_test.go | ||
| json_view.go | ||
| json_view_test.go | ||
| login.go | ||
| login_test.go | ||
| logout.go | ||
| logout_test.go | ||
| metadata_functions.go | ||
| metadata_functions_test.go | ||
| operation.go | ||
| operation_test.go | ||
| output.go | ||
| output_test.go | ||
| plan.go | ||
| plan_test.go | ||
| providers.go | ||
| providers_lock.go | ||
| providers_lock_test.go | ||
| providers_mirror.go | ||
| providers_mirror_test.go | ||
| providers_test.go | ||
| refresh.go | ||
| refresh_test.go | ||
| show.go | ||
| show_test.go | ||
| state.go | ||
| state_locker.go | ||
| state_test.go | ||
| taint.go | ||
| taint_test.go | ||
| test.go | ||
| test_test.go | ||
| unlock.go | ||
| unlock_test.go | ||
| validate.go | ||
| validate_test.go | ||
| version.go | ||
| version_test.go | ||
| view.go | ||
| view_test.go | ||
| view_ui.go | ||
| view_ui_test.go | ||
| views.go | ||
| workspace.go | ||
| workspace_test.go | ||