mirror of
https://github.com/OpenVPN/openvpn.git
synced 2026-05-20 00:45:58 -04:00
fcc34b1352
cppcheck complained about a potential memleak due to realloc failure. But trying to handle that is probably not useful. Just abort like we do for other malloc failures. Change-Id: Icd8ea093dfe9f1888570f3d7b786b951b5262e47 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> Acked-by: Gert Doering <gert@greenie.muc.de> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1669 Message-Id: <20260507075321.25123-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36842.html Signed-off-by: Gert Doering <gert@greenie.muc.de>
89 lines
3.9 KiB
Text
89 lines
3.9 KiB
Text
# We start with --enable=all, but then suppress some issues that have too many
|
|
# occurences right now. They still should be fixed at some point
|
|
constParameter
|
|
constParameterCallback
|
|
constParameterPointer
|
|
constVariable
|
|
constVariablePointer
|
|
variableScope
|
|
# We have a lot of library includes, not all of them are really required,
|
|
# so ignore them
|
|
missingIncludeSystem
|
|
# cppcheck doesn't understand about check_malloc_return, so these are
|
|
# usually misleading
|
|
nullPointerOutOfMemory
|
|
nullPointerArithmeticOutOfMemory
|
|
# These are specific false-positives (FP) or ignored (IGN) issues
|
|
# We might want to move some of them to inline-suppression to avoid
|
|
# the static line-numbers
|
|
# IGN: multi code does weird things with pointers to local variables...
|
|
autoVariables:src/openvpn/multi.c:4177
|
|
autoVariables:src/openvpn/multi_io.c:280
|
|
# IGN: the code header = 0 | (OPCODE << P_OPCODE_SHIFT) is used intentionally
|
|
badBitmaskCheck:src/openvpn/mudp.c
|
|
badBitmaskCheck:tests/unit_tests/openvpn/test_pkt.c
|
|
# IGN: event code uses a pointer to store integers
|
|
intToPointerCast:src/openvpn/multi_io.c
|
|
intToPointerCast:src/openvpn/forward.c
|
|
# FP: crt_error is always true on Unix, but not Windows
|
|
knownConditionTrueFalse:src/openvpn/error.h:380
|
|
# FP: code needs to accomodate many different defines
|
|
knownConditionTrueFalse:src/openvpn/event.c:1148
|
|
# FP: dco_win support has "false" stubs
|
|
knownConditionTrueFalse:src/openvpn/forward.c
|
|
knownConditionTrueFalse:src/openvpn/init.c
|
|
knownConditionTrueFalse:src/openvpn/multi_io.c:163
|
|
# FP: cppcheck thinks that management_query_user_pass is always true,
|
|
# but no idea why
|
|
knownConditionTrueFalse:src/openvpn/misc.c:97
|
|
# FP: cert_uri_supported is a wrapper around defines, so it's
|
|
# always constant but differs depending on OpenSSL version
|
|
knownConditionTrueFalse:src/openvpn/ssl_openssl.c:1258
|
|
# FP: cppcheck doesn't understand that the function changes szErrMessage
|
|
knownConditionTrueFalse:src/tapctl/main.c:704
|
|
knownConditionTrueFalse:src/openvpnmsica/dllmain.c:164
|
|
# FP: cppcheck seems to be confused since we cast the pointer to integer
|
|
memleak:src/plugins/down-root/down-root.c:337
|
|
# IGN: we just abort instead
|
|
memleakOnRealloc:src/openvpn/dco_freebsd.c:845
|
|
# FP: eventmsg.h is not built on Unix
|
|
missingInclude:src/openvpnserv/common.c:25
|
|
# IGN: strlen(NULL) is not nice code, but seems to work
|
|
nullPointerRedundantCheck:src/openvpn/init.c:299
|
|
# IGN: We reuse the same variable name due to macro usage
|
|
shadowVariable:src/openvpn/options.c:2580
|
|
shadowVariable:src/openvpn/options.c:2598
|
|
# FP: yes, t_prev is unitialized, but t_prev_len is 0, so that's handled
|
|
uninitvar:src/openvpn/crypto_epoch.c:60
|
|
# FP: yes, parm is unitialized, but parm_len is 0, so that's handled
|
|
uninitvar:src/openvpn/options_parse.c:148
|
|
# FP: uninit is fine when it is a return parameter
|
|
ctuuninitvar:src/openvpn/crypto_mbedtls_legacy.c:698
|
|
uninitvar:src/openvpnserv/interactive.c:1935
|
|
uninitvar:src/tapctl/main.c:566
|
|
# FP: cppcheck doesn't account for short-circuiting
|
|
unreadVariable:src/openvpn/manage.c:682
|
|
unusedFunction:src/openvpn/siphash_reference.c
|
|
# FP: exported as DLL
|
|
unusedFunction:src/openvpnmsica/*.c
|
|
# FP: loaded as plugins
|
|
unusedFunction:src/plugins/*
|
|
unusedFunction:sample/sample-plugins/*
|
|
# FP: wmain
|
|
unusedFunction:src/tapctl/main.c:613
|
|
unusedFunction:tests/unit_tests/openvpnserv/test_openvpnserv.c
|
|
# IGN: keep mocking around for future use
|
|
unusedFunction:tests/unit_tests/openvpn/mock_msg.c
|
|
# FP: doesn't account for --wrap
|
|
unusedFunction:tests/unit_tests/openvpn/test_tls_crypt.c
|
|
unusedFunction:/usr/include/*
|
|
# IGN: old code that is difficult to test (MSG_ERRQUEUE), ignore for now
|
|
unusedStructMember:src/openvpn/mtu.c:281
|
|
# FP: used implictly by NL macros
|
|
unusedStructMember:src/openvpn/networking_sitnl.c
|
|
# IGN: keep explanatory fields in test data
|
|
unusedStructMember:tests/unit_tests/openvpn/test_pkcs11.c
|
|
# IGN: nicer to assign generic "arg" early
|
|
variableScope:src/openvpn/networking_sitnl.c:1390
|
|
# IGN: nicer to keep the "variable" earlier
|
|
variableScope:src/openvpnserv/interactive.c:2687
|