From 94d8a11f28a1f7f3f20ade4dcb34deeb57c2ed63 Mon Sep 17 00:00:00 2001 From: Monviech Date: Tue, 3 Feb 2026 13:56:44 +0100 Subject: [PATCH] Shuffle is_if condition around for clarity --- .../controllers/OPNsense/Firewall/Api/FilterController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php b/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php index b09b20af94..231daac7bf 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php @@ -163,8 +163,8 @@ class FilterController extends FilterBaseController } else { $is_if = array_intersect(explode(',', $record['interface'] ?? ''), $interfaces ?? []); } - // ALL interfaces always matches - $is_if = $interfaces === null || $is_if || empty($record['interface']); + // ALL interfaces or floating always matches + $is_if = $is_if || $interfaces === null || empty($record['interface']); if ($is_cat && $is_if) { /* translate/convert legacy fields before returning, similar to mvc handling */