upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-04-23 15:19:31 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

kern: mountroot: avoid fd leak in .md parsing

Browse source 
parse_dir_md() opens /dev/mdctl but only closes the resulting fd on
success, not upon failure of the ioctl or when we exceed the md unit
max.

Reviewed by:	kib (slightly previous version)
Sponsored by:	NetApp, Inc.
Sponsored by:	Klara, Inc.
X-NetApp-PR:	#62
Differential Revision:	https://reviews.freebsd.org/D31229
This commit is contained in:
Kyle Evans 2021-07-20 05:23:11 -05:00
parent fa46a46a82
commit 23ecfa9d5b
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
sys/kern/vfs_mountroot.c
View file

@ -580,6 +580,7 @@ parse_dir_md(char **conf)
int error, fd, len;
td = curthread;
fd = -1;
error = parse_token(conf, &tok);
if (error)
@ -635,9 +636,9 @@ parse_dir_md(char **conf)
root_mount_mddev = mdio->md_unit;
printf(MD_NAME "%u attached to %s\n", root_mount_mddev, mdio->md_file);
error = kern_close(td, fd);
out:
if (fd >= 0)
(void)kern_close(td, fd);
free(mdio, M_TEMP);
return (error);
}