From 87a5cb465000ff94fbdbcec92151e2d8ff3d8bbd Mon Sep 17 00:00:00 2001 From: Martin Matuska Date: Tue, 19 Mar 2013 07:47:51 +0000 Subject: [PATCH] Plug memory leak in dsl_check_snap_cb() This was unnoticed because the function is very rarely used. MFC after: 3 days --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c index b294ff02a98..9c735be5472 100644 --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c @@ -919,7 +919,8 @@ dsl_check_snap_cb(const char *name, void *arg) char *dsname; dsname = kmem_asprintf("%s@%s", name, da->snapname); - VERIFY(nvlist_add_boolean(da->nvl, dsname) == 0); + fnvlist_add_boolean(da->nvl, dsname); + kmem_free(dsname, strlen(dsname) + 1); return (0); }