upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-04-23 07:07:24 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

pmc: avoid potential race on shutdown

Browse source 
Clear shutdown flag first, conservatively allow 5ms for all hardclock consumers to
see flag before drainining
This commit is contained in:
Matt Macy 2018-05-20 19:35:24 +00:00
parent 6cff19a3be
commit f2daab2c8f
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
sys/dev/hwpmc/hwpmc_logging.c
View file

@ -872,18 +872,20 @@ pmclog_close(struct pmc_owner *po)
pmclog_process_closelog(po);
mtx_lock(&pmc_kthread_mtx);
/*
* Initiate shutdown: no new data queued,
* thread will close file on last block.
*/
po->po_flags |= PMC_PO_SHUTDOWN;
/* give time for all to see */
DELAY(50);
/*
* Schedule the current buffer.
*/
pmclog_schedule_all(po);
wakeup_one(po);
/*
* Initiate shutdown: no new data queued,
* thread will close file on last block.
*/
po->po_flags |= PMC_PO_SHUTDOWN;
mtx_unlock(&pmc_kthread_mtx);
return (0);