From fde05f986418ad174c8dd7cb8cadeb01ccc0c19e Mon Sep 17 00:00:00 2001 From: Dimitry Andric Date: Sat, 16 Jul 2022 21:19:51 +0200 Subject: [PATCH] Fix clang 15 warning in cxgbe Clang 15 warns: sys/dev/cxgbe/cudbg/cudbg_lib.c:2949:6: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable] int i = 0; ^ Apparently 'i' was meant as the current retry counter, but '1' was used in the while loop comparison instead, making the loop potentially infinite, if 'busy' never gets reset. MFC after: 3 days Reviewed by: np Differential Revision: https://reviews.freebsd.org/D35834 (cherry picked from commit fb0493d55998eeb9f062b15b40924ff722f3eba5) --- sys/dev/cxgbe/cudbg/cudbg_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/cudbg/cudbg_lib.c b/sys/dev/cxgbe/cudbg/cudbg_lib.c index dcbcb24807b..feded8e7586 100644 --- a/sys/dev/cxgbe/cudbg/cudbg_lib.c +++ b/sys/dev/cxgbe/cudbg/cudbg_lib.c @@ -2950,7 +2950,7 @@ static int check_busy_bit(struct adapter *padap) int retry = 10; int status = 0; - while (busy & (1 < retry)) { + while (busy && i < retry) { val = t4_read_reg(padap, A_CIM_HOST_ACC_CTRL); busy = (0 != (val & CUDBG_CIM_BUSY_BIT)); i++;