4 commits

Author	SHA1	Message	Date
Bryan Drewery	ea825d0274	DIRDEPS_BUILD: Update dependencies. ... Sponsored by: Dell EMC Isilon	2017-10-31 00:07:04 +00:00
Don Lewis	290dadbd56	Fix a (false positive?) Argument cannot be negative coverity defect. ... Rather than guarding close(fd) with an fd >= 0 test and setting fd to -1 when it is closed to avoid a potential double-close, just move the close() call after the conditional "goto make_token". This moves the close() call totally outside the loop to avoid the possibility of calling it twice. This should also prevent a Coverity warning about checking fd for validity after it was previously passed to read(). Reported by: Coverity CID: 1355335 MFC after: 1 week X-MFC with: r299484	2016-06-08 02:14:05 +00:00
Conrad Meyer	7bfdbca596	random(6): Fix double-close ... In the case where a file lacks a trailing newline, there is some "evil" code to reverse goto the tokenizing code ("make_token") for the final token in the file. In this case, 'fd' is closed more than once. Use a negative sentinel value to guard close(2), preventing the double close. Ideally, this code would be restructured to avoid this ugly construction. Reported by: Coverity CID: 1006123 Sponsored by: EMC / Isilon Storage Division	2016-05-11 22:04:28 +00:00
Colin Percival	6ae1554a5d	Final step of eliminating the "games" distribution: Merge src/games ... (or what's left of it, at least) into src/usr.bin. This change will not be MFCed. Discussed at: EuroBSDCon 2014 Committed from: EuroBSDCon 2015	2015-10-02 10:08:11 +00:00