Commit graph

541 commits

Author SHA1 Message Date
Warner Losh
db761c6a64 Create wrapper for Giant taken for newbus
Create a wrapper for newbus to take giant and for busses to take it too.
bus_topo_lock() should be called before interacting with newbus routines
and unlocked with bus_topo_unlock(). If you need the topology lock for
some reason, bus_topo_mtx() will provide that.

Sponsored by:		Netflix
Reviewed by:		mav
Differential Revision:	https://reviews.freebsd.org/D31831

(cherry picked from commit c6df6f5322)
2022-06-21 17:13:20 +02:00
Hans Petter Selasky
492f5e6494 mlx5ib: Fix memory leak in clean_mr() error path
In the clean_mr() error path the 'mr' should be freed.

Linux commit:
5942d8ae411775b76e5e1ab0cce57b0666516f2d

PR:		264653
Sponsored by:	NVIDIA Networking

(cherry picked from commit e4d178d093)
2022-06-20 13:08:39 +02:00
John Baldwin
e994b6f6d3 mlx5: Pass the correct data pointer to the add_dst_cb instead of NULL.
Reported by:	-Wunused-but-set-variable
Reviewed by:	hselasky
Differential Revision:	https://reviews.freebsd.org/D34812

(cherry picked from commit ebb16d5e93)
2022-05-13 10:43:25 -07:00
Hans Petter Selasky
51a9a42f0c mlx5en(4): Use hard-coded 4K page size for RQ/SQ/CQ.
The page size specified for RQ, SQ and CQ is always in units of 4KBytes.
Make sure we subtract MLX5_ADAPTER_PAGE_SHIFT, 12, instead of PAGE_SHIFT
which may vary. This fixes support for using the mlx5en driver on systems
having non-4K page size.

Linux commit:
68cdf5d6e91068c98d6091b193dc7a5ab7dcf5eb

Sponsored by:	NVIDIA Networking

(cherry picked from commit d735d604f0)
2022-05-10 10:02:28 +02:00
Gordon Bergling
f4dc553a72 mlx5en(4): Fix a few typos in source code comments
- s/persistant/persistent/

(cherry picked from commit 4a87beeccb)
2022-04-02 15:35:02 +02:00
Hans Petter Selasky
053dcbc86e mlx5/mlx4: Bump driver version to 3.7.1
Sponsored by:	NVIDIA Networking

(cherry picked from commit b18c510844)
2022-03-09 21:05:39 +01:00
Hans Petter Selasky
304a69596b mlx5ib: Add support for NDR link speed.
The IBTA specification has new speed - NDR. That speed supports signaling
rate of 100Gb. mlx5 IB driver translates link modes reported by ConnectX
device to IB speed and width. Added translation of new 100Gb, 200Gb and
400Gb link modes to NDR IB type and width of x1, x2 or x4 respectively.

Linux commits:
f946e45f59ef01ff54ffb3b1eba3a8e7915e7326

Sponsored by:	NVIDIA Networking

(cherry picked from commit 91c8ffd7e6)
2022-03-03 15:28:53 +01:00
Hans Petter Selasky
696e179e56 mlx5core: Add PCI IDs for ConnectX-8.
Sponsored by:	NVIDIA Networking

(cherry picked from commit eb16e362d6)
2022-03-03 15:28:53 +01:00
Hans Petter Selasky
d608562a75 mlx5core: Add PCI IDs for ConnectX-7.
Linux commits:
505a7f5478062c6cd11e22022d9f1bf64cd8eab3
dd8595eabeb486d41ad9994e6cece36e0e25e313

Sponsored by:	NVIDIA Networking

(cherry picked from commit ea8aacc523)
2022-03-03 15:28:53 +01:00
Hans Petter Selasky
b7ea0ff6a2 mlx5e: Make TLS tag zones unmanaged
These zones are cache zones used to allocate TLS offload contexts from
firmware.  Releasing items from the cache is a sleepable operation due
to the need to await a response from the firmware command freeing the
tag, so items cannot be reclaimed from the zone in non-sleepable
contexts.  Since the cache size is limited by firmware limits, avoid
this by setting UMA_ZONE_UNMANAGED to avoid reclamation by uma_timeout()
and the low memory handler.

Reviewed by:	hselasky, kib
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D34142

(cherry picked from commit 235ed6a486)
2022-02-24 10:59:38 +01:00
Hans Petter Selasky
adcd93a416 mlx5en: Use a UMA cache zone for managing TLS send tags
Instead of allocating directly from a normal zone. This way
import and release are guaranteed to process all allocated and then
deallocated items. Also, the release occurs in a sleepable context when
caller of uma_zfree() or uma_zdestroy() can sleep itself.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 0f7b6e11c0)
2022-02-24 10:59:19 +01:00
Hans Petter Selasky
353c1239fb mlx5en: Fix TLS worker thread race.
Create a dedicated free state, in case the taskqueue worker is still pending,
to avoid re-activation of a freed send tag.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 015f22f5d0)
2022-02-24 10:59:14 +01:00
Hans Petter Selasky
7b3bc182d0 mlx5en: Improve RX- and TX- TLS refcounting.
Use the send tag refcounting mechanism to refcount the RX- and TX- TLS
send tags. Then it is no longer needed to wait for refcounts to reach
zero when destroying RX- and TX- TLS send tags as a result of pending
data or WQE commands.

This also ensures that when TX-TLS and rate limiting is used at the same
time, the underlying SQ is not prematurely destroyed.

Sponsored by:	NVIDIA Networking

(cherry picked from commit ebdb700649)
2022-02-24 10:59:07 +01:00
Hans Petter Selasky
bafce48d55 mlx5en: Add missing refcount decrement on link-down.
Sponsored by:	NVIDIA Networking

(cherry picked from commit d2a788a522)
2022-02-24 10:59:01 +01:00
Hans Petter Selasky
4b5dd427cb mlx5en: Improve CQE error debugging.
Sponsored by:	NVIDIA Networking

(cherry picked from commit bc531a1faa)
2022-02-24 10:58:54 +01:00
Hans Petter Selasky
16635c7b21 mlx5en: Make sure the NIC IP addresses are written to firmware on link up.
Fixes e059c120b4 .

PR:		261746
Sponsored by:	NVIDIA Networking

(cherry picked from commit 04f407a3e5)
2022-02-11 11:15:00 +01:00
Hans Petter Selasky
7e5b40d818 mlx5core: Set driver version into firmware.
If the driver_version capability bit is enabled, send the driver
version to firmware after the init HCA command, for display purposes.

Example of driver version: "FreeBSD,mlx5_core,14.0.0,3.x-xxx"

Linux commits:
012e50e109fd27ff989492ad74c50ca7ab21e6a1

Sponsored by:	NVIDIA Networking

(cherry picked from commit e6d7ac1d03)
2022-02-08 16:08:54 +01:00
Hans Petter Selasky
5ddb1a584d mlx5en: Implement one RQT object per channel.
These objects will eventually be used to switch TLS RX traffic.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 8e332232a5)
2022-02-08 16:08:54 +01:00
Hans Petter Selasky
823bcb3a13 mlx5: Add raw ethernet local loopback support.
Currently, unicast/multicast loopback raw ethernet (non-RDMA) packets
are sent back to the vport.  A unicast loopback packet is the packet
with destination MAC address the same as the source MAC address.  For
multicast, the destination MAC address is in the vport's multicast
filter list.

Moreover, the local loopback is not needed if there is one or none
user space context.

After this patch, the raw ethernet unicast and multicast local
loopback are disabled by default. When there is more than one user
space context, the local loopback is enabled.

Note that when local loopback is disabled, raw ethernet packets are
not looped back to the vport and are forwarded to the next routing
level (eswitch, or multihost switch, or out to the wire depending on
the configuration).

Linux commits:
c85023e153e3824661d07307138fdeff41f6d86a
8978cc921fc7fad3f4d6f91f1da01352aeeeff25

Sponsored by:	NVIDIA Networking

(cherry picked from commit ea00d7e8ca)
2022-02-08 16:08:54 +01:00
Hans Petter Selasky
7fb8dd15fa mlx5: Implement mlx5_nic_vport_update_local_lb()
Sponsored by:	NVIDIA Networking

(cherry picked from commit c1b76119cb)
2022-02-08 16:08:54 +01:00
Hans Petter Selasky
952d47e5cc mlx5en: Create TIRs before flowtables.
Because flowtables may redirect traffic to TIRs.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 5381f93647)
2022-02-08 16:08:54 +01:00
Hans Petter Selasky
0c4de0f986 mlx5en: Create flowtables in correct order.
Because it affects how the flow tables may re-direct traffic.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 001106f807)
2022-02-08 16:08:53 +01:00
Hans Petter Selasky
26b0e75d64 mlx5: Implement flow steering helper functions for TCP sockets.
This change adds convenience functions to setup a flow steering rule based on
a TCP socket. The helper function gets all the address information from the
socket and returns a steering rule, to be used with HW TLS RX offload.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 2c0ade806a)
2022-02-08 16:08:53 +01:00
Hans Petter Selasky
513a6d84e9 mlx5: Implement offloads flowtable namespace.
This namespace will be used for TCP offloads, like hardware decryption
of TLS TCP data.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 0ee1b09eaa)
2022-02-08 16:08:53 +01:00
Hans Petter Selasky
f42aaf43d3 mlx5en: Create and destroy all flow tables and rules when the network interface attaches and detaches.
Previously flow steering tables and rules were only created and destroyed
at link up and down events, respectivly. Due to new requirements for adding
TLS RX flow tables and rules, the main flow steering table must always be
available as there are permanent redirections from the TLS RX flow table
to the vlan flow table.

Sponsored by:	NVIDIA Networking

(cherry picked from commit e059c120b4)
2022-02-08 16:08:53 +01:00
Hans Petter Selasky
e441376f45 mlx5en: Add race protection for SQ remap
Add a refcount for posted WQEs to avoid a race between
post WQE and FW command flows.

Sponsored by:	NVIDIA Networking

(cherry picked from commit a8e715d21b)
2022-02-08 16:08:53 +01:00
Hans Petter Selasky
75312cafe7 mlx5en: Properly account for no-checksum on tunneled packets.
Sponsored by:	NVIDIA Networking

(cherry picked from commit aabca1034c)
2022-02-08 16:08:53 +01:00
Hans Petter Selasky
428331a8bf mlx5en: Force all packets through the indirection table.
All packets must go through the indirection table, RQT,
because it is not possible to modify the RQN of the TIR
for direct dispatchment after it is created, typically
when the link goes up and down.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 06c2bd1872)
2022-02-08 16:08:53 +01:00
Hans Petter Selasky
c7ec839e30 mlx5/mlx5en: Add SQ remap support
Add support to map an SQ to a specific schedule queue using a
special WQE as performance enhancement.

SQ remap operation is handled by a privileged internal queue, IQ,
and the mapping is enabled from one rate to another.

The transition from paced to non-paced should however always go
through FW.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 266c81aae3)
2022-02-08 16:08:53 +01:00
Hans Petter Selasky
57b86395fe mlx5: Properly define the reg_umr_sq networking offload capability bit.
Sponsored by:	NVIDIA Networking

(cherry picked from commit 1c407d0494)
2022-02-08 16:08:52 +01:00
Hans Petter Selasky
95854550de mlx5en: Only delete installed VxLAN rules.
Sponsored by:	NVIDIA Networking

(cherry picked from commit 9680b1ba71)
2022-02-08 16:08:52 +01:00
Hans Petter Selasky
2c8132accd mlx5en: Fix inverted logical assignment.
Sponsored by:	NVIDIA Networking

(cherry picked from commit 6176a5e338)
2022-02-08 16:08:52 +01:00
Hans Petter Selasky
e53c3826c0 mlx5en: Implement support for internal queues, IQ.
Internal send queues are regular sendqueues which are reserved for WQE commands
towards the hardware and firmware. These queues typically carry resync
information for ongoing TLS RX connections and when changing schedule queues
for rate limited connections.

The internal queue, IQ, code is more or less a stripped down copy
of the existing SQ managing code with exception of:

1) An optional single segment memory buffer which can be read or
   written as a whole by the hardware, may be provided.
2) An optional completion callback for all transmit operations, may
   be provided.
3) Does not support mbufs.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 694263572f)
2022-02-08 16:08:52 +01:00
Hans Petter Selasky
4deb6e4fab mlx5en: Implement helper functions to open and close TLS TIR context.
Sponsored by:	NVIDIA Networking

(cherry picked from commit 21228c67ab)
2022-02-08 16:08:52 +01:00
Hans Petter Selasky
9aca511703 mlx5en: Share DEK objects with TLS RX.
The TLS RX support also needs to be able to allocate DEK objects.
Share the available objects 1:1.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 75767cb889)
2022-02-08 16:08:52 +01:00
Hans Petter Selasky
b5b957a8db mlx5en: Add missing TLS structure prototype.
Sponsored by:	NVIDIA Networking

(cherry picked from commit fad4b7d1f2)
2022-02-08 16:08:52 +01:00
Hans Petter Selasky
b324932190 mlx5en: Remove unused hardware TLS field.
Sponsored by:	NVIDIA Networking

(cherry picked from commit 3a1bf85503)
2022-02-08 16:08:52 +01:00
Hans Petter Selasky
3954e5380a mlx5en: Make the receive packet indirection table, RQT, static instead of dynamic.
Allocate the RQT once, pointing all initial entries to the drop RQN.
When opening the channels simplify modify the RQT, directing all traffic
to the new RQNs. Similarly when closing the channels point all RQT entries
back to the so-called drop RQN.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 33a6a7a72a)
2022-02-08 16:08:52 +01:00
Hans Petter Selasky
0c8b126da5 mlx5en: Set CQN in RQ parameters for drop RQ.
Else creating the drop RQ fails.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 7800af352a)
2022-02-08 16:08:51 +01:00
Hans Petter Selasky
e2c02a4920 mlx5en: Set channel pointer for drop receive queue.
A valid channel pointer is needed to get the priv pointer during init.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 03567b0dfa)
2022-02-08 16:08:51 +01:00
Hans Petter Selasky
e5b00e9b64 mlx5en: Print error code when opening drop RQ fails.
Sponsored by:	NVIDIA Networking

(cherry picked from commit 4e40e984da)
2022-02-08 16:08:51 +01:00
Hans Petter Selasky
62283a6345 mlx5en: Implement dummy receive queue, RQ, for dropping packets.
What is a drop RQ and why is it needed?

The RSS indirection table, also called the RQT, selects the
destination RQ based on the receive queue number, RQN. The RQT is
frequently referred to by flow steering rules to distribute traffic
among multiple RQs. The problem is that the RQs cannot be destroyed
before the RQT referring them is destroyed too. Further, TLS RX
rules may still be referring to the RQT even if the link went
down. Because there is no magic RQN for dropping packets, we create
a dummy RQ, also called drop RQ, which sole purpose is to drop all
received packets. When the link goes down this RQN is filled in all
RQT entries, of the main RQT, so the real RQs which are about to be
destroyed can be released and the TLS RX rules can be sustained.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 27b778ae55)
2022-02-08 16:08:51 +01:00
Hans Petter Selasky
7dedd4ba03 mlx5en: Make the hw_lro parameter read only tunable.
This prevents the so-called TIR context from changing during runtime.

Sponsored by:	NVIDIA Networking

(cherry picked from commit a60f953424)
2022-02-08 16:08:51 +01:00
Hans Petter Selasky
ecf32f2daa mlx5: Remove support for FreeBSD 10 and older.
Sponsored by:	NVIDIA Networking

(cherry picked from commit 788e9e7478)
2022-02-08 16:08:51 +01:00
Hans Petter Selasky
3be2f639a8 mlx5en: Patch to inhibit transmit doorbell writes during packet reception.
During packet reception the network stack frequently transmit data in
response to TCP window updates. To reduce the number of transmit doorbells
needed, inhibit all transmit doorbells designated for the same channel until
after the reception of packets for the given channel is completed.

While at it slightly refactor the mlx5e_tx_notify_hw() function:

1) The doorbell information is always stored into sq->doorbell.d64 .
No need to pass a separate pointer to this variable.

2) Move checks for skipping doorbell writes inside this function.

Sponsored by:	NVIDIA Networking

(cherry picked from commit 2d5e5a0d75)
2022-02-08 16:08:51 +01:00
Konstantin Belousov
19371d5334 mlx5ib: idiomatic use of preprocessor, in particular paths
(cherry picked from commit 028130b8e4)
2022-02-08 08:42:07 +02:00
Konstantin Belousov
0330cf6769 mlx5ib: normalize use of the opt_*.h files
(cherry picked from commit 7060097908)
2022-02-08 08:42:07 +02:00
Konstantin Belousov
fe68072877 mlx5en: idiomatic use of preprocessor, in particular paths
(cherry picked from commit 89918a2375)
2022-02-08 08:42:07 +02:00
Konstantin Belousov
6f8ed9c125 mlx5en: normalize use of the opt_*.h files
(cherry picked from commit b984b95693)
2022-02-08 08:42:07 +02:00
Hans Petter Selasky
c91a6860a3 mlx5: idiomatic use of preprocessor, in particular paths
(cherry picked from commit 12c56d7dc4)
2022-02-08 08:42:07 +02:00