Commit graph

40270 commits

Author SHA1 Message Date
Mark Johnston
8497b431f1 kvmclock: Fix initialization when EARLY_AP_STARTUP is not defined
To attach to the hypervisor, kvmclock needs to write a per-CPU MSR.
When EARLY_AP_STARTUP is not defined, device attach happens too early:
APs are not yet spun up, so smp_rendezvous only runs the callback on the
local CPU.  As a result, the timecounter only gets initialized on the
BSP, and then timekeeping is broken on SMP systems.

Implement handling for !EARLY_AP_STARTUP kernels: keep track of the CPU
on which device attach ran, and then use a SI_SUB_SMP SYSINIT to
register the rest of the CPUs with the hypervisor.

Reported by:	Shrikanth R Kamath <kshrikanth@juniper.net>
Reviewed by:	kib, jhb (earlier versions)
Sponsored by:	Klara, Inc.
Sponsored by:	Juniper Networks, Inc.
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D37705

(cherry picked from commit 568f552b04)
2023-01-29 13:55:42 -05:00
Alan Somers
8b7b81fd64 Switch wg(4) to the new if_clone KPI
Reviewed by:	jhb
Differential Revision: https://reviews.freebsd.org/D37740

(cherry picked from commit eb3f9a7aec)
2023-01-27 12:27:47 -07:00
Arthur Kiyanovski
a33b0a2ab2 ena: Update driver version to v2.6.2
Bug Fixes:
* Remove timer service re-arm on ena_restore_device failure.
* Re-Enable per-packet missing tx completion print

Minor Changes:
* Switch driver owners from Semihalf to Amazon in man file.

MFC after: 2 weeks
Sponsored by: Amazon, Inc.
Pull Request: https://github.com/freebsd/freebsd-src/pull/637

(cherry picked from commit e5de1d8dad)
2023-01-27 13:09:09 +01:00
David Arinzon
92761fcc3b ena: Remove timer service re-arm on ena_restore_device failure
In case the reset sequence fails (ena_destroy_device() followed by
ena_restore_device() calls) during ena_restore_device(), the driver
resources are being freed. After the clean-up, the timer service is
re-armed in order to try and re-initialize the driver state.
But, such an attempt would fail given that the resources are freed.
Moreover, this would actually cause either the system to fail or a
panic.
When the driver fails in ena_restore_device() procedure, the only
recovery is either unloading and loading the driver or instance
reboot.

This change removes the timer service re-arm in case of failure
in ena_restore_device().

MFC after: 2 weeks
Sponsored by: Amazon, Inc.
Fixes: 78554d0c70 ("ena: start timer service on attach")

(cherry picked from commit c4a85b8d68)
2023-01-27 13:08:55 +01:00
Arthur Kiyanovski
35797fe2ae ena: Re-Enable per-packet missing tx completion print
Commit [1] first added the ena_tx_buffer.print_once member,
so that a message about a missing tx completion is printed only
once per packet (and not every second when the watchdog runs).
In this commit print_once is initialized to true, and is set back
to false after detecting a missing tx completion and printing
a warning about it to dmesg.

Commit [2] incorrectly reverses the values assigned to print_once.
The variable is initialized to be true but is checked to be false
when a missing tx completion is detected. This is never true, and
therefore the warning print for each missing tx completion is never
printed since this commit.

Commit [3] added time passed since last TX cleanup to the missing
tx completions per-packet print. However, due to the issue in commit
[2], this time is never printed.

This commit reverses back the values assigned to ena_tx_buffer.print_once
erroneously by commit [2], bringing back to life the missing tx
completion per-packet print.

Also add a space after "." in the missing tx completion print.

[1] - 9b8d05b8ac ("Add support for Amazon Elastic Network Adapter (ENA) NIC")
[2] - 74dba3ad78 ("Split function checking for missing TX completion in ENA driver")
[3] - d8aba82b5c ("ena: Store ticks of last Tx cleanup")

Fixes: 74dba3ad78 ("Split function checking for missing TX completion in ENA driver")
Fixes: d8aba82b5c ("ena: Store ticks of last Tx cleanup")
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

(cherry picked from commit f01b2cd98e)
2023-01-27 13:08:48 +01:00
Warner Losh
761d30c8d0 ena: Remove write only variables
Sponsored by:		Netflix

(cherry picked from commit 094b2a2379)
2023-01-27 13:06:58 +01:00
John Baldwin
201f6507c0 ena: Remove unused variable.
(cherry picked from commit 4dab99b936)
2023-01-27 13:05:54 +01:00
John Baldwin
44180bc8e6 ena: Remove unused devclass argument to DRIVER_MODULE.
(cherry picked from commit 1dc1476cac)
2023-01-27 12:55:33 +01:00
Gordon Bergling
664ccd7e33 ath(4): Fix a sysctl description and a typo in a comment
- s/delimeter/delimiter/

(cherry picked from commit e4b7980c5c)
2023-01-26 11:48:00 +01:00
Steffen Dirkwinkel
026b0ff652
umodem: ignore CDC_CM descriptor for baltech smartcard reader
The CDC_CM descriptor points to the wrong interface for serial port use.
Ignore it to use the CDC_UNION descriptor.

usbconfig dump (spec at: https://usb.org/sites/default/files/CDC1.2_WMC1.1_012011.zip):
ugen0.2: <Baltech AG Smartcard Reader> at usbus0, cfg=0 md=HOST spd=FULL (12Mbps) pwr=ON (300mA)

  bLength = 0x0012
  bDescriptorType = 0x0001
  bcdUSB = 0x0200
  bDeviceClass = 0x0000  <Probed by interface class>
  bDeviceSubClass = 0x0000
  bDeviceProtocol = 0x0000
  bMaxPacketSize0 = 0x0040
  idVendor = 0x13ad
  idProduct = 0xf019
  bcdDevice = 0x0100
  iManufacturer = 0x0001  <Baltech AG>
  iProduct = 0x0002  <Smartcard Reader>
  iSerialNumber = 0x0003  <45031910>
  bNumConfigurations = 0x0001

 Configuration index 0

    bLength = 0x0009
    bDescriptorType = 0x0002
    wTotalLength = 0x0064
    bNumInterfaces = 0x0003
    bConfigurationValue = 0x0001
    iConfiguration = 0x0000  <no string>
    bmAttributes = 0x0080
    bMaxPower = 0x0096

    Interface 0
      bLength = 0x0009
      bDescriptorType = 0x0004
      bInterfaceNumber = 0x0000
      bAlternateSetting = 0x0000
      bNumEndpoints = 0x0001
      bInterfaceClass = 0x0003  <HID device>
      bInterfaceSubClass = 0x0000
      bInterfaceProtocol = 0x0000
      iInterface = 0x0000  <no string>

      Additional Descriptor

      bLength = 0x09
      bDescriptorType = 0x21
      bDescriptorSubType = 0x11
       RAW dump:
       0x00 | 0x09, 0x21, 0x11, 0x01, 0x00, 0x01, 0x22, 0xd0,
       0x08 | 0x00

     Endpoint 0
        bLength = 0x0007
        bDescriptorType = 0x0005
        bEndpointAddress = 0x0081  <IN>
        bmAttributes = 0x0003  <INTERRUPT>
        wMaxPacketSize = 0x0040
        bInterval = 0x0001
        bRefresh = 0x0000
        bSynchAddress = 0x0000

      Additional Descriptor

      bLength = 0x08
      bDescriptorType = 0x0b
      bDescriptorSubType = 0x01
       RAW dump:
       0x00 | 0x08, 0x0b, 0x01, 0x02, 0x02, 0x02, 0x00, 0x00

    Interface 1
      bLength = 0x0009
      bDescriptorType = 0x0004
      bInterfaceNumber = 0x0001
      bAlternateSetting = 0x0000
      bNumEndpoints = 0x0001
      bInterfaceClass = 0x0002  <Communication device>
      bInterfaceSubClass = 0x0002
      bInterfaceProtocol = 0x0000
      iInterface = 0x0000  <no string>

      Additional Descriptor

      bLength = 0x05
      bDescriptorType = 0x24
      bDescriptorSubType = 0x00
       RAW dump:
       0x00 | 0x05, 0x24, 0x00, 0x10, 0x01

      Additional Descriptor

      bLength = 0x04
      bDescriptorType = 0x24
      bDescriptorSubType = 0x02
       RAW dump:
       0x00 | 0x04, 0x24, 0x02, 0x00

      Additional Descriptor

      bLength = 0x05
      bDescriptorType = 0x24
      bDescriptorSubType = 0x06
       RAW dump:
       0x00 | 0x05, 0x24, 0x06, 0x01, 0x02

      Additional Descriptor

      bLength = 0x05
      bDescriptorType = 0x24
      bDescriptorSubType = 0x01
       RAW dump:
       0x00 | 0x05, 0x24, 0x01, 0x00, 0x01

     Endpoint 0
        bLength = 0x0007
        bDescriptorType = 0x0005
        bEndpointAddress = 0x0085  <IN>
        bmAttributes = 0x0003  <INTERRUPT>
        wMaxPacketSize = 0x0008
        bInterval = 0x0010
        bRefresh = 0x0000
        bSynchAddress = 0x0000

    Interface 2
      bLength = 0x0009
      bDescriptorType = 0x0004
      bInterfaceNumber = 0x0002
      bAlternateSetting = 0x0000
      bNumEndpoints = 0x0002
      bInterfaceClass = 0x000a  <CDC-data>
      bInterfaceSubClass = 0x0000
      bInterfaceProtocol = 0x0000
      iInterface = 0x0000  <no string>

     Endpoint 0
        bLength = 0x0007
        bDescriptorType = 0x0005
        bEndpointAddress = 0x0086  <IN>
        bmAttributes = 0x0002  <BULK>
        wMaxPacketSize = 0x0040
        bInterval = 0x0000
        bRefresh = 0x0000
        bSynchAddress = 0x0000

     Endpoint 1
        bLength = 0x0007
        bDescriptorType = 0x0005
        bEndpointAddress = 0x0006  <OUT>
        bmAttributes = 0x0002  <BULK>
        wMaxPacketSize = 0x0040
        bInterval = 0x0000
        bRefresh = 0x0000
        bSynchAddress = 0x0000

Reviewed by:		manu
MFC after:		1 week
Sponsored by:		Beckhoff Automation GmbH & Co. KG
Differential Revision:	https://reviews.freebsd.org/D37942

(cherry picked from commit 8580e334b0)
2023-01-25 07:55:13 +01:00
Steffen Dirkwinkel
d1cf19c70a
umodem: add quirk to ignore CDC_CM descriptor
Some devices have CDC_CM descriptors that would point us to
the wrong interfaces. Add a quirk to ignore those (prefering the
CDC_UNION descriptor effectively)

Reviewed by:		manu
MFC after:		1 week
Sponsored by:		Beckhoff Automation GmbH & Co. KG
Differential Revision:	https://reviews.freebsd.org/D37942

(cherry picked from commit 73c3e8b1de)
2023-01-25 07:55:12 +01:00
Warner Losh
b02419fc40 Revert "mips: remove saf1761"
Mips is still in stable/13, so this should not have been merged.

This reverts commit 622ab2c483.

Sponsored by:		Netflix
2023-01-24 21:00:23 -07:00
Warner Losh
622ab2c483 mips: remove saf1761
The saf1761 OTG support was only for mips targets (BERI?). Retire it.

Sponsored by:		Netflix
Reviewed by:		brooks
Differential Revision:	https://reviews.freebsd.org/D33706

(cherry picked from commit 44796b7e82)
2023-01-24 14:49:19 -07:00
John Baldwin
b0cb849d7f cxgbe: Various whitespace fixes.
Mostly trailing whitespace and spaces before tabs.

Sponsored by:	Chelsio Communications
Differential Revision:	https://reviews.freebsd.org/D37350

(cherry picked from commit 21186bdb2d)
2023-01-23 21:11:47 -08:00
John Baldwin
39455b3d37 wg: Drop the compat shim for sbcreatecontrol().
I had to make a few other changes when merging the driver to stable/13
anyway, so adjusting this as well isn't really a big deal.

MFC after:	3 days

(cherry picked from commit 573bd1fcf5)
2023-01-23 20:57:11 -08:00
John Baldwin
db3f075d87 psm: Swap the unit member in the softc for a device_t.
This entails various changes to make this driver more "modern"
(new-bus vs pre-new-bus) using device_log() and device_printf() rather
than psm%d.  It also fixes the device_busy/unbusy calls to use sc->dev
directly rather than looking the device_t up via the devclass and
unit.

Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D35006

(cherry picked from commit a6c09f20e8)
2023-01-23 20:43:52 -08:00
John Baldwin
ac44dcce62 smc: Rename constants for control register from CTR* to CTRL*.
This avoids a conflict with the recently-added CTR macro in
<sys/ktr.h>.

(cherry picked from commit 613e07c07f)
2023-01-23 20:34:43 -08:00
Alexander V. Chernikov
dfc6db8e18 netlink: add interface notification on link status / flags change.
* Add link-state change notifications by subscribing to ifnet_link_event.
 In the Linux netlink model, link state is reported in 2 places: first is
 the IFLA_OPERSTATE, which stores state per RFC2863.
 The second is an IFF_LOWER_UP interface flag. As many applications rely
 on the latter, reserve 1 bit from if_flags, named as IFF_NETLINK_1.
 This flag is mapped to IFF_LOWER_UP in the netlink headers. This is done
 to avoid making applications think this flag is actually
 supported / presented in non-netlink outputs.
* Add flag change notifications, by hooking into rt_ifmsg().
 In the netlink model, notification should include the bitmask for the
 change flags. Update rt_ifmsg() to include such bitmask.

Differential Revision: https://reviews.freebsd.org/D37597

(cherry picked from commit 1bcd230f95)
2023-01-23 22:04:03 +00:00
Andrew Turner
d6a01b37b7 Add Windows Dev Kit 2023 support to if_ure
The Windows Dev Kit 2023 has an if_ure NIC with custom vendor and
procuct IDs. Add them to the driver.

Tested by:	Robert Clausecker <fuz@fuz.su>
Obtained from:	OpenBSD
Sponsored by:	Arm Ltd

(cherry picked from commit e5b9b5ee8c)
2023-01-23 12:36:28 +00:00
Andrew Turner
52583b734d Check for more XHCI ACPI IDs
The Windows Dev Kit 2023 uses the XHCI-compliant USB controller without
standard debug ID in its ACPI tables. Check for both ID values found
on [1] in the XHCI ACPI attachment.

[1] https://learn.microsoft.com/en-us/windows-hardware/drivers/bringup/device-management-namespace-objects

Tested by:	Robert Clausecker <fuz@fuz.su>
Sponsored by:	Arm Ltd

(cherry picked from commit 8793196ca2)
2023-01-23 12:36:28 +00:00
Andrew Turner
7217ec3ed2 Add support for the new Arm Generic UART _HID
Historically the ACPI _HID for both the Arm PL011 and Generic UARTs
was ARMH0011. In the Arm Base Boot Requirements 2.0 the Generic UART
_HID is changed to ARMHB000. Use this new value in the PL011 driver
where we support both UART types.

This has been observed in some recent EDK2 builds.

Sponsored by: Arm Ltd

(cherry picked from commit f9ccec823a)
2023-01-23 12:36:28 +00:00
Andrew Turner
5930ae9291 Add support for an array of hwresets
In some drivers we need to assert and deassert a group of hardware
resets in any order. To support this add a new hwreset_array that
manages all hwresets defined for a device.

Reviewed by:	bz, manu, mmel
Sponsored by:	The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D37357

(cherry picked from commit 969935b86b)
2023-01-23 12:36:28 +00:00
Andrew Turner
cd5c028748 Include sys/systm.h in phy_usb.c for KASSERT
Rather than depending on header pollution include systm.h directly.

Sponsored by:	Innovate UK

(cherry picked from commit 754358108c)
2023-01-23 12:36:27 +00:00
Andrew Turner
5e54d4b719 Remove unneeded headers from clk_link.c
There is no OFW/FDT specific code in this file so the ofw headers can
be removed.

Sponsored by:	Innovate UK

(cherry picked from commit 83de695791)
2023-01-23 12:36:27 +00:00
Andrew Turner
1d54105b97 Stop relying on header pollution in sdhci_xenon.c
Include sys/malloc.h directly in sdhci_xenon.c to get the malloc(9)
definition rather than depend on header pollution.

Sponsored by:	The FreeBSD Foundation

(cherry picked from commit 232323a531)
2023-01-23 12:36:27 +00:00
Andrew Turner
8cefcdd456 Use SYSCTL_FOREACH in drm2
This was added recently. Use it to get the correct _FOREACH macro.

Sponsored by:	The FreeBSD Foundation

(cherry picked from commit e0853c9336)
2023-01-23 12:36:27 +00:00
Dmitry Salychev
d5a64a935b
Add initial DPAA2 support
DPAA2 is a hardware-level networking architecture found in some NXP
SoCs which contain hardware blocks including Management Complex
(MC, a command interface to manipulate DPAA2 objects), Wire Rate I/O
processor (WRIOP, packets distribution, queuing, drop decisions),
Queues and Buffers Manager (QBMan, Rx/Tx queues control, Rx buffer
pools) and the others.

The Management Complex runs NXP-supplied firmware which provides DPAA2
objects as an abstraction layer over those blocks to simplify an
access to the underlying hardware. Each DPAA2 object has its own
driver (to perform an initialization at least) and will be visible
as a separate device in the device tree.

Two new drivers (dpaa2_mc and dpaa2_rc) act like firmware buses in
order to form a hierarchy of the DPAA2 devices:

	acpiX (or simplebusX)
	  dpaa2_mcX
	    dpaa2_rcX
	      dpaa2_mcp0
	      ...
	      dpaa2_mcpN
	      dpaa2_bpX
	      dpaa2_macX
	      dpaa2_io0
	      ...
	      dpaa2_ioM
	      dpaa2_niX

dpaa2_mc is suppossed to be a root of the hierarchy, comes in ACPI
and FDT flavours and implements helper interfaces to allocate and
assign bus resources, MSI and "managed" DPAA2 devices (NXP treats some
of the objects as resources for the other DPAA2 objects to let them
function properly). Almost all of the DPAA2 objects are assigned to
the resource containers (dpaa2_rc) to implement isolation.

The initial implementation focuses on the DPAA2 network interface
to be operational. It is the most complex object in terms of
dependencies which uses I/O objects to transmit/receive packets.

Approved by:		bz (mentor)
Tested by:		manu, bz
Differential Revision:	https://reviews.freebsd.org/D36638

(cherry picked from commit ba7319e909)
(cherry picked from commit 7fb975c8fb)
(cherry picked from commit 2782ed8f6c)
(cherry picked from commit d6eabdac2e)
(cherry picked from commit 16295b0a5a)
(cherry picked from commit ff270fce16)
2023-01-22 15:06:23 +01:00
Konstantin Belousov
a45a846c24 md.c: another style fix
(cherry picked from commit ad8feb1ed9)
2023-01-22 11:18:09 +02:00
Konstantin Belousov
7c09d62011 Handle ERELOOKUP from VOP_FSYNC() in several other places
(cherry picked from commit 6189672e60)
2023-01-22 11:18:09 +02:00
Zhenlei Huang
0d44c5ae37 lio: Remove unneeded include
Reviewed by:		adiran, imp
Differential Revision:	https://reviews.freebsd.org/D36501

(cherry picked from commit d819ddba9a)
2023-01-19 23:44:05 +08:00
Warner Losh
05410bd672 bnxt: Only filter out i386
Only i386 is missing bus_read_8. The other 32-bit platforms can be fixed
with a cast to a printf.

Suggested by:	kevans
Sponsored by:	Netflix

(cherry picked from commit eb40e3e757)
2023-01-18 18:02:26 -07:00
Sumit Saxena
28497d1445 if_bnxt: Added support for mgmt interface for passthrough hwrms
Added support for application management interface. There are two types of commands supported:

1. Firmware IOCTLs: These ioctls are meant for firmware
   consumption. Driver acts as a transport for these.
2. Driver only IOCTLs: These ioctls are meant for driver
   consumption. Driver will serve these ioctls without sending them down
   to firmware.

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36448

(cherry picked from commit 58d84ef870)
2023-01-18 18:00:07 -07:00
Sumit Saxena
74eacab8dc if_bnxt: Add support for smaller backing_store_cfg message size
Add compat logic to fallback to the older/smaller backing_store_cfg
message size.

Reviewed by: imp
Differentil Revision: https://reviews.freebsd.org/D36447

(cherry picked from commit 2ed061f08d)
2023-01-18 18:00:06 -07:00
Sumit Saxena
ef55d4aace if_bnxt: Fix the PORT_PHY_CFG HWRM requests while setting Pause
Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36446

(cherry picked from commit 19a57f85ba)
2023-01-18 18:00:06 -07:00
Sumit Saxena
eed0ac16ed if_bnxt: Fix the issue when kernel invokes _init() again without _stop()
Fixed the issue when kernel invokes _init() when it is already in
_init() state by invoking _stop() in such case.

Reviewed by: imp
Differential Revsion: https://reviews.freebsd.org/D36445

(cherry picked from commit baef1301a2)
2023-01-18 18:00:06 -07:00
Sumit Saxena
5fe5b15763 if_bnxt: Remove sysctl node vlan_only which is not being used
Removed sysctl node vlan_only which is not being used after migrating
from l2_set_rx_mask to l2_filter_alloc.

Reviewed by: imp
Differential Revsion: https://reviews.freebsd.org/D36444

(cherry picked from commit 72e9dbb58c)
2023-01-18 18:00:06 -07:00
Sumit Saxena
2db3527350 if_bnxt: Add support for VLAN on Thor
Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36443

(cherry picked from commit 91fcacc355)
2023-01-18 18:00:06 -07:00
Sumit Saxena
2bab173f73 if_bnxt: Add support for RSS on Thor
Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36442

(cherry picked from commit cfdca95f78)
2023-01-18 18:00:06 -07:00
Sumit Saxena
9142a68da2 if_bnxt: Display firmware version along with SIT package version
Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36441

(cherry picked from commit 6033382aab)
2023-01-18 18:00:06 -07:00
Sumit Saxena
2f1d2b99e7 if_bnxt: Add support for async link status update
Reivewed by: imp
Differential Revision: https://reviews.freebsd.org/D36440

(cherry picked from commit fb4b7e02d2)
2023-01-18 18:00:06 -07:00
Sumit Saxena
c4cad5c108 if_bnxt: Add support for admin down/up and jumbo
Make ifconfig up/down work, as well as adding support for jumbo frames.

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36439

(cherry picked from commit 055196a7d7)
2023-01-18 18:00:06 -07:00
Sumit Saxena
de0aaf9eca if_bnxt: add support for Thor controller
Added support for Thor controller.
Below are the supported operations:

1. IPv4 ping (ICMP)
2. iperf / netperf (IPv4 TCP)
3. Promiscuous (tcpdump)
4. Can achieve 20 Gbps on a 25 G link (Uni-Di)
5. Can achieve 60 Gbps on a 100 G link (Uni-Di)
6. Port level and queue level driver stats.

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36438

(cherry picked from commit 8945584f93)
2023-01-18 18:00:05 -07:00
Sumit Saxena
86bf3fd82f if_bnxt: Convert all doorbell writes into function pointers
This is preparatory patch for making a base for Broadcom's Thor
controller support. It converts all doorbell writes into function
pointers.

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36437

(cherry picked from commit 49a3df78c7)
2023-01-18 18:00:05 -07:00
Sumit Saxena
e1741d6fd5 if_bnxt: update hsi_struct_def.h headers
Updates the drivers to Broadcom's latest:
	HWRM Version 1.10.2.34 using HSI definition version 1.8.4

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36436

(cherry picked from commit 97315f68fe)
2023-01-18 18:00:05 -07:00
John Baldwin
a815cf3b72 bnxt: Remove unused devclass argument to DRIVER_MODULE.
(cherry picked from commit 64d3221c61)
2023-01-18 18:00:05 -07:00
Warner Losh
eee5ebb851 bnxt: Remove dead write to cp_ring_id
Since this is read from memory, reading it and then ignoring it is dead
code...

Sponsored by:		Netflix

(cherry picked from commit 44b4f0370f)
2023-01-18 17:59:42 -07:00
Bjoern A. Zeeb
b3e602d9ac device_get_property: add a HANDLE case
This will resolve a reference and return the appropriate handle, a node
on the simplebus or an ACPI_HANDLE for ACPI.  For now we do not try to
further abstract the return type.

Reviewed by:	mw
Differential Revision: https://reviews.freebsd.org/D36793

(cherry picked from commit 99e6980fcf)
2023-01-18 13:22:13 +00:00
Gordon Bergling
5c7e6e56d9 mrsas(4): Fix a typo in a source code comment
- s/reqest/request/

(cherry picked from commit e018483b10)
2023-01-14 10:30:35 +01:00
Gordon Bergling
9b64036135 isci(4): Fix common typos in source code comments
- s/reuqest/request/
- s/requst/request/

(cherry picked from commit be51810f8d)
2023-01-14 10:30:03 +01:00
Gordon Bergling
7484e79e36 vr(4): Fix a typo in a source code comment
- s/reuqest/request/

(cherry picked from commit 70182a0cfb)
2023-01-14 10:29:15 +01:00