mirror of
https://github.com/opnsense/src.git
synced 2026-06-05 06:42:56 -04:00
25945af47e
GCC 13 complains that we might be writing too much to an on-stack buffer when createing a filename. In practice there is a check that filename isn't too long given the time format and other static characters so GCC is incorrect, but GCC isn't wrong that we're potentially trying to put a MAXPATHLEN length string + some other characters into a MAXPATHLEN buffer (if you ignore the check GCC can't realistically evaluate at compile time). Switch to snprintf to populate filename to ensure that future logic errors don't result in a stack overflow. Shorten the questionably named yyyymmdd buffer enough to slience the warning (checking the snprintf return value isn't sufficent) while preserving maximum flexibility for admins who use the -F option. MFC after: 3 days Sponsored by: Klara, Inc. Reviewed by: brooks Differential Revision: https://reviews.freebsd.org/D45086 |
||
|---|---|---|
| .. | ||
| tests | ||
| Makefile | ||
| Makefile.depend | ||
| Makefile.depend.options | ||
| tftp-file.c | ||
| tftp-file.h | ||
| tftp-io.c | ||
| tftp-io.h | ||
| tftp-options.c | ||
| tftp-options.h | ||
| tftp-transfer.c | ||
| tftp-transfer.h | ||
| tftp-utils.c | ||
| tftp-utils.h | ||
| tftpd.8 | ||
| tftpd.c | ||