opnsense-src/crypto/openssl/ssl/record
Pierre Pronchery b077aed33b Merge OpenSSL 3.0.9
Migrate to OpenSSL 3.0 in advance of FreeBSD 14.0.  OpenSSL 1.1.1 (the
version we were previously using) will be EOL as of 2023-09-11.

Most of the base system has already been updated for a seamless switch
to OpenSSL 3.0.  For many components we've added
`-DOPENSSL_API_COMPAT=0x10100000L` to CFLAGS to specify the API version,
which avoids deprecation warnings from OpenSSL 3.0.  Changes have also
been made to avoid OpenSSL APIs that were already deprecated in OpenSSL
1.1.1.  The process of updating to contemporary APIs can continue after
this merge.

Additional changes are still required for libarchive and Kerberos-
related libraries or tools; workarounds will immediately follow this
commit.  Fixes are in progress in the upstream projects and will be
incorporated when those are next updated.

There are some performance regressions in benchmarks (certain tests in
`openssl speed`) and in some OpenSSL consumers in ports (e.g.  haproxy).
Investigation will continue for these.

Netflix's testing showed no functional regression and a rather small,
albeit statistically significant, increase in CPU consumption with
OpenSSL 3.0.

Thanks to ngie@ and des@ for updating base system components, to
antoine@ and bofh@ for ports exp-runs and port fixes/workarounds, and to
Netflix and everyone who tested prior to commit or contributed to this
update in other ways.

PR:		271615
PR:		271656 [exp-run]
Relnotes:	Yes
Sponsored by:	The FreeBSD Foundation
2023-06-23 18:53:36 -04:00
..
dtls1_bitmap.c Merge OpenSSL 3.0.9 2023-06-23 18:53:36 -04:00
README.md Merge OpenSSL 3.0.9 2023-06-23 18:53:36 -04:00
rec_layer_d1.c Merge OpenSSL 3.0.9 2023-06-23 18:53:36 -04:00
rec_layer_s3.c Merge OpenSSL 3.0.9 2023-06-23 18:53:36 -04:00
record.h Merge OpenSSL 3.0.9 2023-06-23 18:53:36 -04:00
record_local.h Merge OpenSSL 3.0.9 2023-06-23 18:53:36 -04:00
ssl3_buffer.c Merge OpenSSL 3.0.9 2023-06-23 18:53:36 -04:00
ssl3_record.c Merge OpenSSL 3.0.9 2023-06-23 18:53:36 -04:00
ssl3_record_tls13.c Merge OpenSSL 3.0.9 2023-06-23 18:53:36 -04:00
tls_pad.c Merge OpenSSL 3.0.9 2023-06-23 18:53:36 -04:00

Record Layer Design

This file provides some guidance on the thinking behind the design of the record layer code to aid future maintenance.

The record layer is divided into a number of components. At the time of writing there are four: SSL3_RECORD, SSL3_BUFFER, DLTS1_BITMAP and RECORD_LAYER. Each of these components is defined by:

  1. A struct definition of the same name as the component
  2. A set of source files that define the functions for that component
  3. A set of accessor macros

All struct definitions are in record.h. The functions and macros are either defined in record.h or record_local.h dependent on whether they are intended to be private to the record layer, or whether they form part of the API to the rest of libssl.

The source files map to components as follows:

dtls1_bitmap.c                 -> DTLS1_BITMAP component
ssl3_buffer.c                  -> SSL3_BUFFER component
ssl3_record.c                  -> SSL3_RECORD component
rec_layer_s3.c, rec_layer_d1.c -> RECORD_LAYER component

The RECORD_LAYER component is a facade pattern, i.e. it provides a simplified interface to the record layer for the rest of libssl. The other 3 components are entirely private to the record layer and therefore should never be accessed directly by libssl.

Any component can directly access its own members - they are private to that component, e.g. ssl3_buffer.c can access members of the SSL3_BUFFER struct without using a macro. No component can directly access the members of another component, e.g. ssl3_buffer cannot reach inside the RECORD_LAYER component to directly access its members. Instead components use accessor macros, so if code in ssl3_buffer.c wants to access the members of the RECORD_LAYER it uses the RECORD_LAYER_* macros.

Conceptually it looks like this:

                      libssl
                         |
-------------------------|-----record.h------------------------------------
                         |
                  _______V______________
                 |                      |
                 |    RECORD_LAYER      |
                 |                      |
                 |    rec_layer_s3.c    |
                 |          ^           |
                 | _________|__________ |
                 ||                    ||
                 || DTLS1_RECORD_LAYER ||
                 ||                    ||
                 || rec_layer_d1.c     ||
                 ||____________________||
                 |______________________|
      record_local.h     ^   ^   ^
       _________________|   |   |_________________
      |                     |                     |
 _____V_________      ______V________      _______V________
|               |    |               |    |                |
| SSL3_BUFFER   |    | SSL3_RECORD   |    | DTLS1_BITMAP   |
|               |--->|               |    |                |
| ssl3_buffer.c |    | ssl3_record.c |    | dtls1_bitmap.c |
|_______________|    |_______________|    |________________|

The two RECORD_LAYER source files build on each other, i.e. the main one is rec_layer_s3.c which provides the core SSL/TLS layer. The second one is rec_layer_d1.c which builds off of the SSL/TLS code to provide DTLS specific capabilities. It uses some DTLS specific RECORD_LAYER component members which should only be accessed from rec_layer_d1.c. These are held in the DTLS1_RECORD_LAYER struct.