mirror of
https://github.com/opnsense/src.git
synced 2026-04-23 23:28:37 -04:00
ad677fb457
The unit.* code is largely obsolete and imposes limits that are no longer needed nowadays. - Capping the maximum allowed soundcards in a given machine. By default, the limit is 512 (snd_max_u() in unit.c), and the maximum possible is 2048 (SND_UNIT_UMAX in unit.h). It can also be tuned through the hw.snd.maxunit loader(8) tunable. Even though these limits are large enough that they should never cause problems, there is no need for this limit to exist in the first place. - Capping the available device/channel types. By default, this is 32 (snd_max_d() in unit.c). However, these types are pre-defined in pcm/sound.h (see SND_DEV_*), so the cap is unnecessary when we know that their number is constant. - Capping the number of channels per-device. By default, the limit 1024 (snd_max_c() in unit.c). This is probably the most problematic of the limits mentioned, because this limit can never be reached, as the maximum is hard-capped at either hw.snd.maxautovchans (16 by default), or SND_MAXHWCHAN and SND_MAXVCHANS. These limtits are encoded in masks (see SND_U_MASK, SND_D_MASK, SND_C_MASK in unit.h) and are used to construct a bitfield of the form [dsp_unit, type, channel_unit] in snd_mkunit() which is assigned to pcm_channel->unit. This patch gets rid of everything unit.*-related and makes a slightly different use of the "unit" field to only contain the channel unit number. The channel type is stored in a new pcm_channel->type field, and the DSP unit number need not be stored at all, since we can fetch it from device_get_unit(pcm_channel->dev). This change has the effect that we no longer need to impose caps on the number of soundcards, device/channel types and per-device channels. As a result the code is noticeably simplified and more readable. Apart from the fact that the hw.snd.maxunit loader(8) tunable is also retired as a side-effect of this patch, sound(4)'s behavior remains the same. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: dev_submerge.ch Differential Revision: https://reviews.freebsd.org/D44912 (cherry picked from commit 25723d66369fe6786e9e4f5f77381b944755f267) |
||
|---|---|---|
| .. | ||
| config.mk | ||
| dtb.build.mk | ||
| dtb.mk | ||
| files | ||
| files.amd64 | ||
| files.arm | ||
| files.arm64 | ||
| files.i386 | ||
| files.powerpc | ||
| files.riscv | ||
| files.x86 | ||
| kern.mk | ||
| kern.opts.mk | ||
| kern.post.mk | ||
| kern.pre.mk | ||
| kmod.mk | ||
| kmod.opts.mk | ||
| kmod_syms.awk | ||
| kmod_syms_prefix.awk | ||
| ldscript.amd64 | ||
| ldscript.arm | ||
| ldscript.arm64 | ||
| ldscript.i386 | ||
| ldscript.kmod.amd64 | ||
| ldscript.kmod.i386 | ||
| ldscript.powerpc | ||
| ldscript.powerpc64 | ||
| ldscript.powerpc64le | ||
| ldscript.powerpcspe | ||
| ldscript.riscv | ||
| Makefile.amd64 | ||
| Makefile.arm | ||
| Makefile.arm64 | ||
| Makefile.i386 | ||
| Makefile.powerpc | ||
| Makefile.riscv | ||
| newvers.sh | ||
| NOTES | ||
| options | ||
| options.amd64 | ||
| options.arm | ||
| options.arm64 | ||
| options.i386 | ||
| options.powerpc | ||
| options.riscv | ||
| std.nodebug | ||
| sysent.mk | ||
| systags.sh | ||
| vdso_amd64.ldscript | ||
| vdso_amd64_ia32.ldscript | ||
| WITHOUT_SOURCELESS | ||
| WITHOUT_SOURCELESS_HOST | ||
| WITHOUT_SOURCELESS_UCODE | ||