Greg Foster 3fbee9be25 lacp: short timeout erroneously declares link-flapping ... Panasas was seeing a higher-than-expected number of link-flap events. After joint debugging with the switch vendor, we determined there were problems on both sides; either of which might cause the occasional event, but together caused lots of them. On the switch side, an internal queuing issue was causing LACP PDUs -- which should be sent every second, in short-timeout mode -- to sometimes be sent slightly later than they should have been. In some cases, two successive PDUs were late, but we never saw three late PDUs in a row. On the FreeBSD side, we saw a link-flap event every time there were two late PDUs, while the spec says that it takes *three* seconds of downtime to trigger that event. It turns out that if a PDU was received shortly before the timer code was run, it would decrement less than a full second after the PDU arrived. Then two delayed PDUs would cause two additional decrements, causing it to reach zero less than three seconds after the most-recent on-time PDU. The solution is to note the time a PDU arrives, and only decrement if at least a full second has elapsed since then. Reported by: Greg Foster <gfoster@panasas.com> Reviewed by: gallatin Tested by: Greg Foster <gfoster@panasas.com> MFC after: 3 days Sponsored by: Panasas Differential Revision: https://reviews.freebsd.org/D35070 (cherry picked from commit 00a80538b4)		2022-05-01 12:16:18 -07:00
..
altq	altq: Fix panics on rmc_restart()	2021-08-30 10:02:14 +02:00
route	Fix kernel build without INET and INET6	2022-03-30 17:50:42 +00:00
bpf.c	vlan: deduplicate bpf_setpcp() and pf_ieee8021q_setpcp()	2021-08-02 16:50:32 +02:00
bpf.h	bpf: Add an ioctl to set the VLAN Priority on packets sent by bpf	2021-08-02 16:50:32 +02:00
bpf_buffer.c	Add an external mbuf buffer type that holds multiple unmapped pages.	2019-06-29 00:48:33 +00:00
bpf_buffer.h	sys: general adoption of SPDX licensing ID tags.	2017-11-27 15:23:17 +00:00
bpf_filter.c	sys: further adoption of SPDX licensing ID tags.	2017-11-20 19:43:44 +00:00
bpf_jitter.c	Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)	2020-02-26 14:26:36 +00:00
bpf_jitter.h	Make UMA and malloc(9) return non-executable memory in most cases.	2018-06-13 17:04:41 +00:00
bpf_zerocopy.c	Change synchonization rules for vm_page reference counting.	2019-09-09 21:32:42 +00:00
bpf_zerocopy.h	sys: general adoption of SPDX licensing ID tags.	2017-11-27 15:23:17 +00:00
bpfdesc.h	bpf: Add an ioctl to set the VLAN Priority on packets sent by bpf	2021-08-02 16:50:32 +02:00
bridgestp.c	bridgestp: validate timer values in config BPDU	2021-05-18 12:00:38 +02:00
bridgestp.h	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
debugnet.c	debugnet: Include some required headers	2021-09-21 09:37:42 -04:00
debugnet.h	Implement NetGDB(4)	2019-10-17 21:33:01 +00:00
debugnet_inet.c	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
debugnet_int.h	Implement NetGDB(4)	2019-10-17 21:33:01 +00:00
dlt.h	net(4): Fix a typo in a source code comment	2022-04-09 08:16:21 +02:00
ethernet.h	net(3): Fix a typo in a source code comment	2022-04-09 08:09:25 +02:00
firewire.h	sys: general adoption of SPDX licensing ID tags.	2017-11-27 15:23:17 +00:00
ieee8023ad_lacp.c	lacp: short timeout erroneously declares link-flapping	2022-05-01 12:16:18 -07:00
ieee8023ad_lacp.h	lacp: short timeout erroneously declares link-flapping	2022-05-01 12:16:18 -07:00
ieee_oui.h	Remove "All Rights Reserved" from FreeBSD Foundation sys/ copyrights	2022-02-08 15:00:55 -05:00
if.c	Fix ifa refcount leak in ifa_ifwithnet()	2022-03-07 12:41:40 -05:00
if.h	Widen ifnet_detach_sxlock coverage	2021-02-17 14:12:54 +01:00
if_arp.h	Improve ARP logging.	2019-03-09 01:12:59 +00:00
if_bridge.c	bridge: Don't share broadcast packets	2022-02-28 16:38:05 +01:00
if_bridgevar.h	bridge: fix STP roles and protos strings	2021-02-04 15:22:45 +01:00
if_clone.c	MFC 53729367d3: Fix subinterface vlan creation.	2021-02-04 22:21:00 +00:00
if_clone.h	epair: Do not abuse params to register the second interface	2020-01-28 22:44:24 +00:00
if_dead.c	This adds the third step in getting BBR into the tree. BBR and	2019-08-01 14:17:31 +00:00
if_debug.c	sys: general adoption of SPDX licensing ID tags.	2017-11-27 15:23:17 +00:00
if_disc.c	routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).	2021-09-07 21:25:06 +00:00
if_dl.h	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
if_edsc.c	if_edsc: generate an arbitrary MAC address	2020-03-02 02:45:57 +00:00
if_enc.c	Consistently include opt_ipsec.h for consumers of <netipsec/ipsec.h>.	2020-05-29 19:22:40 +00:00
if_enc.h	sys: general adoption of SPDX licensing ID tags.	2017-11-27 15:23:17 +00:00
if_epair.c	if_epair: build fix	2022-03-20 01:25:03 +01:00
if_ethersubr.c	routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).	2021-09-07 21:25:06 +00:00
if_fwsubr.c	routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).	2021-09-07 21:25:06 +00:00
if_gif.c	if_gif: fix vnet shutdown panic	2021-11-29 15:44:39 +01:00
if_gif.h	gif_transmit() must always be called in the network epoch.	2020-01-15 06:18:32 +00:00
if_gre.c	routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).	2021-09-07 21:25:06 +00:00
if_gre.h	Add GRE-in-UDP encapsulation support as defined in RFC8086.	2019-04-24 09:05:45 +00:00
if_infiniband.c	routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).	2021-09-07 21:25:06 +00:00
if_ipsec.c	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
if_ipsec.h
if_lagg.c	lagg: fix unused-but-set-variable	2021-11-26 04:40:56 +01:00
if_lagg.h	Fix for IPoIB over lagg(4).	2020-12-29 17:35:06 +01:00
if_llatbl.c	net: Fix memory leaks in lltable_calc_llheader() error paths	2022-04-15 10:21:20 -04:00
if_llatbl.h	routing: Add unified level-based logging support for the routing subsystem.	2022-03-28 08:48:12 +00:00
if_llc.h	sys: further adoption of SPDX licensing ID tags.	2017-11-20 19:43:44 +00:00
if_loop.c	routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).	2021-09-07 21:25:06 +00:00
if_me.c	routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).	2021-09-07 21:25:06 +00:00
if_media.c	if_media.c SIOCGMEDIAX handler: improve loop	2020-11-03 14:33:04 +00:00
if_media.h	if_media: definitions for 40GE LM4 ethernet media type	2020-09-16 14:45:16 +00:00
if_mib.c	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
if_mib.h
if_pflog.h	pflog: align header to 4 bytes, not 8	2022-02-09 10:40:58 +01:00
if_pfsync.h	pfsync: Expose PFSYNCF_OK flag to userspace	2021-05-10 21:45:57 +02:00
if_sppp.h
if_spppfr.c
if_spppsubr.c	routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).	2021-09-07 21:25:06 +00:00
if_stf.c	if_stf: style(9) pass	2021-12-01 16:53:19 +01:00
if_tap.h	tap: add support for virtio-net offloads	2019-10-18 21:53:27 +00:00
if_tun.h	if_tuntap(4): Add TUNGIFNAME	2019-07-25 22:23:34 +00:00
if_tuntap.c	routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).	2021-09-07 21:25:06 +00:00
if_types.h	net(3): Fix a typo in a source code comment	2022-04-09 08:10:23 +02:00
if_var.h	Enforce check for using the return result for ifa?_try_ref().	2021-09-07 21:01:31 +00:00
if_vlan.c	Retore the vnet before returning an error.	2021-09-05 18:25:44 -04:00
if_vlan_var.h	vlan: deduplicate bpf_setpcp() and pf_ieee8021q_setpcp()	2021-08-02 16:50:32 +02:00
if_vxlan.c	vxlan(4): Fix two typos in sysctl descriptions	2022-04-02 15:33:48 +02:00
if_vxlan.h	if_vxlan(4): add support for hardware assisted checksumming, TSO, and RSS.	2020-09-18 02:37:57 +00:00
ifdi_if.m	iflib: Stop interface before (un)registering VLAN	2020-04-27 22:02:44 +00:00
iflib.c	iflib: Allow drivers to determine which queue to TX on	2022-03-07 16:10:27 -08:00
iflib.h	iflib: Allow drivers to determine which queue to TX on	2022-03-07 16:10:27 -08:00
iflib_clone.c	iflib: Fix detach of pseudo interfaces	2021-02-24 10:20:55 -05:00
iflib_private.h	- Replace unused and only ever written to members of public iflib(9)	2019-06-15 11:07:41 +00:00
ifq.h	Make net/ifq.h C++ friendly	2020-11-20 14:45:45 +00:00
infiniband.h	Factor out generic IP over infiniband, IPoIB, definitions and code	2020-10-22 09:09:53 +00:00
mp_ring.c	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
mp_ring.h	mp_ring: avoid items offset difference between iflib and mp_ring	2019-01-03 23:06:05 +00:00
mppc.h
mppcc.c	kernel: provide panicky version of __unreachable	2020-05-13 18:07:37 +00:00
mppcd.c
netisr.c	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
netisr.h	sys: general adoption of SPDX licensing ID tags.	2017-11-27 15:23:17 +00:00
netisr_internal.h	sys: general adoption of SPDX licensing ID tags.	2017-11-27 15:23:17 +00:00
netmap.h	netmap: monitor: add a flag to distinguish packet direction	2021-09-26 14:00:04 +00:00
netmap_legacy.h	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
netmap_user.h	netmap: fix constness warnings generated by "-Wcast-qual"	2020-10-03 09:33:29 +00:00
netmap_virt.h	netmap: disable passthrough with no hypervisor support	2020-01-13 21:47:23 +00:00
paravirt.h
pfil.c	Since now drivers that support pfil run their interrupts in the network	2020-01-23 01:49:22 +00:00
pfil.h	Most Ethernet drivers that potentially can run a pfil(9) hook with	2019-03-10 17:20:09 +00:00
pfkeyv2.h	Add SADB_SAFLAGS_ESN flag	2020-10-16 11:22:29 +00:00
pfvar.h	pf(4): Fix a typo in a source code comment	2022-03-30 18:36:06 +02:00
ppp_defs.h
radix.c	routing: Fix crashes with dpdk_lpm[46] algo.	2021-09-07 21:02:58 +00:00
radix.h	routing: Fix crashes with dpdk_lpm[46] algo.	2021-09-07 21:02:58 +00:00
raw_cb.c	Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)	2020-02-26 14:26:36 +00:00
raw_cb.h	sys: further adoption of SPDX licensing ID tags.	2017-11-20 19:43:44 +00:00
raw_usrreq.c	socket: Implement SO_RERROR	2021-08-10 18:54:00 -07:00
rndis.h	Hyper-V: hn: Enable vSwitch RSC support in hn netvsc driver	2021-03-29 03:20:03 -07:00
route.c	routing: fix source address selection rules for IPv4 over IPv6.	2021-12-04 19:02:52 +00:00
route.h	net(3): Fix a typo in a source code comment	2022-04-09 08:12:28 +02:00
rss_config.c	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
rss_config.h	rss: Remove never defined UDP_IPV4_EX	2017-10-11 06:08:01 +00:00
rtsock.c	Add required sysctl name length checks to various handlers	2021-07-29 20:32:58 -04:00
sff8436.h	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
sff8472.h	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
slcompress.c	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
slcompress.h	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00
toeplitz.c
toeplitz.h
vnet.c	Widen ifnet_detach_sxlock coverage	2021-02-17 14:12:54 +01:00
vnet.h	net: clean up empty lines in .c and .h files	2020-09-01 21:19:14 +00:00