mirror of
https://github.com/opnsense/src.git
synced 2026-06-07 15:52:40 -04:00
51a8eb6410
Kyua and ATF speak different naming styles. In this case, the
unprivileged user property can be named with underscore on the Kyua
side, and with a hyphen on the ATF side. Sometimes it is not obvious
which style should be used in which situation. For instance, a test case
may require this configuration property being set using require.config.
Also, a test case may want to read the property using something like
atf_tc_get_config_var(). Which names should be used in these cases?
From the perspective of the original code, it is expected to be this:
require.config unprivileged-user
atf_tc_get_config_var(tc, "unprivileged-user")
But, as long as Kyua is the main interface, its users expect to work
with kyua.conf(5), which says that it must be named as unprivileged_user
(with underscore). As a result, test authors tend to do this instead:
require.config unprivileged_user
atf_tc_get_config_var(tc, "unprivileged_user")
Kyua already has hacks to understand both unprivileged_user and
unprivileged-user coming from require.config. And this patch covers the
missing second part -- make Kyua pass both names back to ATF as two
identical configuration properties named different ways.
Reviewed by: ngie, asomers
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D49039
|
||
|---|---|---|
| .. | ||
| arm-optimized-routines | ||
| atf | ||
| bc | ||
| bearssl | ||
| bionic-x86_64-string | ||
| blocklist | ||
| bmake | ||
| bsddialog | ||
| bsnmp | ||
| byacc | ||
| bzip2 | ||
| capsicum-test | ||
| com_err | ||
| dialog | ||
| diff | ||
| dma | ||
| ee | ||
| elftoolchain | ||
| expat | ||
| file | ||
| flex | ||
| gdtoa | ||
| googletest | ||
| hyperv/tools | ||
| jemalloc | ||
| kyua | ||
| ldns | ||
| ldns-host | ||
| less | ||
| lib9p | ||
| libarchive | ||
| libbegemot | ||
| libc-pwcache | ||
| libc-vis | ||
| libcbor | ||
| libcxxrt | ||
| libder | ||
| libdiff | ||
| libdivsufsort | ||
| libedit | ||
| libevent | ||
| libexecinfo | ||
| libfido2 | ||
| libpcap | ||
| libucl | ||
| libxo | ||
| llvm-project | ||
| lua | ||
| lutok | ||
| mandoc | ||
| mknod | ||
| mtree | ||
| ncurses | ||
| netbsd-tests | ||
| netcat | ||
| ntp | ||
| nvi | ||
| ofed | ||
| one-true-awk | ||
| openbsm | ||
| opencsd/decoder | ||
| openpam | ||
| openresolv | ||
| pam_modules/pam_passwdqc | ||
| pf | ||
| pjdfstest | ||
| pnglite | ||
| pnpinfo | ||
| processor-trace | ||
| sendmail | ||
| smbfs | ||
| spleen | ||
| sqlite3 | ||
| tcp_wrappers | ||
| tcpdump | ||
| tcsh | ||
| telnet | ||
| terminus | ||
| tnftp | ||
| tzcode | ||
| tzdata | ||
| unbound | ||
| unifdef | ||
| unvis | ||
| vis | ||
| wireguard-tools | ||
| wpa | ||
| xz | ||