mirror of
https://github.com/opnsense/src.git
synced 2026-05-27 03:33:51 -04:00
b75e0eed34
According to pam_exec(8), the `expose_authtok` option should be ignored when the service function is `pam_sm_setcred`. Currently `pam_exec` only prevent prompt for anth token when `expose_authtok` is set on `pam_sm_setcred`. This subsequently led to segfault when there isn't an existing auth token available. Bug reported on this: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263893 After reading https://reviews.freebsd.org/rS349556 I am not sure if the default behaviour supposed to be simply not prompt for authentication token, or is it to ignore the option entirely as stated in the man page. This patch is therefore only adding an additional NULL check on the item `pam_get_item` provide, and exit with `PAM_SYSTEM_ERR` when such item is NULL. MFC after: 1 week Reviewed by: des, khng Differential Revision: https://reviews.freebsd.org/D35169 |
||
|---|---|---|
| .. | ||
| pam_chroot | ||
| pam_deny | ||
| pam_echo | ||
| pam_exec | ||
| pam_ftpusers | ||
| pam_group | ||
| pam_guest | ||
| pam_krb5 | ||
| pam_ksu | ||
| pam_lastlog | ||
| pam_login_access | ||
| pam_nologin | ||
| pam_opie | ||
| pam_opieaccess | ||
| pam_passwdqc | ||
| pam_permit | ||
| pam_radius | ||
| pam_rhosts | ||
| pam_rootok | ||
| pam_securetty | ||
| pam_self | ||
| pam_ssh | ||
| pam_tacplus | ||
| pam_unix | ||
| Makefile | ||
| Makefile.inc | ||
| modules.inc | ||